Go back to resetting the State parameter for all parts of a SOG when SOG.ClearPartAttachmentData() is called.

Even though we don't use these on rez they are still present after an unlink, after which selecting them causes various viewers to crash
Hopefully really does address http://opensimulator.org/mantis/view.php?id=5664

1 files changed, 8 insertions, 5 deletions

diff --git a/OpenSim/Region/CoreModules/Framework/InventoryAccess/InventoryAccessModule.cs b/OpenSim/Region/CoreModules/Framework/InventoryAccess/InventoryAccessModule.cs
index e6b58b3..4b39341 100644
--- a/OpenSim/Region/CoreModules/Framework/InventoryAccess/InventoryAccessModule.cs
+++ b/OpenSim/Region/CoreModules/Framework/InventoryAccess/InventoryAccessModule.cs
@@ -794,14 +794,17 @@ namespace OpenSim.Region.CoreModules.Framework.InventoryAccess
                     m_log.Debug("[InventoryAccessModule]: Object has UUID.Zero! Position 3");
                 }
 
-                // If it's rezzed in world, select it. Much easier to
-                // find small items.
-                //
                 if (!attachment)
                 {
+                    // If it's rezzed in world, select it. Much easier to
+                    // find small items.
+                    //
                     group.RootPart.CreateSelected = true;
-                    foreach (SceneObjectPart child in group.Parts)
-                        child.CreateSelected = true;
+
+                    foreach (SceneObjectPart part in group.Parts)
+                    {
+                        part.CreateSelected = true;
+                    }
                 }
 
                 group.ResetIDs();