* Mother of all commits:

* Cleaned up copyright notices in AssemblyInfo.cs's
* Added Copyright headers to a bunch of files missing them
* Replaced several common string instances with a static constant to prevent reallocation of the same strings thousands of times. "" -> String.Empty is the first such candidate.

3 files changed, 16 insertions, 16 deletions

diff --git a/OpenSim/Framework/Communications/Cache/AssetCache.cs b/OpenSim/Framework/Communications/Cache/AssetCache.cs
index 988c558..6d9a0d6 100644
--- a/OpenSim/Framework/Communications/Cache/AssetCache.cs
+++ b/OpenSim/Framework/Communications/Cache/AssetCache.cs
@@ -208,7 +208,7 @@ namespace OpenSim.Framework.Communications.Cache
         /// <param name="asset"></param>
         public void AddAsset(AssetBase asset)
         {
-            string temporary = asset.Temporary ? "temporary" : "";
+            string temporary = asset.Temporary ? "temporary" : String.Empty;
             string type = asset.Type == 0 ? "texture" : "asset";
 
             string result = "Ignored";
diff --git a/OpenSim/Framework/Communications/Cache/AssetTransactions.cs b/OpenSim/Framework/Communications/Cache/AssetTransactions.cs
index dd1f8ba..74e2093 100644
--- a/OpenSim/Framework/Communications/Cache/AssetTransactions.cs
+++ b/OpenSim/Framework/Communications/Cache/AssetTransactions.cs
@@ -123,8 +123,8 @@ namespace OpenSim.Framework.Communications.Cache
             public LLUUID TransactionID = LLUUID.Zero;
             public bool UploadComplete;
             public ulong XferID;
-            private string m_name = "";
-            private string m_description = "";
+            private string m_name = String.Empty;
+            private string m_description = String.Empty;
             private sbyte type = 0;
             private sbyte invType = 0;
             private uint nextPerm = 0;
@@ -331,12 +331,12 @@ namespace OpenSim.Framework.Communications.Cache
             // Fields
             private BaseHttpServer httpListener;
             private LLUUID inventoryItemID;
-            private string m_assetDescription = "";
-            private string m_assetName = "";
+            private string m_assetDescription = String.Empty;
+            private string m_assetName = String.Empty;
             private LLUUID m_folderID;
             private LLUUID newAssetID;
             private bool m_dumpImageToFile;
-            private string uploaderPath = "";
+            private string uploaderPath = String.Empty;
 
             // Events
             public event UpLoadedAsset OnUpLoad;
@@ -367,7 +367,7 @@ namespace OpenSim.Framework.Communications.Cache
             public string uploaderCaps(byte[] data, string path, string param)
             {
                 LLUUID inventoryItemID = this.inventoryItemID;
-                string text = "";
+                string text = String.Empty;
                 LLSDAssetUploadComplete complete = new LLSDAssetUploadComplete();
                 complete.new_asset = newAssetID.ToString();
                 complete.new_inventory_item = inventoryItemID;
@@ -380,7 +380,7 @@ namespace OpenSim.Framework.Communications.Cache
                 }
                 if (OnUpLoad != null)
                 {
-                    OnUpLoad(m_assetName, "description", newAssetID, inventoryItemID, LLUUID.Zero, data, "", "");
+                    OnUpLoad(m_assetName, "description", newAssetID, inventoryItemID, LLUUID.Zero, data, String.Empty, String.Empty);
                 }
                 return text;
             }
@@ -391,10 +391,10 @@ namespace OpenSim.Framework.Communications.Cache
             // Fields
             private BaseHttpServer httpListener;
             private LLUUID inventoryItemID;
-            private string m_assetName = "";
+            private string m_assetName = String.Empty;
             private LLUUID newAssetID;
             private bool SaveImages = false;
-            private string uploaderPath = "";
+            private string uploaderPath = String.Empty;
 
             // Events
             public event UpLoadedAsset OnUpLoad;
@@ -420,7 +420,7 @@ namespace OpenSim.Framework.Communications.Cache
             public string uploaderCaps(byte[] data, string path, string param)
             {
                 LLUUID inventoryItemID = this.inventoryItemID;
-                string text = "";
+                string text = String.Empty;
                 LLSDAssetUploadComplete complete = new LLSDAssetUploadComplete();
                 complete.new_asset = newAssetID.ToString();
                 complete.new_inventory_item = inventoryItemID;
@@ -433,7 +433,7 @@ namespace OpenSim.Framework.Communications.Cache
                 }
                 if (OnUpLoad != null)
                 {
-                    OnUpLoad(m_assetName, "description", newAssetID, inventoryItemID, LLUUID.Zero, data, "", "");
+                    OnUpLoad(m_assetName, "description", newAssetID, inventoryItemID, LLUUID.Zero, data, String.Empty, String.Empty);
                 }
                 return text;
             }
diff --git a/OpenSim/Framework/Communications/Cache/LibraryRootFolder.cs b/OpenSim/Framework/Communications/Cache/LibraryRootFolder.cs
index 46ae9ce..ae07898 100644
--- a/OpenSim/Framework/Communications/Cache/LibraryRootFolder.cs
+++ b/OpenSim/Framework/Communications/Cache/LibraryRootFolder.cs
@@ -152,13 +152,13 @@ namespace OpenSim.Framework.Communications.Cache
         {
             string foldersPath 
                 = Path.Combine(
-                    Util.inventoryDir(), config.GetString("foldersFile", ""));
+                    Util.inventoryDir(), config.GetString("foldersFile", System.String.Empty));
             
             LoadFromFile(foldersPath, "Library folders", ReadFolderFromConfig);
             
             string itemsPath 
                 = Path.Combine(
-                    Util.inventoryDir(), config.GetString("itemsFile", ""));
+                    Util.inventoryDir(), config.GetString("itemsFile", System.String.Empty));
             
             LoadFromFile(itemsPath, "Library items", ReadItemFromConfig);
         }
@@ -210,8 +210,8 @@ namespace OpenSim.Framework.Communications.Cache
             item.inventoryID = new LLUUID(config.GetString("inventoryID", folderID.ToString()));
             item.assetID = new LLUUID(config.GetString("assetID", LLUUID.Random().ToString()));
             item.parentFolderID = new LLUUID(config.GetString("folderID", folderID.ToString()));
-            item.inventoryDescription = config.GetString("description", "");
-            item.inventoryName = config.GetString("name", "");
+            item.inventoryDescription = config.GetString("description", System.String.Empty);
+            item.inventoryName = config.GetString("name", System.String.Empty);
             item.assetType = config.GetInt("assetType", 0);
             item.invType = config.GetInt("inventoryType", 0);
             item.inventoryCurrentPermissions = (uint)config.GetLong("currentPermissions", 0x7FFFFFFF);