MSSQL Additions for Presence Refactor branch. Most functionality tested and works, some outstanding issues around login location and border crossings on y axis.

Signed-off-by: Melanie <melanie@t-data.com>

1 files changed, 4 insertions, 221 deletions

diff --git a/OpenSim/Data/MSSQL/MSSQLManager.cs b/OpenSim/Data/MSSQL/MSSQLManager.cs
index 3d7a768..4309b42 100644
--- a/OpenSim/Data/MSSQL/MSSQLManager.cs
+++ b/OpenSim/Data/MSSQL/MSSQLManager.cs
@@ -46,22 +46,7 @@ namespace OpenSim.Data.MSSQL
         /// <summary>
         /// Connection string for ADO.net
         /// </summary>
-        private readonly string connectionString;
-
-        public MSSQLManager(string dataSource, string initialCatalog, string persistSecurityInfo, string userId,
-                            string password)
-        {
-            SqlConnectionStringBuilder builder = new SqlConnectionStringBuilder();
-
-            builder.DataSource = dataSource;
-            builder.InitialCatalog = initialCatalog;
-            builder.PersistSecurityInfo = Convert.ToBoolean(persistSecurityInfo);
-            builder.UserID = userId;
-            builder.Password = password;
-            builder.ApplicationName = Assembly.GetEntryAssembly().Location;
-
-            connectionString = builder.ToString();
-        }
+        private readonly string connectionString;      
 
         /// <summary>
         /// Initialize the manager and set the connectionstring
@@ -72,94 +57,6 @@ namespace OpenSim.Data.MSSQL
             connectionString = connection;
         }
 
-        public SqlConnection DatabaseConnection()
-        {
-            SqlConnection conn = new SqlConnection(connectionString);
-
-            //TODO is this good??? Opening connection here
-            conn.Open();
-
-            return conn;
-        }
-
-        #region Obsolete functions, can be removed!
-
-        /// <summary>
-        ///
-        /// </summary>
-        /// <param name="dt"></param>
-        /// <param name="name"></param>
-        /// <param name="type"></param>
-        [Obsolete("Do not use!")]
-        protected static void createCol(DataTable dt, string name, Type type)
-        {
-            DataColumn col = new DataColumn(name, type);
-            dt.Columns.Add(col);
-        }
-
-        /// <summary>
-        /// Define Table function
-        /// </summary>
-        /// <param name="dt"></param>
-        /// <returns></returns>
-/*
-        [Obsolete("Do not use!")]
-        protected static string defineTable(DataTable dt)
-        {
-            string sql = "create table " + dt.TableName + "(";
-            string subsql = String.Empty;
-            foreach (DataColumn col in dt.Columns)
-            {
-                if (subsql.Length > 0)
-                {
-                    // a map function would rock so much here
-                    subsql += ",\n";
-                }
-
-                subsql += col.ColumnName + " " + SqlType(col.DataType);
-                if (col == dt.PrimaryKey[0])
-                {
-                    subsql += " primary key";
-                }
-            }
-            sql += subsql;
-            sql += ")";
-            return sql;
-        }
-*/
-
-        #endregion
-
-        /// <summary>
-        /// Type conversion function
-        /// </summary>
-        /// <param name="type">a type</param>
-        /// <returns>a sqltype</returns>
-        /// <remarks>this is something we'll need to implement for each db slightly differently.</remarks>
-/*
-        [Obsolete("Used by a obsolete methods")]
-        public static string SqlType(Type type)
-        {
-            if (type == typeof(String))
-            {
-                return "varchar(255)";
-            }
-            if (type == typeof(Int32))
-            {
-                return "integer";
-            }
-            if (type == typeof(Double))
-            {
-                return "float";
-            }
-            if (type == typeof(Byte[]))
-            {
-                return "image";
-            }
-            return "varchar(255)";
-        }
-*/
-
         /// <summary>
         /// Type conversion to a SQLDbType functions
         /// </summary>
@@ -286,134 +183,20 @@ namespace OpenSim.Data.MSSQL
         private static readonly Dictionary<string, string> emptyDictionary = new Dictionary<string, string>();
 
         /// <summary>
-        /// Run a query and return a sql db command
-        /// </summary>
-        /// <param name="sql">The SQL query.</param>
-        /// <returns></returns>
-        internal AutoClosingSqlCommand Query(string sql)
-        {
-            return Query(sql, emptyDictionary);
-        }
-
-        /// <summary>
-        /// Runs a query with protection against SQL Injection by using parameterised input.
-        /// </summary>
-        /// <param name="sql">The SQL string - replace any variables such as WHERE x = "y" with WHERE x = @y</param>
-        /// <param name="parameters">The parameters - index so that @y is indexed as 'y'</param>
-        /// <returns>A Sql DB Command</returns>
-        internal AutoClosingSqlCommand Query(string sql, Dictionary<string, string> parameters)
-        {
-            SqlCommand dbcommand = DatabaseConnection().CreateCommand();
-            dbcommand.CommandText = sql;
-            foreach (KeyValuePair<string, string> param in parameters)
-            {
-                dbcommand.Parameters.AddWithValue(param.Key, param.Value);
-            }
-
-            return new AutoClosingSqlCommand(dbcommand);
-        }
-
-        /// <summary>
-        /// Runs a query with protection against SQL Injection by using parameterised input.
-        /// </summary>
-        /// <param name="sql">The SQL string - replace any variables such as WHERE x = "y" with WHERE x = @y</param>
-        /// <param name="sqlParameter">A parameter - use createparameter to create parameter</param>
-        /// <returns></returns>
-        internal AutoClosingSqlCommand Query(string sql, SqlParameter sqlParameter)
-        {
-            SqlCommand dbcommand = DatabaseConnection().CreateCommand();
-            dbcommand.CommandText = sql;
-            dbcommand.Parameters.Add(sqlParameter);
-
-            return new AutoClosingSqlCommand(dbcommand);
-        }
-
-        /// <summary>
         /// Checks if we need to do some migrations to the database
         /// </summary>
         /// <param name="migrationStore">migrationStore.</param>
         public void CheckMigration(string migrationStore)
         {
-            using (SqlConnection connection = DatabaseConnection())
+            using (SqlConnection connection = new SqlConnection(connectionString)) 
             {
+                connection.Open();
                 Assembly assem = GetType().Assembly;
                 MSSQLMigration migration = new MSSQLMigration(connection, assem, migrationStore);
 
                 migration.Update();
-
-                connection.Close();
             }
-        }
-
-        #region Old Testtable functions
-
-        /// <summary>
-        /// Execute a SQL statement stored in a resource, as a string
-        /// </summary>
-        /// <param name="name">the ressource string</param>
-        public void ExecuteResourceSql(string name)
-        {
-            using (IDbCommand cmd = Query(getResourceString(name), new Dictionary<string, string>()))
-            {
-                cmd.ExecuteNonQuery();
-            }
-        }
-
-        /// <summary>
-        /// Given a list of tables, return the version of the tables, as seen in the database
-        /// </summary>
-        /// <param name="tableList"></param>
-        public void GetTableVersion(Dictionary<string, string> tableList)
-        {
-            Dictionary<string, string> param = new Dictionary<string, string>();
-            param["dbname"] = new SqlConnectionStringBuilder(connectionString).InitialCatalog;
-
-            using (IDbCommand tablesCmd =
-                Query("SELECT TABLE_NAME FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_CATALOG=@dbname", param))
-            using (IDataReader tables = tablesCmd.ExecuteReader())
-            {
-                while (tables.Read())
-                {
-                    try
-                    {
-                        string tableName = (string)tables["TABLE_NAME"];
-                        if (tableList.ContainsKey(tableName))
-                            tableList[tableName] = tableName;
-                    }
-                    catch (Exception e)
-                    {
-                        m_log.Error(e.ToString());
-                    }
-                }
-                tables.Close();
-            }
-
-        }
-
-        /// <summary>
-        ///
-        /// </summary>
-        /// <param name="name"></param>
-        /// <returns></returns>
-        private string getResourceString(string name)
-        {
-            Assembly assem = GetType().Assembly;
-            string[] names = assem.GetManifestResourceNames();
-
-            foreach (string s in names)
-                if (s.EndsWith(name))
-                    using (Stream resource = assem.GetManifestResourceStream(s))
-                    {
-                        using (StreamReader resourceReader = new StreamReader(resource))
-                        {
-                            string resourceString = resourceReader.ReadToEnd();
-                            return resourceString;
-                        }
-                    }
-            throw new Exception(string.Format("Resource '{0}' was not found", name));
-        }
-
-        #endregion
+        }        
 
         /// <summary>
         /// Returns the version of this DB provider