diff options
| author | Diva Canto | 2012-04-27 10:39:20 -0700 |
|---|---|---|
| committer | Diva Canto | 2012-04-27 10:39:20 -0700 |
| commit | a9dbe393194b58447f20984eff03d366c03a01e4 (patch) | |
| tree | 35fa20f6840d93188e89c0ffc0c7a2fef48d4098 | |
| parent | MapImage security issue: better error messages (diff) | |
| download | opensim-SC_OLD-a9dbe393194b58447f20984eff03d366c03a01e4.zip opensim-SC_OLD-a9dbe393194b58447f20984eff03d366c03a01e4.tar.gz opensim-SC_OLD-a9dbe393194b58447f20984eff03d366c03a01e4.tar.bz2 opensim-SC_OLD-a9dbe393194b58447f20984eff03d366c03a01e4.tar.xz | |
MapImage security issue. Compare strings instead of IPAddresses.
| -rw-r--r-- | OpenSim/Server/Handlers/Map/MapAddServerConnector.cs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/OpenSim/Server/Handlers/Map/MapAddServerConnector.cs b/OpenSim/Server/Handlers/Map/MapAddServerConnector.cs index a612114..8ba188d 100644 --- a/OpenSim/Server/Handlers/Map/MapAddServerConnector.cs +++ b/OpenSim/Server/Handlers/Map/MapAddServerConnector.cs | |||
| @@ -133,7 +133,7 @@ namespace OpenSim.Server.Handlers.MapImage | |||
| 133 | if (r != null) | 133 | if (r != null) |
| 134 | { | 134 | { |
| 135 | System.Net.IPAddress ipAddr = GetCallerIP(httpRequest); | 135 | System.Net.IPAddress ipAddr = GetCallerIP(httpRequest); |
| 136 | if (r.ExternalEndPoint.Address != ipAddr) | 136 | if (r.ExternalEndPoint.Address.ToString() != ipAddr.ToString()) |
| 137 | { | 137 | { |
| 138 | m_log.WarnFormat("[MAP IMAGE HANDLER]: IP address {0} may be trying to impersonate region in IP {1}", ipAddr, r.ExternalEndPoint.Address); | 138 | m_log.WarnFormat("[MAP IMAGE HANDLER]: IP address {0} may be trying to impersonate region in IP {1}", ipAddr, r.ExternalEndPoint.Address); |
| 139 | return FailureResult("IP address of caller does not match IP address of registered region"); | 139 | return FailureResult("IP address of caller does not match IP address of registered region"); |