From 0fa5ff0ec03e5dfd6ebdd9af2268e0c33796368d Mon Sep 17 00:00:00 2001
From: onefang
Date: Wed, 9 Sep 2020 04:33:43 +1000
Subject: Various logging fix ups.

Mostly removing console spam.
Swap a bunch of info / debug logs.
Better archiver console spam.
Have some "avatar has left" mesasge hit the INFO console.
Tweak the login logging a bit, especially for impersonations.
Default to INFO on the console and DEBUG in the log files.
More time stamp resolution.
Better sim startup console notification.

Attempt to render "[LLUDPSERVER]: Malformed data, cannot parse" into
something human readable as an aid to diagnosis.  Beats hand translating
the big block of hex codes it was spewing.

Better sim startup finished messages.  Inform neighbours we are up
before the finished messages.  Always send the "[RegionReady]:
INITIALIZATION COMPLETE FOR" message.
---
 .../AuthenticationService/PasswordAuthenticationService.cs     | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

(limited to 'OpenSim/Services/AuthenticationService')

diff --git a/OpenSim/Services/AuthenticationService/PasswordAuthenticationService.cs b/OpenSim/Services/AuthenticationService/PasswordAuthenticationService.cs
index 0204699..aef3e9f 100644
--- a/OpenSim/Services/AuthenticationService/PasswordAuthenticationService.cs
+++ b/OpenSim/Services/AuthenticationService/PasswordAuthenticationService.cs
@@ -87,6 +87,7 @@ namespace OpenSim.Services.AuthenticationService
             if (!data.Data.ContainsKey("passwordHash") ||
                 !data.Data.ContainsKey("passwordSalt"))
             {
+                m_log.DebugFormat("[AUTH SERVICE]: No credentials.");
                 return String.Empty;
             }
 
@@ -109,9 +110,12 @@ namespace OpenSim.Services.AuthenticationService
             int impersonateFlag = 1 << 6;
 
             if ((user.UserFlags & impersonateFlag) == 0)
+            {
+                m_log.DebugFormat("[AUTH SERVICE]: Not trying impersonation {0} {1}.", user.UserFlags, impersonateFlag);
                 return String.Empty;
+            }
 
-            m_log.DebugFormat("[PASS AUTH]: Attempting impersonation");
+            m_log.DebugFormat("[PASS AUTH]: Attempting impersonation.");
 
             List<UserAccount> accounts = m_UserAccountService.GetUserAccountsWhere(UUID.Zero, "UserLevel >= 200");
             if (accounts == null || accounts.Count == 0)
@@ -134,7 +138,7 @@ namespace OpenSim.Services.AuthenticationService
 
                 if (data.Data["passwordHash"].ToString() == hashed)
                 {
-                    m_log.DebugFormat("[PASS AUTH]: {0} {1} impersonating {2}, proceeding with login", a.FirstName, a.LastName, principalID);
+                    m_log.InfoFormat("[PASS AUTH]: {0} {1} impersonating {2}, proceeding with login", a.FirstName, a.LastName, principalID);
                     realID = a.PrincipalID;
                     return GetToken(principalID, lifetime);
                 }
@@ -146,7 +150,7 @@ namespace OpenSim.Services.AuthenticationService
 //                }
             }
 
-            m_log.DebugFormat("[PASS AUTH]: Impersonation of {0} failed", principalID);
+            m_log.InfoFormat("[PASS AUTH]: Impersonation of {0} failed", principalID);
             return String.Empty;
         }
     }
-- 
cgit v1.1