From d4a6d9191a3ba4f19773213617843ddbb489c90c Mon Sep 17 00:00:00 2001
From: Michael Cortez
Date: Mon, 5 Oct 2009 12:09:45 -0700
Subject: Make sure that keys exist in arrays before trying to access them.

---
 .../OptionalModules/Avatar/XmlRpcGroups/GroupsModule.cs      | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

(limited to 'OpenSim/Region')

diff --git a/OpenSim/Region/OptionalModules/Avatar/XmlRpcGroups/GroupsModule.cs b/OpenSim/Region/OptionalModules/Avatar/XmlRpcGroups/GroupsModule.cs
index 2e89a24..b209199 100644
--- a/OpenSim/Region/OptionalModules/Avatar/XmlRpcGroups/GroupsModule.cs
+++ b/OpenSim/Region/OptionalModules/Avatar/XmlRpcGroups/GroupsModule.cs
@@ -148,9 +148,12 @@ namespace OpenSim.Region.OptionalModules.Avatar.XmlRpcGroups
                 UUID[] CurrentKeys = new UUID[m_clientRequestIDInfo.Count];
                 foreach (UUID key in CurrentKeys)
                 {
-                    if (DateTime.Now - m_clientRequestIDInfo[key].LastUsedTMStamp > cacheTimeout)
+                    if (m_clientRequestIDInfo.ContainsKey(key))
                     {
-                        m_clientRequestIDInfo.Remove(key);
+                        if (DateTime.Now - m_clientRequestIDInfo[key].LastUsedTMStamp > cacheTimeout)
+                        {
+                            m_clientRequestIDInfo.Remove(key);
+                        }
                     }
                 }
             }
@@ -476,7 +479,10 @@ namespace OpenSim.Region.OptionalModules.Avatar.XmlRpcGroups
                             
                             foreach (string key in binBucketOSD.Keys)
                             {
-                                m_log.WarnFormat("{0}: {1}", key, binBucketOSD[key].ToString());
+                                if (binBucketOSD.ContainsKey(key))
+                                {
+                                    m_log.WarnFormat("{0}: {1}", key, binBucketOSD[key].ToString());
+                                }
                             }
                         }
    
-- 
cgit v1.1