From 7de0912a979746c1e1301c080c49152ae7cd57b5 Mon Sep 17 00:00:00 2001
From: Talun
Date: Mon, 10 Jun 2013 09:32:14 +0100
Subject: Mantis 5346: llAxisAngle2Rot() should normalize before computing

Corrected to agree with
http://wiki.secondlife.com/wiki/Llaxisangle2rot#Deep_Notes
to normalise the vector before computing the quaternion

Signed-off-by: dahlia <dahlia@nomail>
---
 OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs | 1 +
 1 file changed, 1 insertion(+)

(limited to 'OpenSim/Region/ScriptEngine')

diff --git a/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs b/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
index cd6092d..ec5aa49 100644
--- a/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
+++ b/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
@@ -4651,6 +4651,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
 
             s = Math.Cos(angle * 0.5);
             t = Math.Sin(angle * 0.5); // temp value to avoid 2 more sin() calcs
+            axis =  LSL_Vector.Norm(axis);
             x = axis.x * t;
             y = axis.y * t;
             z = axis.z * t;
-- 
cgit v1.1


From a949556c4ea74c993fc15bcfdcbc672d9f971897 Mon Sep 17 00:00:00 2001
From: dahlia
Date: Mon, 10 Jun 2013 16:42:49 -0700
Subject: add a Normalize() method for LSL_Rotation

---
 OpenSim/Region/ScriptEngine/Shared/LSL_Types.cs | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

(limited to 'OpenSim/Region/ScriptEngine')

diff --git a/OpenSim/Region/ScriptEngine/Shared/LSL_Types.cs b/OpenSim/Region/ScriptEngine/Shared/LSL_Types.cs
index 9ca5ca9..f6d94a3 100644
--- a/OpenSim/Region/ScriptEngine/Shared/LSL_Types.cs
+++ b/OpenSim/Region/ScriptEngine/Shared/LSL_Types.cs
@@ -371,6 +371,31 @@ namespace OpenSim.Region.ScriptEngine.Shared
 
             #endregion
 
+            #region Methods
+            public Quaternion Normalize()
+            {
+                double length = Math.Sqrt(x * x + y * y + z * z + s * s);
+                if (length < float.Epsilon)
+                {
+                    x = 1;
+                    y = 0;
+                    z = 0;
+                    s = 0;
+                }
+                else
+                {
+
+                    double invLength = 1.0 / length;
+                    x *= invLength;
+                    y *= invLength;
+                    z *= invLength;
+                    s *= invLength;
+                }
+
+                return this;
+            }
+            #endregion
+
             #region Overriders
 
             public override int GetHashCode()
-- 
cgit v1.1


From 1c7fbb86c21f79938e4ea9dafef1e8d8f4a29a8d Mon Sep 17 00:00:00 2001
From: teravus
Date: Mon, 10 Jun 2013 18:47:08 -0500
Subject: Check For NaN and Infinity in llRot2Axis/Angle  Fixes mantis #6669

---
 OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

(limited to 'OpenSim/Region/ScriptEngine')

diff --git a/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs b/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
index ec5aa49..9427061 100644
--- a/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
+++ b/OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs
@@ -4692,7 +4692,9 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
                 y = rot.y / s;
                 z = rot.z / s;
             }
-
+            if ((double.IsNaN(x)) || double.IsInfinity(x)) x = 0;
+            if ((double.IsNaN(y)) || double.IsInfinity(y)) y = 0;
+            if ((double.IsNaN(z)) || double.IsInfinity(z)) z = 0;
             return new LSL_Vector(x,y,z);
         }
 
@@ -4714,7 +4716,7 @@ namespace OpenSim.Region.ScriptEngine.Shared.Api
             }
 
             double angle = 2 * Math.Acos(rot.s);
-
+            if ((double.IsNaN(angle)) || double.IsInfinity(angle)) angle = 0;
             return angle;
         }
 
-- 
cgit v1.1