From 5d09c53a1a42b38e1ee35cfbb5571d70b75380f4 Mon Sep 17 00:00:00 2001 From: Diva Canto Date: Sun, 27 Sep 2009 10:14:10 -0700 Subject: Unpacking the mess with OtherRegionUp, so we can have a real cache of the neighbours in the grid service modules. --- OpenSim/Region/ClientStack/LindenUDP/Tests/MockScene.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'OpenSim/Region/ClientStack') diff --git a/OpenSim/Region/ClientStack/LindenUDP/Tests/MockScene.cs b/OpenSim/Region/ClientStack/LindenUDP/Tests/MockScene.cs index c831f68..34c21aa 100644 --- a/OpenSim/Region/ClientStack/LindenUDP/Tests/MockScene.cs +++ b/OpenSim/Region/ClientStack/LindenUDP/Tests/MockScene.cs @@ -28,6 +28,7 @@ using OpenMetaverse; using OpenSim.Framework; using OpenSim.Region.Framework.Scenes; +using GridRegion = OpenSim.Services.Interfaces.GridRegion; namespace OpenSim.Region.ClientStack.LindenUDP.Tests { @@ -58,7 +59,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP.Tests public override void RemoveClient(UUID agentID) {} public override void CloseAllAgents(uint circuitcode) {} - public override bool OtherRegionUp(RegionInfo thisRegion) { return false; } + public override void OtherRegionUp(GridRegion otherRegion) { } /// /// Doesn't really matter what the call is - we're using this to test that a packet has actually been received -- cgit v1.1 From ee205e7e812e170f670e690a4e0fa9caa652f226 Mon Sep 17 00:00:00 2001 From: Jeff Ames Date: Thu, 1 Oct 2009 01:00:09 +0900 Subject: Formatting cleanup. --- OpenSim/Region/ClientStack/ClientStackManager.cs | 8 ++-- .../Region/ClientStack/ClientStackUserSettings.cs | 2 +- .../ClientStack/LindenUDP/ILLPacketHandler.cs | 4 +- OpenSim/Region/ClientStack/LindenUDP/J2KImage.cs | 4 +- .../Region/ClientStack/LindenUDP/LLClientView.cs | 4 +- .../Region/ClientStack/LindenUDP/LLPacketQueue.cs | 6 +-- .../Region/ClientStack/LindenUDP/LLPacketServer.cs | 6 +-- .../ClientStack/LindenUDP/LLPacketThrottle.cs | 6 +-- .../Region/ClientStack/LindenUDP/LLUDPServer.cs | 38 +++++++++--------- OpenSim/Region/ClientStack/LindenUDP/LLUtil.cs | 2 +- .../LindenUDP/Tests/BasicCircuitTests.cs | 46 +++++++++++----------- .../LindenUDP/Tests/PacketHandlerTests.cs | 12 +++--- .../LindenUDP/Tests/TestLLPacketServer.cs | 4 +- .../ClientStack/LindenUDP/Tests/TestLLUDPServer.cs | 6 +-- .../Region/ClientStack/RegionApplicationBase.cs | 6 +-- OpenSim/Region/ClientStack/ThrottleSettings.cs | 10 ++--- 16 files changed, 82 insertions(+), 82 deletions(-) (limited to 'OpenSim/Region/ClientStack') diff --git a/OpenSim/Region/ClientStack/ClientStackManager.cs b/OpenSim/Region/ClientStack/ClientStackManager.cs index 5667d64..84ea0b3 100644 --- a/OpenSim/Region/ClientStack/ClientStackManager.cs +++ b/OpenSim/Region/ClientStack/ClientStackManager.cs @@ -87,9 +87,9 @@ namespace OpenSim.Region.ClientStack public IClientNetworkServer CreateServer( IPAddress _listenIP, ref uint port, int proxyPortOffset, bool allow_alternate_port, AgentCircuitManager authenticateClass) - { + { return CreateServer( - _listenIP, ref port, proxyPortOffset, allow_alternate_port, null, authenticateClass); + _listenIP, ref port, proxyPortOffset, allow_alternate_port, null, authenticateClass); } /// @@ -104,11 +104,11 @@ namespace OpenSim.Region.ClientStack /// /// /// - /// + /// public IClientNetworkServer CreateServer( IPAddress _listenIP, ref uint port, int proxyPortOffset, bool allow_alternate_port, IConfigSource configSource, AgentCircuitManager authenticateClass) - { + { if (plugin != null) { IClientNetworkServer server = diff --git a/OpenSim/Region/ClientStack/ClientStackUserSettings.cs b/OpenSim/Region/ClientStack/ClientStackUserSettings.cs index a3c23cc..231b3aa 100644 --- a/OpenSim/Region/ClientStack/ClientStackUserSettings.cs +++ b/OpenSim/Region/ClientStack/ClientStackUserSettings.cs @@ -32,7 +32,7 @@ namespace OpenSim.Region.ClientStack /// /// At the moment this is very incomplete - other tweakable settings could be added. This is also somewhat LL client /// oriented right now. - /// + /// public class ClientStackUserSettings { /// diff --git a/OpenSim/Region/ClientStack/LindenUDP/ILLPacketHandler.cs b/OpenSim/Region/ClientStack/LindenUDP/ILLPacketHandler.cs index 665c773..32a4ad4 100644 --- a/OpenSim/Region/ClientStack/LindenUDP/ILLPacketHandler.cs +++ b/OpenSim/Region/ClientStack/LindenUDP/ILLPacketHandler.cs @@ -31,7 +31,7 @@ using OpenMetaverse.Packets; using OpenSim.Framework; namespace OpenSim.Region.ClientStack.LindenUDP -{ +{ public delegate void PacketStats(int inPackets, int outPackets, int unAckedBytes); public delegate void PacketDrop(Packet pack, Object id); public delegate bool SynchronizeClientHandler(IScene scene, Packet packet, UUID agentID, ThrottleOutPacketType throttlePacketType); @@ -61,7 +61,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP /// /// Take action depending on the type and contents of an received packet. /// - /// + /// void ProcessInPacket(LLQueItem item); void ProcessOutPacket(LLQueItem item); diff --git a/OpenSim/Region/ClientStack/LindenUDP/J2KImage.cs b/OpenSim/Region/ClientStack/LindenUDP/J2KImage.cs index 6cffd70..638c765 100644 --- a/OpenSim/Region/ClientStack/LindenUDP/J2KImage.cs +++ b/OpenSim/Region/ClientStack/LindenUDP/J2KImage.cs @@ -127,7 +127,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP } else { - m_asset = asset; + m_asset = asset; } RunUpdate(); } @@ -198,7 +198,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP try { Buffer.BlockCopy(m_asset.Data, 0, firstImageData, 0, (int)cFirstPacketSize); - client.SendImageFirstPart(TexturePacketCount(), m_requestedUUID, (uint)m_asset.Data.Length, firstImageData, 2); + client.SendImageFirstPart(TexturePacketCount(), m_requestedUUID, (uint)m_asset.Data.Length, firstImageData, 2); } catch (Exception) { diff --git a/OpenSim/Region/ClientStack/LindenUDP/LLClientView.cs b/OpenSim/Region/ClientStack/LindenUDP/LLClientView.cs index 912cbf1..88ace6a 100644 --- a/OpenSim/Region/ClientStack/LindenUDP/LLClientView.cs +++ b/OpenSim/Region/ClientStack/LindenUDP/LLClientView.cs @@ -2332,7 +2332,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP return itemBlock; } - public void SendBulkUpdateInventory(InventoryNodeBase node) + public void SendBulkUpdateInventory(InventoryNodeBase node) { if (node is InventoryItemBase) SendBulkUpdateInventoryItem((InventoryItemBase)node); @@ -2937,7 +2937,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP else if (m_avatarTerseUpdates.Count == 1) { lock (m_avatarTerseUpdateTimer) - m_avatarTerseUpdateTimer.Start(); + m_avatarTerseUpdateTimer.Start(); } } } diff --git a/OpenSim/Region/ClientStack/LindenUDP/LLPacketQueue.cs b/OpenSim/Region/ClientStack/LindenUDP/LLPacketQueue.cs index 798c1e7..c427870 100644 --- a/OpenSim/Region/ClientStack/LindenUDP/LLPacketQueue.cs +++ b/OpenSim/Region/ClientStack/LindenUDP/LLPacketQueue.cs @@ -143,7 +143,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP TextureThrottle = new LLPacketThrottle(1000, throttleMaxBPS / 2, 4000, userSettings.ClientThrottleMultipler); - // Total Throttle trumps all - it is the number of bits in total that are allowed to go out per second. + // Total Throttle trumps all - it is the number of bits in total that are allowed to go out per second. ThrottleSettings totalThrottleSettings = userSettings.TotalThrottleSettings; @@ -410,7 +410,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP { LLQueItem qpack = ResendOutgoingPacketQueue.Dequeue(); - SendQueue.Enqueue(qpack); + SendQueue.Enqueue(qpack); TotalThrottle.AddBytes(qpack.Length); ResendThrottle.AddBytes(qpack.Length); @@ -470,7 +470,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP { LLQueItem qpack = TextureOutgoingPacketQueue.Dequeue(); - SendQueue.Enqueue(qpack); + SendQueue.Enqueue(qpack); TotalThrottle.AddBytes(qpack.Length); TextureThrottle.AddBytes(qpack.Length); qchanged = true; diff --git a/OpenSim/Region/ClientStack/LindenUDP/LLPacketServer.cs b/OpenSim/Region/ClientStack/LindenUDP/LLPacketServer.cs index 56219d1..0f16fd4 100644 --- a/OpenSim/Region/ClientStack/LindenUDP/LLPacketServer.cs +++ b/OpenSim/Region/ClientStack/LindenUDP/LLPacketServer.cs @@ -48,11 +48,11 @@ namespace OpenSim.Region.ClientStack.LindenUDP /// /// Tweakable user settings /// - private ClientStackUserSettings m_userSettings; + private ClientStackUserSettings m_userSettings; public LLPacketServer(ILLClientStackNetworkHandler networkHandler, ClientStackUserSettings userSettings) { - m_userSettings = userSettings; + m_userSettings = userSettings; m_networkHandler = networkHandler; m_networkHandler.RegisterPacketServer(this); @@ -129,7 +129,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP /// /// /// true if a new circuit was created, false if a circuit with the given circuit code already existed - /// + /// public virtual bool AddNewClient( EndPoint epSender, UseCircuitCodePacket useCircuit, AuthenticateResponse sessionInfo, EndPoint proxyEP) diff --git a/OpenSim/Region/ClientStack/LindenUDP/LLPacketThrottle.cs b/OpenSim/Region/ClientStack/LindenUDP/LLPacketThrottle.cs index 01bff6d..26174e5 100644 --- a/OpenSim/Region/ClientStack/LindenUDP/LLPacketThrottle.cs +++ b/OpenSim/Region/ClientStack/LindenUDP/LLPacketThrottle.cs @@ -26,7 +26,7 @@ */ namespace OpenSim.Region.ClientStack.LindenUDP -{ +{ public class LLPacketThrottle { private readonly int m_maxAllowableThrottle; @@ -105,13 +105,13 @@ namespace OpenSim.Region.ClientStack.LindenUDP public int Throttle { - get { return m_currentThrottle; } + get { return m_currentThrottle; } set { if (value < m_minAllowableThrottle) { m_currentThrottle = m_minAllowableThrottle; - } + } else if (value > m_maxAllowableThrottle) { m_currentThrottle = m_maxAllowableThrottle; diff --git a/OpenSim/Region/ClientStack/LindenUDP/LLUDPServer.cs b/OpenSim/Region/ClientStack/LindenUDP/LLUDPServer.cs index 9ee8df5..c779b08 100644 --- a/OpenSim/Region/ClientStack/LindenUDP/LLUDPServer.cs +++ b/OpenSim/Region/ClientStack/LindenUDP/LLUDPServer.cs @@ -166,7 +166,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP userSettings.ClientThrottleMultipler = config.GetFloat("client_throttle_multiplier"); if (config.Contains("client_socket_rcvbuf_size")) m_clientSocketReceiveBuffer = config.GetInt("client_socket_rcvbuf_size"); - } + } m_log.DebugFormat("[CLIENT]: client_throttle_multiplier = {0}", userSettings.ClientThrottleMultipler); m_log.DebugFormat("[CLIENT]: client_socket_rcvbuf_size = {0}", (m_clientSocketReceiveBuffer != 0 ? @@ -228,7 +228,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP { m_log.Debug("[CLIENT]: " + e); } - } + } if (proxyPortOffset != 0) @@ -254,7 +254,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP if (packet != null) { if (packet.Type == PacketType.UseCircuitCode) - AddNewClient((UseCircuitCodePacket)packet, epSender, epProxy); + AddNewClient((UseCircuitCodePacket)packet, epSender, epProxy); else ProcessInPacket(packet, epSender); } @@ -290,7 +290,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP catch (Exception e) { m_log.Error("[CLIENT]: Exception in processing packet - ignoring: ", e); - } + } } /// @@ -299,7 +299,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP protected virtual void BeginReceive() { m_socket.BeginReceiveFrom( - RecvBuffer, 0, RecvBuffer.Length, SocketFlags.None, ref reusedEpSender, ReceivedData, null); + RecvBuffer, 0, RecvBuffer.Length, SocketFlags.None, ref reusedEpSender, ReceivedData, null); } /// @@ -322,7 +322,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP // ENDLESS LOOP ON PURPOSE! // Reset connection and get next UDP packet off the buffer // If the UDP packet is part of the same stream, this will happen several hundreds of times before - // the next set of UDP data is for a valid client. + // the next set of UDP data is for a valid client. try { @@ -347,7 +347,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP m_log.ErrorFormat("[CLIENT]: Exception thrown during BeginReceive(): {0}", ex); } } - } + } /// /// Close a client circuit. This is done in response to an exception on receive, and should not be called @@ -363,12 +363,12 @@ namespace OpenSim.Region.ClientStack.LindenUDP { m_packetServer.CloseCircuit(circuit); - if (e != null) + if (e != null) m_log.ErrorFormat( - "[CLIENT]: Closed circuit {0} {1} due to exception {2}", circuit, reusedEpSender, e); + "[CLIENT]: Closed circuit {0} {1} due to exception {2}", circuit, reusedEpSender, e); } } - } + } /// /// Finish the process of asynchronously receiving the next bit of raw data @@ -410,7 +410,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP { m_log.DebugFormat("[CLIENT]: ObjectDisposedException: Object {0} disposed.", e.ObjectName); // Uhh, what object, and why? this needs better handling. - } + } return hasReceivedOkay; } @@ -422,10 +422,10 @@ namespace OpenSim.Region.ClientStack.LindenUDP /// /// protected virtual void AddNewClient(UseCircuitCodePacket useCircuit, EndPoint epSender, EndPoint epProxy) - { + { //Slave regions don't accept new clients if (m_localScene.RegionStatus != RegionStatus.SlaveScene) - { + { AuthenticateResponse sessionInfo; bool isNewCircuit = false; @@ -441,8 +441,8 @@ namespace OpenSim.Region.ClientStack.LindenUDP lock (clientCircuits) { if (!clientCircuits.ContainsKey(epSender)) - { - clientCircuits.Add(epSender, useCircuit.CircuitCode.Code); + { + clientCircuits.Add(epSender, useCircuit.CircuitCode.Code); isNewCircuit = true; } } @@ -461,9 +461,9 @@ namespace OpenSim.Region.ClientStack.LindenUDP //m_log.DebugFormat( // "[CONNECTION SUCCESS]: Incoming client {0} (circuit code {1}) received and authenticated for {2}", - // useCircuit.CircuitCode.ID, useCircuit.CircuitCode.Code, m_localScene.RegionInfo.RegionName); - } - } + // useCircuit.CircuitCode.ID, useCircuit.CircuitCode.Code, m_localScene.RegionInfo.RegionName); + } + } // Ack the UseCircuitCode packet PacketAckPacket ack_it = (PacketAckPacket)PacketPool.Instance.GetPacket(PacketType.PacketAck); @@ -605,7 +605,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP useCircuit.CircuitCode.ID, useCircuit.CircuitCode.Code); return; - } + } lock (clientCircuits) { diff --git a/OpenSim/Region/ClientStack/LindenUDP/LLUtil.cs b/OpenSim/Region/ClientStack/LindenUDP/LLUtil.cs index f2a8bd2..c45d11f 100644 --- a/OpenSim/Region/ClientStack/LindenUDP/LLUtil.cs +++ b/OpenSim/Region/ClientStack/LindenUDP/LLUtil.cs @@ -28,7 +28,7 @@ using OpenMetaverse; namespace OpenSim.Region.ClientStack.LindenUDP -{ +{ public class LLUtil { /// diff --git a/OpenSim/Region/ClientStack/LindenUDP/Tests/BasicCircuitTests.cs b/OpenSim/Region/ClientStack/LindenUDP/Tests/BasicCircuitTests.cs index 9fb1041..32c0397 100644 --- a/OpenSim/Region/ClientStack/LindenUDP/Tests/BasicCircuitTests.cs +++ b/OpenSim/Region/ClientStack/LindenUDP/Tests/BasicCircuitTests.cs @@ -54,7 +54,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP.Tests catch { // I don't care, just leave log4net off - } + } } /// @@ -63,20 +63,20 @@ namespace OpenSim.Region.ClientStack.LindenUDP.Tests /// /// /// - /// Agent circuit manager used in setting up the stack + /// Agent circuit manager used in setting up the stack protected void SetupStack( IScene scene, out TestLLUDPServer testLLUDPServer, out TestLLPacketServer testPacketServer, out AgentCircuitManager acm) { IConfigSource configSource = new IniConfigSource(); ClientStackUserSettings userSettings = new ClientStackUserSettings(); - testLLUDPServer = new TestLLUDPServer(); + testLLUDPServer = new TestLLUDPServer(); acm = new AgentCircuitManager(); - uint port = 666; + uint port = 666; testLLUDPServer.Initialise(null, ref port, 0, false, configSource, acm); testPacketServer = new TestLLPacketServer(testLLUDPServer, userSettings); - testLLUDPServer.LocalScene = scene; + testLLUDPServer.LocalScene = scene; } /// @@ -124,7 +124,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP.Tests acm.AddNewCircuit(circuitCode, acd); - testLLUDPServer.LoadReceive(uccp, epSender); + testLLUDPServer.LoadReceive(uccp, epSender); testLLUDPServer.ReceiveData(null); } @@ -142,15 +142,15 @@ namespace OpenSim.Region.ClientStack.LindenUDP.Tests onp.ObjectData = new ObjectNamePacket.ObjectDataBlock[] { odb }; onp.Header.Zerocoded = false; - return onp; + return onp; } /// /// Test adding a client to the stack /// - [Test, LongRunning] + [Test, LongRunning] public void TestAddClient() - { + { TestHelper.InMethod(); uint myCircuitCode = 123456; @@ -177,7 +177,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP.Tests EndPoint testEp = new IPEndPoint(IPAddress.Loopback, 999); - testLLUDPServer.LoadReceive(uccp, testEp); + testLLUDPServer.LoadReceive(uccp, testEp); testLLUDPServer.ReceiveData(null); // Circuit shouildn't exist since the circuit manager doesn't know about this circuit for authentication yet @@ -185,8 +185,8 @@ namespace OpenSim.Region.ClientStack.LindenUDP.Tests acm.AddNewCircuit(myCircuitCode, acd); - testLLUDPServer.LoadReceive(uccp, testEp); - testLLUDPServer.ReceiveData(null); + testLLUDPServer.LoadReceive(uccp, testEp); + testLLUDPServer.ReceiveData(null); // Should succeed now Assert.IsTrue(testLLUDPServer.HasCircuit(myCircuitCode)); @@ -196,24 +196,24 @@ namespace OpenSim.Region.ClientStack.LindenUDP.Tests /// /// Test removing a client from the stack /// - [Test] + [Test] public void TestRemoveClient() { TestHelper.InMethod(); - uint myCircuitCode = 123457; + uint myCircuitCode = 123457; TestLLUDPServer testLLUDPServer; TestLLPacketServer testLLPacketServer; AgentCircuitManager acm; - SetupStack(new MockScene(), out testLLUDPServer, out testLLPacketServer, out acm); + SetupStack(new MockScene(), out testLLUDPServer, out testLLPacketServer, out acm); AddClient(myCircuitCode, new IPEndPoint(IPAddress.Loopback, 1000), testLLUDPServer, acm); - testLLUDPServer.RemoveClientCircuit(myCircuitCode); + testLLUDPServer.RemoveClientCircuit(myCircuitCode); Assert.IsFalse(testLLUDPServer.HasCircuit(myCircuitCode)); // Check that removing a non-existant circuit doesn't have any bad effects - testLLUDPServer.RemoveClientCircuit(101); + testLLUDPServer.RemoveClientCircuit(101); Assert.IsFalse(testLLUDPServer.HasCircuit(101)); } @@ -232,7 +232,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP.Tests TestLLUDPServer testLLUDPServer; TestLLPacketServer testLLPacketServer; AgentCircuitManager acm; - SetupStack(scene, out testLLUDPServer, out testLLPacketServer, out acm); + SetupStack(scene, out testLLUDPServer, out testLLPacketServer, out acm); AddClient(myCircuitCode, testEp, testLLUDPServer, acm); byte[] data = new byte[] { 0x01, 0x02, 0x03, 0x04 }; @@ -270,17 +270,17 @@ namespace OpenSim.Region.ClientStack.LindenUDP.Tests uint circuitCodeA = 130000; EndPoint epA = new IPEndPoint(IPAddress.Loopback, 1300); UUID agentIdA = UUID.Parse("00000000-0000-0000-0000-000000001300"); - UUID sessionIdA = UUID.Parse("00000000-0000-0000-0000-000000002300"); + UUID sessionIdA = UUID.Parse("00000000-0000-0000-0000-000000002300"); uint circuitCodeB = 130001; EndPoint epB = new IPEndPoint(IPAddress.Loopback, 1301); UUID agentIdB = UUID.Parse("00000000-0000-0000-0000-000000001301"); - UUID sessionIdB = UUID.Parse("00000000-0000-0000-0000-000000002301"); + UUID sessionIdB = UUID.Parse("00000000-0000-0000-0000-000000002301"); TestLLUDPServer testLLUDPServer; TestLLPacketServer testLLPacketServer; AgentCircuitManager acm; - SetupStack(scene, out testLLUDPServer, out testLLPacketServer, out acm); + SetupStack(scene, out testLLUDPServer, out testLLPacketServer, out acm); AddClient(circuitCodeA, epA, agentIdA, sessionIdA, testLLUDPServer, acm); AddClient(circuitCodeB, epB, agentIdB, sessionIdB, testLLUDPServer, acm); @@ -293,7 +293,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP.Tests Assert.IsFalse(testLLUDPServer.HasCircuit(circuitCodeA)); Assert.That(testLLPacketServer.GetTotalPacketsReceived(), Is.EqualTo(3)); - Assert.That(testLLPacketServer.GetPacketsReceivedFor(PacketType.ObjectName), Is.EqualTo(3)); - } + Assert.That(testLLPacketServer.GetPacketsReceivedFor(PacketType.ObjectName), Is.EqualTo(3)); + } } } diff --git a/OpenSim/Region/ClientStack/LindenUDP/Tests/PacketHandlerTests.cs b/OpenSim/Region/ClientStack/LindenUDP/Tests/PacketHandlerTests.cs index 8b11ccc..cde155b 100644 --- a/OpenSim/Region/ClientStack/LindenUDP/Tests/PacketHandlerTests.cs +++ b/OpenSim/Region/ClientStack/LindenUDP/Tests/PacketHandlerTests.cs @@ -45,7 +45,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP.Tests [Test] /// /// More a placeholder, really - /// + /// public void InPacketTest() { TestHelper.InMethod(); @@ -87,20 +87,20 @@ namespace OpenSim.Region.ClientStack.LindenUDP.Tests /// /// /// - /// Agent circuit manager used in setting up the stack + /// Agent circuit manager used in setting up the stack protected void SetupStack( IScene scene, out TestLLUDPServer testLLUDPServer, out TestLLPacketServer testPacketServer, out AgentCircuitManager acm) { IConfigSource configSource = new IniConfigSource(); ClientStackUserSettings userSettings = new ClientStackUserSettings(); - testLLUDPServer = new TestLLUDPServer(); + testLLUDPServer = new TestLLUDPServer(); acm = new AgentCircuitManager(); - uint port = 666; + uint port = 666; testLLUDPServer.Initialise(null, ref port, 0, false, configSource, acm); testPacketServer = new TestLLPacketServer(testLLUDPServer, userSettings); - testLLUDPServer.LocalScene = scene; - } + testLLUDPServer.LocalScene = scene; + } } } diff --git a/OpenSim/Region/ClientStack/LindenUDP/Tests/TestLLPacketServer.cs b/OpenSim/Region/ClientStack/LindenUDP/Tests/TestLLPacketServer.cs index d055969..1fba847 100644 --- a/OpenSim/Region/ClientStack/LindenUDP/Tests/TestLLPacketServer.cs +++ b/OpenSim/Region/ClientStack/LindenUDP/Tests/TestLLPacketServer.cs @@ -31,7 +31,7 @@ using OpenMetaverse.Packets; namespace OpenSim.Region.ClientStack.LindenUDP.Tests { public class TestLLPacketServer : LLPacketServer - { + { /// /// Record counts of packets received /// @@ -49,7 +49,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP.Tests m_packetsReceived[packet.Type]++; else m_packetsReceived[packet.Type] = 1; - } + } public int GetTotalPacketsReceived() { diff --git a/OpenSim/Region/ClientStack/LindenUDP/Tests/TestLLUDPServer.cs b/OpenSim/Region/ClientStack/LindenUDP/Tests/TestLLUDPServer.cs index 1dffefb..f98586d 100644 --- a/OpenSim/Region/ClientStack/LindenUDP/Tests/TestLLUDPServer.cs +++ b/OpenSim/Region/ClientStack/LindenUDP/Tests/TestLLUDPServer.cs @@ -66,7 +66,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP.Tests ChunkSenderTuple tuple = m_chunksToLoad.Dequeue(); RecvBuffer = tuple.Data; numBytes = tuple.Data.Length; - epSender = tuple.Sender; + epSender = tuple.Sender; return true; } @@ -114,7 +114,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP.Tests { while (m_chunksToLoad.Count > 0) OnReceivedData(result); - } + } /// /// Has a circuit with the given code been established? @@ -134,7 +134,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP.Tests /// Record the data and sender tuple /// public class ChunkSenderTuple - { + { public byte[] Data; public EndPoint Sender; public bool BeginReceiveException; diff --git a/OpenSim/Region/ClientStack/RegionApplicationBase.cs b/OpenSim/Region/ClientStack/RegionApplicationBase.cs index a266a40..bfce7b1 100644 --- a/OpenSim/Region/ClientStack/RegionApplicationBase.cs +++ b/OpenSim/Region/ClientStack/RegionApplicationBase.cs @@ -61,7 +61,7 @@ namespace OpenSim.Region.ClientStack get { return m_commsManager; } set { m_commsManager = value; } } - protected CommunicationsManager m_commsManager; + protected CommunicationsManager m_commsManager; protected StorageManager m_storageManager; @@ -82,13 +82,13 @@ namespace OpenSim.Region.ClientStack /// /// The name of the OpenSim scene this physics scene is serving. This will be used in log messages. /// - /// + /// protected abstract PhysicsScene GetPhysicsScene(string osSceneIdentifier); protected abstract StorageManager CreateStorageManager(); protected abstract ClientStackManager CreateClientStackManager(); protected abstract Scene CreateScene(RegionInfo regionInfo, StorageManager storageManager, - AgentCircuitManager circuitManager); + AgentCircuitManager circuitManager); protected override void StartupSpecific() { diff --git a/OpenSim/Region/ClientStack/ThrottleSettings.cs b/OpenSim/Region/ClientStack/ThrottleSettings.cs index 5dcb706..551dbdf 100644 --- a/OpenSim/Region/ClientStack/ThrottleSettings.cs +++ b/OpenSim/Region/ClientStack/ThrottleSettings.cs @@ -26,12 +26,12 @@ */ namespace OpenSim.Region.ClientStack -{ +{ /// /// Represent throttle settings for a client stack. These settings are in bytes per second /// public class ThrottleSettings - { + { /// /// Minimum bytes per second that the throttle can be set to. /// @@ -39,13 +39,13 @@ namespace OpenSim.Region.ClientStack /// /// Maximum bytes per second that the throttle can be set to. - /// + /// public int Max; /// /// Current bytes per second that the throttle should be set to. - /// - public int Current; + /// + public int Current; public ThrottleSettings(int min, int max, int current) { -- cgit v1.1 From 606e831ff5337fb5e94dcebf9d6852bd4c434d4b Mon Sep 17 00:00:00 2001 From: Jeff Ames Date: Thu, 1 Oct 2009 09:38:36 +0900 Subject: Formatting cleanup. --- OpenSim/Region/ClientStack/LindenUDP/LLPacketServer.cs | 2 +- OpenSim/Region/ClientStack/LindenUDP/LLPacketThrottle.cs | 2 +- OpenSim/Region/ClientStack/LindenUDP/Tests/BasicCircuitTests.cs | 6 +++--- OpenSim/Region/ClientStack/RegionApplicationBase.cs | 4 ++-- OpenSim/Region/ClientStack/ThrottleSettings.cs | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) (limited to 'OpenSim/Region/ClientStack') diff --git a/OpenSim/Region/ClientStack/LindenUDP/LLPacketServer.cs b/OpenSim/Region/ClientStack/LindenUDP/LLPacketServer.cs index 0f16fd4..70d94e7 100644 --- a/OpenSim/Region/ClientStack/LindenUDP/LLPacketServer.cs +++ b/OpenSim/Region/ClientStack/LindenUDP/LLPacketServer.cs @@ -114,7 +114,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP sessionInfo = circuitManager.AuthenticateSession(sessionId, agentId, circuitCode); if (!sessionInfo.Authorised) - return false; + return false; return true; } diff --git a/OpenSim/Region/ClientStack/LindenUDP/LLPacketThrottle.cs b/OpenSim/Region/ClientStack/LindenUDP/LLPacketThrottle.cs index 26174e5..52effc5 100644 --- a/OpenSim/Region/ClientStack/LindenUDP/LLPacketThrottle.cs +++ b/OpenSim/Region/ClientStack/LindenUDP/LLPacketThrottle.cs @@ -49,7 +49,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP public int Min { get { return m_minAllowableThrottle; } - } + } public int Current { diff --git a/OpenSim/Region/ClientStack/LindenUDP/Tests/BasicCircuitTests.cs b/OpenSim/Region/ClientStack/LindenUDP/Tests/BasicCircuitTests.cs index 32c0397..daab84f 100644 --- a/OpenSim/Region/ClientStack/LindenUDP/Tests/BasicCircuitTests.cs +++ b/OpenSim/Region/ClientStack/LindenUDP/Tests/BasicCircuitTests.cs @@ -233,7 +233,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP.Tests TestLLPacketServer testLLPacketServer; AgentCircuitManager acm; SetupStack(scene, out testLLUDPServer, out testLLPacketServer, out acm); - AddClient(myCircuitCode, testEp, testLLUDPServer, acm); + AddClient(myCircuitCode, testEp, testLLUDPServer, acm); byte[] data = new byte[] { 0x01, 0x02, 0x03, 0x04 }; @@ -252,7 +252,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP.Tests testLLUDPServer.LoadReceive(BuildTestObjectNamePacket(1, "helloooo"), testEp); testLLUDPServer.ReceiveData(null); - Assert.That(testLLPacketServer.GetTotalPacketsReceived(), Is.EqualTo(1)); + Assert.That(testLLPacketServer.GetTotalPacketsReceived(), Is.EqualTo(1)); Assert.That(testLLPacketServer.GetPacketsReceivedFor(PacketType.ObjectName), Is.EqualTo(1)); } @@ -292,7 +292,7 @@ namespace OpenSim.Region.ClientStack.LindenUDP.Tests Assert.IsFalse(testLLUDPServer.HasCircuit(circuitCodeA)); - Assert.That(testLLPacketServer.GetTotalPacketsReceived(), Is.EqualTo(3)); + Assert.That(testLLPacketServer.GetTotalPacketsReceived(), Is.EqualTo(3)); Assert.That(testLLPacketServer.GetPacketsReceivedFor(PacketType.ObjectName), Is.EqualTo(3)); } } diff --git a/OpenSim/Region/ClientStack/RegionApplicationBase.cs b/OpenSim/Region/ClientStack/RegionApplicationBase.cs index bfce7b1..c7aeca14 100644 --- a/OpenSim/Region/ClientStack/RegionApplicationBase.cs +++ b/OpenSim/Region/ClientStack/RegionApplicationBase.cs @@ -80,7 +80,7 @@ namespace OpenSim.Region.ClientStack /// /// /// - /// The name of the OpenSim scene this physics scene is serving. This will be used in log messages. + /// The name of the OpenSim scene this physics scene is serving. This will be used in log messages. /// /// protected abstract PhysicsScene GetPhysicsScene(string osSceneIdentifier); @@ -121,7 +121,7 @@ namespace OpenSim.Region.ClientStack /// The name of the mesh engine to use /// The configuration data to pass to the physics and mesh engines /// - /// The name of the OpenSim scene this physics scene is serving. This will be used in log messages. + /// The name of the OpenSim scene this physics scene is serving. This will be used in log messages. /// /// protected PhysicsScene GetPhysicsScene( diff --git a/OpenSim/Region/ClientStack/ThrottleSettings.cs b/OpenSim/Region/ClientStack/ThrottleSettings.cs index 551dbdf..fe4718c 100644 --- a/OpenSim/Region/ClientStack/ThrottleSettings.cs +++ b/OpenSim/Region/ClientStack/ThrottleSettings.cs @@ -40,7 +40,7 @@ namespace OpenSim.Region.ClientStack /// /// Maximum bytes per second that the throttle can be set to. /// - public int Max; + public int Max; /// /// Current bytes per second that the throttle should be set to. -- cgit v1.1