aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/OpenSim/Region/Framework (follow)
Commit message (Collapse)AuthorAgeFilesLines
...
* Lock m_pendingObjects when calling GetPendingObjectsCount().Justin Clark-Casey (justincc)2011-09-061-1/+2
| | | | | | This is only called by a region console command. We should also be locking m_partsUpdateQueue when dequeueing the next part, or locking m_pendingObjects in QueuePartForUpdate(). However, I won't do this now since I don't have time to analyze how this would affect liveness.
* Comment out SceneViewer.Reset() and stop calling from Close() since this is ↵Justin Clark-Casey (justincc)2011-09-061-16/+17
| | | | | | useless work as a closed scene object is never reset. Strictly speaking, we could also stop bothering to clear the m_updateTimes and m_partsUpdateQueue if we are sure that the whole SceneViewer is shortly to be garbage collected anyway, but we'll leave them around for now.
* Comment out unused ISceneViewer.Reset() to reduce code complexityJustin Clark-Casey (justincc)2011-09-061-1/+1
|
* In SceneViewer, introduce an IsEnabled flag and perform Close() under an ↵Justin Clark-Casey (justincc)2011-09-062-19/+51
| | | | m_pendingObjects lock in order to avoid the race condition seen by danbanner in http://opensimulator.org/mantis/view.php?id=5669
* Get rid of the confusing version of ↵Justin Clark-Casey (justincc)2011-09-061-14/+0
| | | | IAttachmentsModule.RezSingleAttachmentFromInventory() with the updateInventoryStatus switch, since this is never called with false
* Try disabling the inconsistent attachment state check to see if this ↵Justin Clark-Casey (justincc)2011-09-051-9/+7
| | | | | | | | actually has an impact. The code in question is over three years old and just be catching an inconsistency rather than being wholly necessary. This commit still carries out the check and prints all the previous log warnings but a 'failure' no longer prevents avatar region crossing or teleport, and it doesn't give the client the error message. This will have some kind of impact on http://opensimulator.org/mantis/view.php?id=5672
* Stop NPCs losing attachments when the source avatar takes them off.Justin Clark-Casey (justincc)2011-09-033-7/+57
| | | | | | | This was happening because we were using the source avatar's item IDs in the clone appearance. Switch to using the asset IDs of attachments instead for NPCs. The InventoryAccessModule and AttachmentModule had to be changed to allow rezzing of an object without an associated inventory item. Hopefully goes some way towards resolving http://opensimulator.org/mantis/view.php?id=5653
* Comment out Scene.CleanDroppedAttachments() and calls.Justin Clark-Casey (justincc)2011-09-021-36/+36
| | | | | This method wasn't actually doing anything since dropped attachments retain a PCode of 9. Also, behaviour of dropped attachments in other places appears to be that they persist after avatar logout rather than get deleted.
* Go back to resetting the State parameter for all parts of a SOG when ↵Justin Clark-Casey (justincc)2011-09-021-0/+6
| | | | | | | SOG.ClearPartAttachmentData() is called. Even though we don't use these on rez they are still present after an unlink, after which selecting them causes various viewers to crash Hopefully really does address http://opensimulator.org/mantis/view.php?id=5664
* stop passing FromUserInventoryItemID right down into the deserializer.Justin Clark-Casey (justincc)2011-09-022-26/+5
| | | | the code becomes simpler if this is set from the outside - only one place needs to do this.
* Move more of IAM.RezObject() into DoPreRezWhenFromItem()Justin Clark-Casey (justincc)2011-09-021-3/+2
|
* refactor: use SOG register target waypoints and rots directly instead of ↵Justin Clark-Casey (justincc)2011-09-011-20/+0
| | | | calling through the SOP, which doesn't make conceptual sense anyway.
* Eliminate pointless checks of SOG.RootPart != nullJustin Clark-Casey (justincc)2011-09-014-139/+75
| | | | It's never possible for SOG to have no RootPart, except in the first few picosends of the big bang when it's pulled from region persistence or deserialized
* refactor: use ParentGroup.UUID directly instead of SOP.GetRootPartUUID()Justin Clark-Casey (justincc)2011-09-011-17/+6
|
* Fix issue with llGetTorque() where it would only ever return a zero vector.Justin Clark-Casey (justincc)2011-09-011-9/+0
|
* Remove pointless cluttering SOP.ParentGroup != null checks.Justin Clark-Casey (justincc)2011-09-017-272/+185
| | | | | The only times when ParentGroup might be null is during regression tests (which might not be a valid thing) and when scene objects are being constructed from the database. At all other times it's not possible for a SOP not to have a SOG parent.
* move common code into AttachmentsModule.DeleteAttachmentsFromScene()Justin Clark-Casey (justincc)2011-08-313-15/+25
|
* refactor: move multiple class to set avatar height into associated ↵Justin Clark-Casey (justincc)2011-08-311-16/+2
| | | | SP.AddToPhysicalScene()
* get rid of appearance null checks - this is never nullJustin Clark-Casey (justincc)2011-08-312-35/+16
|
* remove pointless m_attachments == null check since this field is never nullJustin Clark-Casey (justincc)2011-08-311-1/+1
|
* minor: seal up another instance of using the appearance list without lockingJustin Clark-Casey (justincc)2011-08-311-1/+2
|
* Make SP.Attachments available as sp.GetAttachments() instead.Justin Clark-Casey (justincc)2011-08-312-15/+43
| | | | | | | The approach here, as in other parts of OpenSim, is to return a copy of the list rather than the attachments list itself This prevents callers from forgetting to lock the list when they read it, as was happening in various parts of the codebase. It also improves liveness. This might improve attachment anomolies when performing region crossings.
* minor: remove already processed avatar null check in Scene.RemoveClient()Justin Clark-Casey (justincc)2011-08-302-5/+1
| | | | remove some now duplicated method doc
* refactor: move SP.SaveChangedAttachments() fully into AttachmentsModuleJustin Clark-Casey (justincc)2011-08-304-26/+20
|
* refactor: Move ScenePresence.RezAttachments() into AttachmentsModuleJustin Clark-Casey (justincc)2011-08-304-46/+64
| | | | This adds an incomplete IScenePresence to match ISceneEntity
* add Name property to ISceneEntityJustin Clark-Casey (justincc)2011-08-301-2/+5
|
* refactor: migrate DropObject handling fully into AttachmentsModule from SceneJustin Clark-Casey (justincc)2011-08-303-13/+4
|
* Merge branch 'master' into bulletsimMic Bowman2011-08-302-3/+20
|\
| * Fix bug in persisting saved appearances for npcsJustin Clark-Casey (justincc)2011-08-302-3/+20
| | | | | | | | | | Assets have to be marked non-local as well as non-temporary to persist. This is now done. Hopefully addresses http://opensimulator.org/mantis/view.php?id=5660
* | Merge branch 'master' into bulletsimMic Bowman2011-08-299-93/+95
|\ \ | |/
| * Related to #4689 - Adding missing null check for SceneObjectPartMakopoppo2011-08-272-4/+18
| | | | | | | | Signed-off-by: BlueWall <jamesh@bluewallgroup.com>
| * Stop avatars returning from neighbouring regions from stalling on the border ↵Justin Clark-Casey (justincc)2011-08-271-3/+22
| | | | | | | | | | | | | | | | | | crossing. On making a root agent, we need to reset the ScenePresence.m_movement_flag so that it doesn't remember the movement registered to the client when it exited the initial region. If this is remember, then the client avatar movement isn't updated and it appears to stall in mid-air, though this is resolved with a prod/release of any other direction key. This bug was probably introduced a few weeks ago. Surprised that nobody brought it up.
| * Eliminate duplicate AttachmentPoint properties by always using the one ↵Justin Clark-Casey (justincc)2011-08-271-18/+18
| | | | | | | | stored in the root part's state field.
| * refactor: move SOP.IsAttachment and AttachmentPoint up into SOG to avoid ↵Justin Clark-Casey (justincc)2011-08-277-73/+42
| | | | | | | | pointless duplication of identical values
* | Merge branch 'master' into bulletsimMic Bowman2011-08-2610-225/+180
|\ \ | |/
| * refactor: simplify SOP.AttachedAvatar into SOG.AttachedAvatarJustin Clark-Casey (justincc)2011-08-263-10/+14
| | | | | | | | This does a tiny bit to reduce code complexity, memory requirement and the cpu time of pointlessly setting this field to the same value in every SOP
| * refactor: move SOG.DetachToGround() to ↵Justin Clark-Casey (justincc)2011-08-261-40/+6
| | | | | | | | AttachmentsModule.DetachSceneObjectToGround() and remove redundant code
| * refactor: simplify DetachSingleAttachmentToGround() by retrieving the scene ↵Justin Clark-Casey (justincc)2011-08-261-2/+2
| | | | | | | | object group direct
| * refactor: move sog.DetachToInventoryPrep() into ↵Justin Clark-Casey (justincc)2011-08-261-28/+4
| | | | | | | | AttachmentsModule.DetachSingleAttachmentToInv()
| * remove pointless IsDeleted check on SP.RezAttachments()Justin Clark-Casey (justincc)2011-08-241-3/+0
| | | | | | | | | | IsDeleted is never set for an SP, even though it's on EntityBase. It might be an idea to set it in the future
| * refactor: simplify EntityBase.IsDeleted propertyJustin Clark-Casey (justincc)2011-08-243-10/+5
| |
| * add SOG helper properties IsPhantom, IsTemporary, etc. to improve code ↵Justin Clark-Casey (justincc)2011-08-241-20/+46
| | | | | | | | | | | | readability use these in some sog methods
| * refactor: move Scene.Inventory.attachObjectAssetStore() into ↵Justin Clark-Casey (justincc)2011-08-241-84/+0
| | | | | | | | AttachmentsModule.AddSceneObjectAsAttachment()
| * get rid of pointless grp null check in attachObjectAssetStore()Justin Clark-Casey (justincc)2011-08-241-73/+69
| |
| * minor: remove hardcoded region numbers with the region size constant and a ↵Justin Clark-Casey (justincc)2011-08-241-2/+2
| | | | | | | | currently hardcoded offset
| * refactor: remove pointless AgentId argument from attachObjectAssetStore()Justin Clark-Casey (justincc)2011-08-241-1/+1
| |
| * Fix llAttachToAvatar()Justin Clark-Casey (justincc)2011-08-242-12/+33
| | | | | | | | | | | | Apart from one obvious bug, this was failing because attempting to serialize the script from inside the script (as part of saving the attachment as an inventory asset) was triggering an extremely long delay. So we now don't do this. The state will be serialized anyway when the avatar normally logs out. The worst that can happen is that if the client/server crashes, the attachment scripts start without previous state.
| * rename AttachmentsModule.ShowDetachInUserInventory() to ↵Justin Clark-Casey (justincc)2011-08-231-15/+7
| | | | | | | | DetachSingleAttachmentToInv() for consistency and to reflect it's actual behaviour
| * Remove pointless contains check in ScenePresence.RemoveAttachment()Justin Clark-Casey (justincc)2011-08-231-6/+1
| |
| * If an attachment fails, then start logging the exception for now, in order ↵Justin Clark-Casey (justincc)2011-08-222-6/+4
| | | | | | | | | | | | to help with the inconsistent state bug. This also refactors AttachmentsModules to stop pointlessly refetching the ScenePresence in various methods. However, more of this is required.
generated by cgit v1.1 at 2024-12-20 19:29:45 +0000