Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Remove code which was automatically deleting non-root prims from scene ↵ | Justin Clark-Casey (justincc) | 2011-09-01 | 1 | -0/+4 |
| | | | | | | | objects that had previous been attachments. Looks like this code was accidentally uncommented in e1b5c612 from feb 2010. Appears to resolve the rest of http://opensimulator.org/mantis/view.php?id=5664 | ||||
* | If the user receiving an inventory folder has left the scene by the time the ↵ | Justin Clark-Casey (justincc) | 2011-09-01 | 1 | -5/+4 |
| | | | | | | acceptence message arrives, then don't send them an inventory update. Doing so causes a NullReferenceException | ||||
* | Eliminate pointless checks of SOG.RootPart != null | Justin Clark-Casey (justincc) | 2011-09-01 | 2 | -7/+1 |
| | | | | It's never possible for SOG to have no RootPart, except in the first few picosends of the big bang when it's pulled from region persistence or deserialized | ||||
* | Remove pointless cluttering SOP.ParentGroup != null checks. | Justin Clark-Casey (justincc) | 2011-09-01 | 3 | -33/+24 |
| | | | | | The only times when ParentGroup might be null is during regression tests (which might not be a valid thing) and when scene objects are being constructed from the database. At all other times it's not possible for a SOP not to have a SOG parent. | ||||
* | Don't set a GridUser entry for NPCs. | Justin Clark-Casey (justincc) | 2011-08-31 | 1 | -1/+4 |
| | | | | Resolves http://opensimulator.org/mantis/view.php?id=5665 | ||||
* | move common code into AttachmentsModule.DeleteAttachmentsFromScene() | Justin Clark-Casey (justincc) | 2011-08-31 | 2 | -5/+11 |
| | |||||
* | refactor: move multiple class to set avatar height into associated ↵ | Justin Clark-Casey (justincc) | 2011-08-31 | 1 | -1/+1 |
| | | | | SP.AddToPhysicalScene() | ||||
* | In WorldCommModule, replace the useless Attachments == null check with ↵ | Justin Clark-Casey (justincc) | 2011-08-31 | 1 | -2/+1 |
| | | | | Attachments.Count == 0 instead | ||||
* | minor: seal up another instance of using the appearance list without locking | Justin Clark-Casey (justincc) | 2011-08-31 | 1 | -1/+1 |
| | |||||
* | Make SP.Attachments available as sp.GetAttachments() instead. | Justin Clark-Casey (justincc) | 2011-08-31 | 4 | -50/+52 |
| | | | | | | | The approach here, as in other parts of OpenSim, is to return a copy of the list rather than the attachments list itself This prevents callers from forgetting to lock the list when they read it, as was happening in various parts of the codebase. It also improves liveness. This might improve attachment anomolies when performing region crossings. | ||||
* | remove pointless ToArray() call in AttachmentsModule.SaveChangedAttachments() | Justin Clark-Casey (justincc) | 2011-08-30 | 1 | -1/+1 |
| | |||||
* | minor: remove already processed avatar null check in Scene.RemoveClient() | Justin Clark-Casey (justincc) | 2011-08-30 | 1 | -1/+0 |
| | | | | remove some now duplicated method doc | ||||
* | refactor: move SP.SaveChangedAttachments() fully into AttachmentsModule | Justin Clark-Casey (justincc) | 2011-08-30 | 1 | -0/+18 |
| | |||||
* | refactor: Move ScenePresence.RezAttachments() into AttachmentsModule | Justin Clark-Casey (justincc) | 2011-08-30 | 1 | -0/+38 |
| | | | | This adds an incomplete IScenePresence to match ISceneEntity | ||||
* | refactor: migrate DropObject handling fully into AttachmentsModule from Scene | Justin Clark-Casey (justincc) | 2011-08-30 | 2 | -16/+12 |
| | |||||
* | Fix bug where attachments were remaining on the avatar after being dropped. | Justin Clark-Casey (justincc) | 2011-08-30 | 2 | -6/+20 |
| | | | | If the inventory service is configured not to allow deletion then these will not disappear from inventory | ||||
* | Fix bug in persisting saved appearances for npcs | Justin Clark-Casey (justincc) | 2011-08-30 | 3 | -13/+111 |
| | | | | | Assets have to be marked non-local as well as non-temporary to persist. This is now done. Hopefully addresses http://opensimulator.org/mantis/view.php?id=5660 | ||||
* | Eliminate duplicate AttachmentPoint properties by always using the one ↵ | Justin Clark-Casey (justincc) | 2011-08-27 | 3 | -26/+23 |
| | | | | stored in the root part's state field. | ||||
* | refactor: camel case AttachmentPoint method arg as per code standards | Justin Clark-Casey (justincc) | 2011-08-27 | 1 | -4/+4 |
| | |||||
* | refactor: move SOP.IsAttachment and AttachmentPoint up into SOG to avoid ↵ | Justin Clark-Casey (justincc) | 2011-08-27 | 4 | -18/+17 |
| | | | | pointless duplication of identical values | ||||
* | refactor: simplify SOP.AttachedAvatar into SOG.AttachedAvatar | Justin Clark-Casey (justincc) | 2011-08-26 | 1 | -10/+5 |
| | | | | This does a tiny bit to reduce code complexity, memory requirement and the cpu time of pointlessly setting this field to the same value in every SOP | ||||
* | refactor: move SOG.DetachToGround() to ↵ | Justin Clark-Casey (justincc) | 2011-08-26 | 1 | -1/+29 |
| | | | | AttachmentsModule.DetachSceneObjectToGround() and remove redundant code | ||||
* | refactor: simplify DetachSingleAttachmentToGround() by retrieving the scene ↵ | Justin Clark-Casey (justincc) | 2011-08-26 | 1 | -9/+10 |
| | | | | object group direct | ||||
* | refactor: remove common presence set up in attachments tests | Justin Clark-Casey (justincc) | 2011-08-26 | 1 | -32/+38 |
| | |||||
* | comment out verbose test logging from last commit | Justin Clark-Casey (justincc) | 2011-08-26 | 1 | -1/+1 |
| | |||||
* | add regression test for detaching an attachment to the scene | Justin Clark-Casey (justincc) | 2011-08-26 | 1 | -0/+33 |
| | |||||
* | refactor: move sog.DetachToInventoryPrep() into ↵ | Justin Clark-Casey (justincc) | 2011-08-26 | 2 | -8/+19 |
| | | | | AttachmentsModule.DetachSingleAttachmentToInv() | ||||
* | Downgrade warning about not saving unchanged attachment to debug instead, ↵ | Justin Clark-Casey (justincc) | 2011-08-26 | 1 | -1/+4 |
| | | | | and change text to better indicate what it's saying | ||||
* | Fix a very recent regression from llAttachToAvatar() fix where I ↵ | Justin Clark-Casey (justincc) | 2011-08-26 | 1 | -5/+1 |
| | | | | accidentally stopped normal script state persistence on login/logout and attach/detach | ||||
* | Remove forcing of phantom on ground attached objects - attachments can be ↵ | Justin Clark-Casey (justincc) | 2011-08-24 | 2 | -5/+0 |
| | | | | | | both non-phantom and flagged as physical. As per Melanie | ||||
* | extend initial rez regression test to check that attachment is phantom | Justin Clark-Casey (justincc) | 2011-08-24 | 1 | -9/+14 |
| | |||||
* | Make objects attached from the ground phantom | Justin Clark-Casey (justincc) | 2011-08-24 | 2 | -2/+12 |
| | |||||
* | return InventoryItemBase from AddSceneObjectAsAttachment() | Justin Clark-Casey (justincc) | 2011-08-24 | 1 | -8/+4 |
| | |||||
* | refactor: move Scene.Inventory.attachObjectAssetStore() into ↵ | Justin Clark-Casey (justincc) | 2011-08-24 | 1 | -2/+100 |
| | | | | AttachmentsModule.AddSceneObjectAsAttachment() | ||||
* | refactor: remove pointless AgentId argument from attachObjectAssetStore() | Justin Clark-Casey (justincc) | 2011-08-24 | 1 | -1/+1 |
| | |||||
* | add TestAddAttachmentFromGround() regression test | Justin Clark-Casey (justincc) | 2011-08-24 | 2 | -2/+32 |
| | |||||
* | Fix llAttachToAvatar() | Justin Clark-Casey (justincc) | 2011-08-24 | 1 | -10/+25 |
| | | | | | | Apart from one obvious bug, this was failing because attempting to serialize the script from inside the script (as part of saving the attachment as an inventory asset) was triggering an extremely long delay. So we now don't do this. The state will be serialized anyway when the avatar normally logs out. The worst that can happen is that if the client/server crashes, the attachment scripts start without previous state. | ||||
* | rename AttachmentsModule.ShowDetachInUserInventory() to ↵ | Justin Clark-Casey (justincc) | 2011-08-23 | 2 | -7/+6 |
| | | | | DetachSingleAttachmentToInv() for consistency and to reflect it's actual behaviour | ||||
* | remove mono compiler warnings | Justin Clark-Casey (justincc) | 2011-08-23 | 9 | -16/+4 |
| | |||||
* | replace TestRemoveAttachments() with a more thorough TestRemoveAttachment() | Justin Clark-Casey (justincc) | 2011-08-23 | 1 | -51/+27 |
| | |||||
* | replace old TestAddAttachments() with a more thorough TestAddAttachment() | Justin Clark-Casey (justincc) | 2011-08-23 | 1 | -7/+28 |
| | |||||
* | If an object failed to attach due to an exception, then try and detach it ↵ | Justin Clark-Casey (justincc) | 2011-08-23 | 1 | -1/+2 |
| | | | | | | | from the avatar's list of attachments as well as delete it from the scene. This may help with the "Inconsistent attachment state" errors seen on teleport. See http://opensimulator.org/mantis/view.php?id=5644 and linked reports | ||||
* | If an attachment fails, then start logging the exception for now, in order ↵ | Justin Clark-Casey (justincc) | 2011-08-22 | 1 | -55/+80 |
| | | | | | | to help with the inconsistent state bug. This also refactors AttachmentsModules to stop pointlessly refetching the ScenePresence in various methods. However, more of this is required. | ||||
* | Thanks Neil Canham for fixing bulk inventory updates, no sending ↵ | Snoopy Pfeffer | 2011-08-22 | 1 | -1/+12 |
| | | | | BulkInventoryUpdate after accepting inventory items. | ||||
* | Add avatar and attachments to llRegionSay | BlueWall | 2011-08-20 | 1 | -4/+67 |
| | | | | | | | | | | | | llRegionSay will now message avatars on chan 0 and will message attachments on the avatar that listen on channels other than 0. This behavior is consistant with the LL implementation as tested on regions in Agni with one exception: this implementation does not include issue: https://jira.secondlife.com/browse/SCR-66? | ||||
* | Add llRegionSayTo | BlueWall | 2011-08-19 | 1 | -0/+21 |
| | | | | | | | llRegionSayTo(key target, integer channel, string messasge) Allows messages to be sent region-wide to a particular prim. | ||||
* | Stop NPC's getting hypergrid like names in some circumstances. | Justin Clark-Casey (justincc) | 2011-08-19 | 1 | -13/+32 |
| | | | | | This meant punching in another AddUser() method in IUserManagement to do a direct name to UUID associated without the account check (since NPCs don't have accounts). May address http://opensimulator.org/mantis/view.php?id=5645 | ||||
* | Don't try to save changed attachment states when an NPC with attachments is ↵ | Justin Clark-Casey (justincc) | 2011-08-18 | 1 | -2/+2 |
| | | | | | | | removed from the scene. This is done by introducing a PresenceType enum into ScenePresence which currently has two values, User and Npc. This seems better than a SaveAttachments flag in terms of code comprehension, though I'm still slightly uneasy about introducing these semantics to core objects | ||||
* | comment out noisy attachments logging | Justin Clark-Casey (justincc) | 2011-08-17 | 1 | -5/+5 |
| | |||||
* | For now, supress 'OH NOES' warnings given by ↵ | Justin Clark-Casey (justincc) | 2011-08-17 | 1 | -5/+5 |
| | | | | | | | HGInventoryBroker.CacheInventoryServiceURL when it tries to cache it for an NPC This concept is meaningless for NPCs. However, it might be better to make NPCism an actual property on ScenePresence and check. Addresses http://opensimulator.org/mantis/view.php?id=5643 |