aboutsummaryrefslogtreecommitdiffstatshomepage
Commit message (Collapse)AuthorAgeFilesLines
* This is a completely unreasonable thing to do, effectively defying the ↵Diva Canto2013-07-171-40/+52
| | | | purpose of BlockingQueues. Trying this, to see the effect on CPU.
* Now trying DoubleQueue instead of BlockingQueue for the ↵Diva Canto2013-07-171-2/+2
| | | | PollServiceRequestManager.
* I confuse myself. Let's try this variable name instead.Diva Canto2013-07-171-3/+3
|
* Do the same trick that dahlia did for Dequeue(timeout)Diva Canto2013-07-171-2/+3
|
* Putting the requests back in the queue while testing for count >0 is not the ↵Diva Canto2013-07-171-3/+7
| | | | smartest move...
* Didn't mean to commit this change in BlockingQueue.csDiva Canto2013-07-171-1/+1
|
* Merge branch 'master' of ssh://opensimulator.org/var/git/opensimDiva Canto2013-07-172-6/+10
|\
| * BulletSim: fix small bug where everything looked like it was collidingRobert Adams2013-07-172-6/+10
| | | | | | | | before the first simulator step.
* | Cleared up much confusion in PollServiceRequestManager. Here's the history:Diva Canto2013-07-174-52/+41
|/ | | | | | When Melanie added the web fetch inventory throttle to core, she made the long poll requests (EQs) effectively be handled on an active loop. All those requests, if they existed, were being constantly dequeued, checked for events (which most often they didn't have), and requeued again. This was an active loop thread on a 100ms cycle! This fixes the issue. Now the inventory requests, if they aren't ready to be served, are placed directly back in the queue, but the long poll requests aren't placed there until there are events ready to be sent or timeout has been reached. This puts the LongPollServiceWatcherThread back to 1sec cycle, as it was before.
* Removed the MapItems thread. Redirected the map items requests to the ↵Diva Canto2013-07-162-9/+45
| | | | services throttle thread. Didn't change anything in how that processor is implemented, for better or for worse.
* Improvements to the ServiceThrottleModule: added a category and an itemid to ↵Diva Canto2013-07-164-11/+40
| | | | the interface, so that duplicate requests aren't enqueued more than once.
* UserManagementModule: in the continuation, call the method that also looks ↵Diva Canto2013-07-161-2/+2
| | | | up the cache, because the resource may be here in the meantime
* Merge branch 'master' of ssh://opensimulator.org/var/git/opensimDiva Canto2013-07-163-6/+12
|\
| * Attachments module only registers when enabled. This enables alternative ↵Dan Lake2013-07-163-6/+12
| | | | | | | | attachments module implementations. All calls to Scene.AttachmentsModule are checking for null. Ideally, if we support disabling attachments then we need a null attachments module to register with the scene.
* | Added config var to fiddle with the Interval for the service throttle threadDiva Canto2013-07-161-1/+4
|/
* Deleted a couple of verbose messagesDiva Canto2013-07-162-4/+2
|
* Merge branch 'master' of ssh://opensimulator.org/var/git/opensimDiva Canto2013-07-161-1/+19
|\
| * minor: Add warning method doc about possibly inconsistent results returned ↵Justin Clark-Casey (justincc)2013-07-161-1/+19
| | | | | | | | from BlockingQueue.Contains(), Count() and GetQueueArray()
| * Revert "Revert "MSDN documentation is unclear about whether exiting a lock() ↵Justin Clark-Casey (justincc)2013-07-161-5/+8
| | | | | | | | | | | | | | | | | | | | | | block will trigger a Monitor.Wait() to exit, so avoid some locks that don't actually affect the state of the internal queues in the BlockingQueue class."" This reverts commit 21a09ad3ad42b24bce4fc04c6bcd6f7d9a80af08. After more analysis and discussion, it is apparant that the Count(), Contains() and GetQueueArray() cannot be made thread-safe anyway without external locking And this change appears to have a positive impact on performance. I still believe that Monitor.Exit() will not release any thread for Monitor.Wait(), as per http://msdn.microsoft.com/en-gb/library/vstudio/system.threading.monitor.exit%28v=vs.100%29.aspx so this should in theory make no difference, though mono implementation issues could possibly be coming into play.
| * Revert "MSDN documentation is unclear about whether exiting a lock() block ↵Justin Clark-Casey (justincc)2013-07-161-8/+5
| | | | | | | | | | | | | | | | | | | | | | | | will trigger a Monitor.Wait() to exit, so avoid some locks that don't actually affect the state of the internal queues in the BlockingQueue class." This reverts commit 42e2a0d66eaa7e322bce817e9e2cc9a288de167b Reverting because unfortunately this introduces race conditions because Contains(), Count() and GetQueueArray() may now end up returning the wrong result if another thread performs a simultaneous update on m_queue. Code such as PollServiceRequestManager.Stop() relies on the count being correct otherwise a request may be lost. Also, though some of the internal queue methods do not affect state, they are not thread-safe and could return the wrong result generating the same problem lock() generates Monitor.Enter() and Monitor.Exit() under the covers. Monitor.Exit() does not cause Monitor.Wait() to exist, only Pulse() and PulseAll() will do this Reverted with agreement.
* | Added IServiceThrottleModule.csDiva Canto2013-07-161-0/+11
| |
* | Changed the name to ServiceThrottle/ServiceThrottleModule in order to ↵Diva Canto2013-07-161-0/+0
| | | | | | | | reflect its more generic nature.
* | Eliminated the UserManagement/UserManagementModule throttle thread. Made the ↵Diva Canto2013-07-162-189/+148
|/ | | | other one generic, taking any continuation.
* In the pursuit of using less CPU: now trying to avoid blocking queues ↵Diva Canto2013-07-162-15/+120
| | | | altogether. Instead, this uses a timer. No sure if it's better or worse, but worth the try.
* Actually use DoubleQueue in UserManagement/UserManagementModuleDiva Canto2013-07-161-1/+1
|
* High CPU hunt: try a different blocking queue, DoubleQueueDiva Canto2013-07-162-1/+3
|
* revert last commit which seems to conflict with DoubleQueue internals. The ↵dahlia2013-07-161-10/+5
| | | | random crash might be in DoubleQueue instead. See http://pastebin.com/XhNBNqsc
* add locking to internal queue in WebFetchInvDescModule; lack of which caused ↵dahlia2013-07-161-5/+10
| | | | a random crash in a load test yesterday
* MSDN documentation is unclear about whether exiting a lock() block will ↵dahlia2013-07-161-5/+8
| | | | trigger a Monitor.Wait() to exit, so avoid some locks that don't actually affect the state of the internal queues in the BlockingQueue class.
* Simplify EventQueue cap setup so that it is also stat monitored.Justin Clark-Casey (justincc)2013-07-161-45/+29
| | | | Curiously, the number of requests received is always one greater than that shown as handled - needs investigation
* Merge branch 'master' of ssh://opensimulator.org/var/git/opensimJustin Clark-Casey (justincc)2013-07-1530-295/+679
|\
| * Revert "Puts RequestImage (UDP) back to asyn -- CPU spike hunt"Diva Canto2013-07-151-1/+1
| | | | | | | | This reverts commit b060ce96d93a33298b59392210af4d336e0d171b.
| * Guard against null refDiva Canto2013-07-151-1/+2
| |
| * Puts RequestImage (UDP) back to asyn -- CPU spike huntDiva Canto2013-07-151-1/+1
| |
| * Revert the revertDiva Canto2013-07-151-0/+2
| | | | | | | | | | | | Revert "Trying to hunt the CPU spikes recently experienced." This reverts commit ac73e702935dd4607c13aaec3095940fba7932ca.
| * Protect against null requestsDiva Canto2013-07-152-12/+16
| |
| * Trying to hunt the CPU spikes recently experienced.Diva Canto2013-07-151-2/+0
| | | | | | | | | | | | Revert "Comment out old inbound UDP throttling hack. This would cause the UDP" This reverts commit 38e6da5522a53c7f65eac64ae7b0af929afb1ae6.
| * This might address the following observed exception:Diva Canto2013-07-151-1/+1
| | | | | | | | | | | | | | | | | | 17:14:28 - [APPLICATION]: APPLICATION EXCEPTION DETECTED: System.UnhandledExceptionEventArgs Exception: System.InvalidOperationException: Operation is not valid due to the current state of the object at System.Collections.Generic.Queue`1[OpenSim.Region.ClientStack.Linden.WebFetchInvDescModule+aPollRequest].Peek () [0x00011] in /root/install/mono-3.1.0/mono/mcs/class/System/System.Collections.Generic/Queue.cs:158 at System.Collections.Generic.Queue`1[OpenSim.Region.ClientStack.Linden.WebFetchInvDescModule+aPollRequest].Dequeue () [0x00000] in /root/install/mono-3.1.0/mono/mcs/class/System/System.Collections.Generic/Queue.cs:140 at OpenSim.Framework.DoubleQueue`1[OpenSim.Region.ClientStack.Linden.WebFetchInvDescModule+aPollRequest].Dequeue (TimeSpan wait, OpenSim.Region.ClientStack.Linden.aPollRequest& res) [0x0004e] in /home/avacon/opensim_2013-07-14/OpenSim/Framework/Util.cs:2297
| * Document obscure Groups config related to the user level required for ↵Diva Canto2013-07-141-0/+4
| | | | | | | | creating groups
| * Added SQLite version of hg travel data store. UNTESTED. Hope it works!Diva Canto2013-07-142-0/+100
| |
| * Cleanup old hg sessions (older than 2 days)Diva Canto2013-07-145-2/+20
| |
| * HG UAS: Moved hg-session data from memory to DB storage. This makes it so ↵Diva Canto2013-07-145-90/+344
| | | | | | | | that traveling info survives Robust resets. It should also eliminate the cause of empty IP addresses in agent circuit data that we saw in CC grid. MySQL only.
| * Minor typo in log messageDiva Canto2013-07-141-1/+1
| |
| * Let's go easy on authenticating ChildAgentUpdates, otherwise this will be ↵Diva Canto2013-07-141-7/+5
| | | | | | | | chaotic while ppl are using different versions of opensim. Warning only, but no enforcement.
| * Fix broken tests -- the test setup was wrong... sigh.Diva Canto2013-07-142-1/+2
| |
| * Authenticate ChildAgentUpdate too.Diva Canto2013-07-144-18/+32
| |
| * Change the auth token to be the user's sessionid.Diva Canto2013-07-144-7/+10
| |
| * And this fixes the other failing tests. Justin, the thread pool is not being ↵Diva Canto2013-07-131-2/+0
| | | | | | | | initialized in the tests!
| * This should fix the failing test.Diva Canto2013-07-131-2/+1
| |
| * Deleted a line too manyDiva Canto2013-07-131-0/+3
| |