aboutsummaryrefslogtreecommitdiffstatshomepage
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Revert "MSDN documentation is unclear about whether exiting a lock() ↵Justin Clark-Casey (justincc)2013-07-161-5/+8
| | | | | | | | | | | block will trigger a Monitor.Wait() to exit, so avoid some locks that don't actually affect the state of the internal queues in the BlockingQueue class."" This reverts commit 21a09ad3ad42b24bce4fc04c6bcd6f7d9a80af08. After more analysis and discussion, it is apparant that the Count(), Contains() and GetQueueArray() cannot be made thread-safe anyway without external locking And this change appears to have a positive impact on performance. I still believe that Monitor.Exit() will not release any thread for Monitor.Wait(), as per http://msdn.microsoft.com/en-gb/library/vstudio/system.threading.monitor.exit%28v=vs.100%29.aspx so this should in theory make no difference, though mono implementation issues could possibly be coming into play.
* Revert "MSDN documentation is unclear about whether exiting a lock() block ↵Justin Clark-Casey (justincc)2013-07-161-8/+5
| | | | | | | | | | | | will trigger a Monitor.Wait() to exit, so avoid some locks that don't actually affect the state of the internal queues in the BlockingQueue class." This reverts commit 42e2a0d66eaa7e322bce817e9e2cc9a288de167b Reverting because unfortunately this introduces race conditions because Contains(), Count() and GetQueueArray() may now end up returning the wrong result if another thread performs a simultaneous update on m_queue. Code such as PollServiceRequestManager.Stop() relies on the count being correct otherwise a request may be lost. Also, though some of the internal queue methods do not affect state, they are not thread-safe and could return the wrong result generating the same problem lock() generates Monitor.Enter() and Monitor.Exit() under the covers. Monitor.Exit() does not cause Monitor.Wait() to exist, only Pulse() and PulseAll() will do this Reverted with agreement.
* In the pursuit of using less CPU: now trying to avoid blocking queues ↵Diva Canto2013-07-162-15/+120
| | | | altogether. Instead, this uses a timer. No sure if it's better or worse, but worth the try.
* Actually use DoubleQueue in UserManagement/UserManagementModuleDiva Canto2013-07-161-1/+1
|
* High CPU hunt: try a different blocking queue, DoubleQueueDiva Canto2013-07-162-1/+3
|
* revert last commit which seems to conflict with DoubleQueue internals. The ↵dahlia2013-07-161-10/+5
| | | | random crash might be in DoubleQueue instead. See http://pastebin.com/XhNBNqsc
* add locking to internal queue in WebFetchInvDescModule; lack of which caused ↵dahlia2013-07-161-5/+10
| | | | a random crash in a load test yesterday
* MSDN documentation is unclear about whether exiting a lock() block will ↵dahlia2013-07-161-5/+8
| | | | trigger a Monitor.Wait() to exit, so avoid some locks that don't actually affect the state of the internal queues in the BlockingQueue class.
* Simplify EventQueue cap setup so that it is also stat monitored.Justin Clark-Casey (justincc)2013-07-161-45/+29
| | | | Curiously, the number of requests received is always one greater than that shown as handled - needs investigation
* Merge branch 'master' of ssh://opensimulator.org/var/git/opensimJustin Clark-Casey (justincc)2013-07-1530-295/+679
|\
| * Revert "Puts RequestImage (UDP) back to asyn -- CPU spike hunt"Diva Canto2013-07-151-1/+1
| | | | | | | | This reverts commit b060ce96d93a33298b59392210af4d336e0d171b.
| * Guard against null refDiva Canto2013-07-151-1/+2
| |
| * Puts RequestImage (UDP) back to asyn -- CPU spike huntDiva Canto2013-07-151-1/+1
| |
| * Revert the revertDiva Canto2013-07-151-0/+2
| | | | | | | | | | | | Revert "Trying to hunt the CPU spikes recently experienced." This reverts commit ac73e702935dd4607c13aaec3095940fba7932ca.
| * Protect against null requestsDiva Canto2013-07-152-12/+16
| |
| * Trying to hunt the CPU spikes recently experienced.Diva Canto2013-07-151-2/+0
| | | | | | | | | | | | Revert "Comment out old inbound UDP throttling hack. This would cause the UDP" This reverts commit 38e6da5522a53c7f65eac64ae7b0af929afb1ae6.
| * This might address the following observed exception:Diva Canto2013-07-151-1/+1
| | | | | | | | | | | | | | | | | | 17:14:28 - [APPLICATION]: APPLICATION EXCEPTION DETECTED: System.UnhandledExceptionEventArgs Exception: System.InvalidOperationException: Operation is not valid due to the current state of the object at System.Collections.Generic.Queue`1[OpenSim.Region.ClientStack.Linden.WebFetchInvDescModule+aPollRequest].Peek () [0x00011] in /root/install/mono-3.1.0/mono/mcs/class/System/System.Collections.Generic/Queue.cs:158 at System.Collections.Generic.Queue`1[OpenSim.Region.ClientStack.Linden.WebFetchInvDescModule+aPollRequest].Dequeue () [0x00000] in /root/install/mono-3.1.0/mono/mcs/class/System/System.Collections.Generic/Queue.cs:140 at OpenSim.Framework.DoubleQueue`1[OpenSim.Region.ClientStack.Linden.WebFetchInvDescModule+aPollRequest].Dequeue (TimeSpan wait, OpenSim.Region.ClientStack.Linden.aPollRequest& res) [0x0004e] in /home/avacon/opensim_2013-07-14/OpenSim/Framework/Util.cs:2297
| * Document obscure Groups config related to the user level required for ↵Diva Canto2013-07-141-0/+4
| | | | | | | | creating groups
| * Added SQLite version of hg travel data store. UNTESTED. Hope it works!Diva Canto2013-07-142-0/+100
| |
| * Cleanup old hg sessions (older than 2 days)Diva Canto2013-07-145-2/+20
| |
| * HG UAS: Moved hg-session data from memory to DB storage. This makes it so ↵Diva Canto2013-07-145-90/+344
| | | | | | | | that traveling info survives Robust resets. It should also eliminate the cause of empty IP addresses in agent circuit data that we saw in CC grid. MySQL only.
| * Minor typo in log messageDiva Canto2013-07-141-1/+1
| |
| * Let's go easy on authenticating ChildAgentUpdates, otherwise this will be ↵Diva Canto2013-07-141-7/+5
| | | | | | | | chaotic while ppl are using different versions of opensim. Warning only, but no enforcement.
| * Fix broken tests -- the test setup was wrong... sigh.Diva Canto2013-07-142-1/+2
| |
| * Authenticate ChildAgentUpdate too.Diva Canto2013-07-144-18/+32
| |
| * Change the auth token to be the user's sessionid.Diva Canto2013-07-144-7/+10
| |
| * And this fixes the other failing tests. Justin, the thread pool is not being ↵Diva Canto2013-07-131-2/+0
| | | | | | | | initialized in the tests!
| * This should fix the failing test.Diva Canto2013-07-131-2/+1
| |
| * Deleted a line too manyDiva Canto2013-07-131-0/+3
| |
| * Guard against unauthorized agent deletes.Diva Canto2013-07-139-32/+57
| |
| * Deleted GET agent all around. Not used.Diva Canto2013-07-135-134/+2
| |
| * Gatekeeper: stop bogus agents earlier, here at the Gatekeeper. No need to ↵Diva Canto2013-07-131-0/+6
| | | | | | | | bother the sim.
| * Some more debug to see how many threads are available.Diva Canto2013-07-131-0/+2
| |
| * That didn't fix the problem.Diva Canto2013-07-132-27/+38
| | | | | | | | | | | | Revert "Trying to reduce CPU usage on logins and TPs: trying radical elimination of all FireAndForgets throughout CompleteMovement. There were 4." This reverts commit 682537738008746f0aca22954902f3a4dfbdc95f.
| * Trying to reduce CPU usage on logins and TPs: trying radical elimination of ↵Diva Canto2013-07-132-38/+27
| | | | | | | | all FireAndForgets throughout CompleteMovement. There were 4.
| * This commit effectively reverses the previous one, but it's just to log that ↵Diva Canto2013-07-131-4/+4
| | | | | | | | | | | | we found the root of the rez delay: the priority scheme BestAvatarResponsiveness, which is currently the default, was the culprit. Changing it to FrontBack made the region rez be a lot more natural. BestAvatarResponsiveness introduces the region rez delay in cases where the region is full of avatars with lots of attachments, which is the case in CC load tests. In that case, the inworld prims are sent only after all avatar attachments are sent. Not recommended for regions with heavy avatar traffic!
| * Same issue as previous commit.Diva Canto2013-07-131-3/+4
| |
| * Merge branch 'master' of ssh://opensimulator.org/var/git/opensimDiva Canto2013-07-135-10/+121
| |\
| * | Moved SendInitialDataToMe to earlier in CompleteMovement. Moved ↵Diva Canto2013-07-132-6/+15
| | | | | | | | | | | | | | | | | | | | | | | | TriggerOnMakeRootAgent to the end of CompleteMovement. Justin, if you read this, there's a long story here. Some time ago you placed SendInitialDataToMe at the very beginning of client creation (in LLUDPServer). That is problematic, as we discovered relatively recently: on TPs, as soon as the client starts getting data from child agents, it starts requesting resources back *from the simulator where its root agent is*. We found this to be the problem behind meshes missing on HG TPs (because the viewer was requesting the meshes of the receiving sim from the departing grid). But this affects much more than meshes and HG TPs. It may also explain cloud avatars after a local TP: baked textures are only stored in the simulator, so if a child agent receives a UUID of a baked texture in the destination sim and requests that texture from the departing sim where the root agent is, it will fail to get that texture. Bottom line: we need to delay sending the new simulator data to the viewer until we are absolutely sure that the viewer knows that its main agent is in a new sim. Hence, moving it to CompleteMovement. Now I am trying to tune the initial rez delay that we all experience in the CC. I think that when I fixed the issue described above, I may have moved SendInitialDataToMe to much later than it should be, so now I'm moving to earlier in CompleteMovement.
| * | Added UploadBakedTexture/UploadBakedTextureServerConnector, so that this can ↵Diva Canto2013-07-131-0/+76
| | | | | | | | | | | | eventually be served by a robust instance. NOT FINISHED YET.
* | | Add request received/handling stats for caps which are served by http poll ↵Justin Clark-Casey (justincc)2013-07-1511-126/+267
| |/ |/| | | | | | | | | | | handlers. This adds explicit cap poll handler supporting to the Caps classes rather than relying on callers to do the complicated coding. Other refactoring was required to get logic into the right places to support this.
* | Reinsert PhysicsActor variable back into SOP.SubscribeForCollisionEvents() ↵Justin Clark-Casey (justincc)2013-07-131-8/+12
| | | | | | | | | | | | | | | | in order to avoid a race condition. A separate PhysicsActor variable is used in case some other thread removes the PhysicsActor whilst this code is executing. If this is now impossible please revert - just adding this now whilst I remember. Also makes method comment into proper method doc.
* | Merge branch 'master' of ssh://opensimulator.org/var/git/opensimJustin Clark-Casey (justincc)2013-07-135-10/+134
|\ \
| * | Add ToOSDMap() overrides to the Stat subclass CounterStat.Robert Adams2013-07-123-0/+88
| |/ | | | | | | | | Add a GetStatsAsOSDMap method to StatsManager which allows the filtered fetching of stats for eventual returning over the internets.
| * Merge branch 'master' of ssh://opensimulator.org/var/git/opensimDiva Canto2013-07-128-106/+313
| |\
| * | Changed UploadBakedTextureModule so that it uses the same pattern as the ↵Diva Canto2013-07-121-8/+27
| | | | | | | | | | | | others, in preparation for experiments to direct baked texture uploads to a robust instance. No functional or configuration changes -- should work exactly as before.
| * | Added a few more thingies to the asset client test to poke the threadpool.Diva Canto2013-07-111-2/+19
| | |
* | | In co-op termination, extend EventWaitHandle to give this an indefinite ↵Justin Clark-Casey (justincc)2013-07-131-2/+21
| |/ |/| | | | | | | | | | | lifetime in order to avoid a later RemotingException if scripts are being loaded into their own domains. This is necessary because XEngineScriptBase now retains a reference to an EventWaitHandle when co-op termination is active. Aims to address http://opensimulator.org/mantis/view.php?id=6634
* | Enhance NullEstateData to remember stored estate values and returnRobert Adams2013-07-111-7/+21
| | | | | | | | | | them next time asked. This keeps any estate settings from being reset when the estate dialog is opened in a region with null estate storage.
* | Centralize duplicated code in SceneObjectPart for subscribing toRobert Adams2013-07-111-54/+43
| | | | | | | | | | collision events. Improve logic for knowing when to add processing routine to physics actor.