#952 again

1 files changed, 21 insertions, 7 deletions

diff --git a/OpenSim/Region/Environment/Modules/FriendsModule.cs b/OpenSim/Region/Environment/Modules/FriendsModule.cs
index a6d44ee..a2ec599 100644
--- a/OpenSim/Region/Environment/Modules/FriendsModule.cs
+++ b/OpenSim/Region/Environment/Modules/FriendsModule.cs
@@ -88,6 +88,9 @@ namespace OpenSim.Region.Environment.Modules
             client.OnTerminateFriendship += OnTerminateFriendship;
 
             List<FriendListItem> fl = new List<FriendListItem>();
+
+            //bool addFLback = false;
+
             lock (FriendLists)
             {
                 if (FriendLists.ContainsKey(client.AgentId))
@@ -97,11 +100,12 @@ namespace OpenSim.Region.Environment.Modules
                 else 
                 {
                     fl = m_scene[0].GetFriendList(client.AgentId);
-                    lock (FriendLists)
-                    {
+                    
+                    //lock (FriendLists)
+                    //{
                         if (!FriendLists.ContainsKey(client.AgentId))
                             FriendLists.Add(client.AgentId, fl);
-                    }
+                    //}
                 }
             }
             
@@ -200,11 +204,21 @@ namespace OpenSim.Region.Environment.Modules
                 for (int i = 0; i < updateUsers.Count; i++)
                 {
                     List<FriendListItem> flfli = new List<FriendListItem>();
-                    
-                    lock (FriendLists)
+                    try
+                    {
+
+                        lock (FriendLists)
+                        {
+                            if (FriendLists.ContainsKey(updateUsers[i]))
+                                flfli = FriendLists[updateUsers[i]];
+                        }
+                    }
+                    catch (IndexOutOfRangeException)
                     {
-                        if (FriendLists.ContainsKey(updateUsers[i]))
-                            flfli = FriendLists[updateUsers[i]];
+                        // Ignore the index out of range exception.  
+                        // This causes friend lists to get out of sync slightly..  however
+                        // prevents a sim crash.
+                        m_log.Info("[FRIEND]: Unable to enumerate last friendlist user.  User logged off");
                     }
 
                     for (int j = 0; j < flfli.Count; j++)