Fixed permissions bug related to friends in PermissionsModule. Added FriendsData[] GetFriends(string principalID) to IFriendsData and FriendInfo[] GetFriends(string PrincipalID) to IFriendsService. Refactored some more in the FriendsModule. Made client get notification of local friends permissions upon HGLogin. HG Friends object permissions work.

1 files changed, 15 insertions, 3 deletions

diff --git a/OpenSim/Services/Connectors/SimianGrid/SimianFriendsServiceConnector.cs b/OpenSim/Services/Connectors/SimianGrid/SimianFriendsServiceConnector.cs
index f61ab29..b1c34dd 100644
--- a/OpenSim/Services/Connectors/SimianGrid/SimianFriendsServiceConnector.cs
+++ b/OpenSim/Services/Connectors/SimianGrid/SimianFriendsServiceConnector.cs
@@ -78,6 +78,11 @@ namespace OpenSim.Services.Connectors.SimianGrid
 
         public FriendInfo[] GetFriends(UUID principalID)
         {
+            return GetFriends(principalID.ToString());
+        }
+
+        public FriendInfo[] GetFriends(string principalID)
+        {
             if (String.IsNullOrEmpty(m_serverUrl))
                 return new FriendInfo[0];
 
@@ -95,7 +100,14 @@ namespace OpenSim.Services.Connectors.SimianGrid
                     UUID friendID = friendEntry["Key"].AsUUID();
 
                     FriendInfo friend = new FriendInfo();
-                    friend.PrincipalID = principalID;
+                    if (!UUID.TryParse(principalID, out friend.PrincipalID))
+                    {
+                        string tmp = string.Empty;
+                        if (!Util.ParseUniversalUserIdentifier(principalID, out friend.PrincipalID, out tmp, out tmp, out tmp))
+                            // bad record. ignore this entry
+                            continue;
+                    }
+
                     friend.Friend = friendID.ToString();
                     friend.MyFlags = friendEntry["Value"].AsInteger();
                     friend.TheirFlags = -1;
@@ -174,7 +186,7 @@ namespace OpenSim.Services.Connectors.SimianGrid
 
         #endregion IFriendsService
 
-        private OSDArray GetFriended(UUID ownerID)
+        private OSDArray GetFriended(string ownerID)
         {
             NameValueCollection requestArgs = new NameValueCollection
             {
@@ -195,7 +207,7 @@ namespace OpenSim.Services.Connectors.SimianGrid
             }
         }
 
-        private OSDArray GetFriendedBy(UUID ownerID)
+        private OSDArray GetFriendedBy(string ownerID)
         {
             NameValueCollection requestArgs = new NameValueCollection
             {