Merge branch 'master' into careminster

Conflicts:
	OpenSim/Framework/RegionSettings.cs

3 files changed, 104 insertions, 71 deletions

diff --git a/OpenSim/Region/ClientStack/Linden/UDP/LLClientView.cs b/OpenSim/Region/ClientStack/Linden/UDP/LLClientView.cs
index d9dc6b7..bbaa08e 100644
--- a/OpenSim/Region/ClientStack/Linden/UDP/LLClientView.cs
+++ b/OpenSim/Region/ClientStack/Linden/UDP/LLClientView.cs
@@ -9303,10 +9303,22 @@ namespace OpenSim.Region.ClientStack.LindenUDP
                     {
                         UUID invoice = messagePacket.MethodData.Invoice;
                         UUID SenderID = messagePacket.AgentData.AgentID;
-                        UInt32 param1 = Convert.ToUInt32(Utils.BytesToString(messagePacket.ParamList[1].Parameter));
+                        UInt32 param1 = 0u;
 
                         string command = (string)Utils.BytesToString(messagePacket.ParamList[0].Parameter);
 
+                        if (command != "info ui")
+                        {
+                            try
+                            {
+                                param1 = Convert.ToUInt32(Utils.BytesToString(messagePacket.ParamList[1].Parameter));
+                            }
+                            catch (Exception ex)
+                            {
+
+                            }
+                        }
+
                         EstateManageTelehub handlerEstateManageTelehub = OnEstateManageTelehub;
                         if (handlerEstateManageTelehub != null)
                         {
diff --git a/OpenSim/Region/CoreModules/World/Estate/EstateManagementModule.cs b/OpenSim/Region/CoreModules/World/Estate/EstateManagementModule.cs
index 35ad939..4f3b271 100644
--- a/OpenSim/Region/CoreModules/World/Estate/EstateManagementModule.cs
+++ b/OpenSim/Region/CoreModules/World/Estate/EstateManagementModule.cs
@@ -55,7 +55,7 @@ namespace OpenSim.Region.CoreModules.World.Estate
         protected EstateManagementCommands m_commands;                
 
         private EstateTerrainXferHandler TerrainUploader;
-        private TelehubManager m_Telehub;
+        public TelehubManager m_Telehub;
 
         public event ChangeDelegate OnRegionInfoChange;
         public event ChangeDelegate OnEstateInfoChange;
@@ -615,22 +615,20 @@ namespace OpenSim.Region.CoreModules.World.Estate
             }
         }
 
-        private void handleOnEstateManageTelehub (IClientAPI client, UUID invoice, UUID senderID, string cmd, uint param1)
+        public void handleOnEstateManageTelehub (IClientAPI client, UUID invoice, UUID senderID, string cmd, uint param1)
         {
             uint ObjectLocalID;
             SceneObjectPart part;
-            // UUID EstateID = Scene.RegionInfo.EstateSettings.EstateID;
-            TelehubManager.Telehub telehub;
 
             switch (cmd)
             {
                 case "info ui":
                     // Send info:
-                    if (m_Telehub.HasTelehub)
+                    if (Scene.RegionInfo.RegionSettings.HasTelehub)
                     {
-                        telehub = m_Telehub.TelehubVals();
-                        client.SendTelehubInfo(telehub.ObjectID, telehub.ObjectName, telehub.ObjectPosition,
-                                               telehub.ObjectRotation, telehub.SpawnPoint);
+                        RegionSettings settings = this.Scene.RegionInfo.RegionSettings;
+                            client.SendTelehubInfo(settings.TelehubObject, settings.TelehubName, settings.TelehubPos,
+                                               settings.TelehubRot, settings.SpawnPoints());
                     }
                     else
                     {
@@ -641,32 +639,44 @@ namespace OpenSim.Region.CoreModules.World.Estate
                 case "connect":
                     // Add the Telehub
                     part = Scene.GetSceneObjectPart((uint)param1);
-                    telehub = m_Telehub.Connect(part);
-                    client.SendTelehubInfo(telehub.ObjectID, telehub.ObjectName, telehub.ObjectPosition,
-                                           telehub.ObjectRotation, telehub.SpawnPoint);
+                    if (m_Telehub.Connect(part))
+                    {
+                        RegionSettings settings = this.Scene.RegionInfo.RegionSettings;
+                            client.SendTelehubInfo(settings.TelehubObject, settings.TelehubName, settings.TelehubPos,
+                                               settings.TelehubRot, settings.SpawnPoints());
+                    }
                     break;
 
                 case "delete":
                     // Disconnect Telehub
                     part = Scene.GetSceneObjectPart((uint)param1);
-                    telehub = m_Telehub.DisConnect(part);
-                    client.SendTelehubInfo(telehub.ObjectID, telehub.ObjectName, telehub.ObjectPosition,
-                                           telehub.ObjectRotation, telehub.SpawnPoint);
+                    if (m_Telehub.DisConnect(part))
+                    {
+                        RegionSettings settings = this.Scene.RegionInfo.RegionSettings;
+                            client.SendTelehubInfo(settings.TelehubObject, settings.TelehubName, settings.TelehubPos,
+                                               settings.TelehubRot, settings.SpawnPoints());
+                    }
                     break;
 
                 case "spawnpoint add":
                     // Add SpawnPoint to the Telehub
                     part = Scene.GetSceneObjectPart((uint)param1);
-                    telehub = m_Telehub.AddSpawnPoint(part.AbsolutePosition);
-                    client.SendTelehubInfo(telehub.ObjectID, telehub.ObjectName, telehub.ObjectPosition,
-                                           telehub.ObjectRotation, telehub.SpawnPoint);
+                    if( m_Telehub.AddSpawnPoint(part.AbsolutePosition))
+                    {
+                        RegionSettings settings = this.Scene.RegionInfo.RegionSettings;
+                            client.SendTelehubInfo(settings.TelehubObject, settings.TelehubName, settings.TelehubPos,
+                                               settings.TelehubRot, settings.SpawnPoints());
+                    }
                     break;
 
                 case "spawnpoint remove":
                     // Remove SpawnPoint from Telehub
-                    telehub = m_Telehub.RemoveSpawnPoint((int)param1);
-                    client.SendTelehubInfo(telehub.ObjectID, telehub.ObjectName, telehub.ObjectPosition,
-                                           telehub.ObjectRotation, telehub.SpawnPoint);
+                    if (m_Telehub.RemoveSpawnPoint((int)param1))
+                    {
+                        RegionSettings settings = this.Scene.RegionInfo.RegionSettings;
+                            client.SendTelehubInfo(settings.TelehubObject, settings.TelehubName, settings.TelehubPos,
+                                               settings.TelehubRot, settings.SpawnPoints());
+                    }
                     break;
 
                 default:
diff --git a/OpenSim/Region/CoreModules/World/Estate/TelehubManager.cs b/OpenSim/Region/CoreModules/World/Estate/TelehubManager.cs
index c99c9ba..ee77ae1 100644
--- a/OpenSim/Region/CoreModules/World/Estate/TelehubManager.cs
+++ b/OpenSim/Region/CoreModules/World/Estate/TelehubManager.cs
@@ -35,14 +35,6 @@ namespace OpenSim.Region.CoreModules.World.Estate
 {
     public class TelehubManager
     {
-        public struct Telehub
-        {
-            public UUID ObjectID;
-            public string ObjectName;
-            public Vector3 ObjectPosition;
-            public Quaternion ObjectRotation;
-            public List<Vector3> SpawnPoint;
-        };
 
         private UUID ObjectID;
         private string ObjectName;
@@ -53,7 +45,7 @@ namespace OpenSim.Region.CoreModules.World.Estate
         bool m_HasTelehub = false;
         Scene m_Scene;
         // This will get an option...
-        Vector3 InitialSpawnPoint = new Vector3(0.0f,0.0f,-3.0f);
+        Vector3 InitialSpawnPoint = new Vector3(0.0f,0.0f,0.0f);
 
         public bool HasTelehub
         {
@@ -66,65 +58,84 @@ namespace OpenSim.Region.CoreModules.World.Estate
         }
 
         // Fill our Telehub struct with values
-        public Telehub TelehubVals()
-        {
-            Telehub telehub = new Telehub();
-
-            telehub.ObjectID = ObjectID;
-            telehub.ObjectName = ObjectName;
-            telehub.ObjectPosition = ObjectPosition;
-            telehub.ObjectRotation = ObjectRotation;
-            telehub.SpawnPoint = SpawnPoint;
-            return telehub;
-        }
+//        public Telehub TelehubVals()
+//        {
+//            // Telehub telehub = new Telehub();
+//            EstateSettings telehub = m_EstateSettings;
+//
+//            telehub.TelehubObject = ObjectID;
+//            telehub.TelehubName = ObjectName;
+//            telehub.TelehubPos = ObjectPosition;
+//            telehub.TelehubRot = ObjectRotation;
+//            telehub. = SpawnPoint;
+//            return telehub;
+//        }
 
         // Connect the Telehub
-        public Telehub Connect(SceneObjectPart part)
+        public bool Connect(SceneObjectPart part)
         {
-            ObjectID = part.UUID;
-            ObjectName = part.Name;
-            ObjectPosition = part.AbsolutePosition;
-            ObjectRotation = part.GetWorldRotation();
-            // Clear this for now
-            SpawnPoint.Clear();
-            SpawnPoint.Add(InitialSpawnPoint);
-            m_HasTelehub = true;
+            m_Scene.RegionInfo.RegionSettings.ClearSpawnPoints();
 
-            return TelehubVals();
+            m_Scene.RegionInfo.RegionSettings.TelehubObject = part.UUID;
+            m_Scene.RegionInfo.RegionSettings.TelehubName = part.Name;
+            m_Scene.RegionInfo.RegionSettings.TelehubPos = part.AbsolutePosition;
+            m_Scene.RegionInfo.RegionSettings.TelehubRot = part.GetWorldRotation();
+
+            // Clear this for now
+            m_Scene.RegionInfo.RegionSettings.AddSpawnPoint(InitialSpawnPoint);
+            m_Scene.RegionInfo.RegionSettings.HasTelehub = true;
+            m_Scene.RegionInfo.RegionSettings.Save();
+            return true;
         }
 
-        // Disconnect the Telehub
-        public Telehub DisConnect(SceneObjectPart part)
+        // Disconnect the Telehub: Clear it out for now, look at just disableing
+        public bool DisConnect(SceneObjectPart part)
         {
-            ObjectID = UUID.Zero;
-            ObjectName = String.Empty;
-            ObjectPosition = Vector3.Zero;
-            ObjectRotation = Quaternion.Identity;
-            SpawnPoint.Clear();
-            m_HasTelehub = false;
-
-            return TelehubVals();
+            bool result = false;
+
+            try{
+                m_Scene.RegionInfo.RegionSettings.TelehubObject = UUID.Zero;
+                m_Scene.RegionInfo.RegionSettings.TelehubName = String.Empty;
+                m_Scene.RegionInfo.RegionSettings.TelehubPos = Vector3.Zero;
+                // This is probably wrong! But, HasTelehub will block access
+                m_Scene.RegionInfo.RegionSettings.TelehubRot = Quaternion.Identity;
+                m_Scene.RegionInfo.RegionSettings.ClearSpawnPoints();
+                m_Scene.RegionInfo.RegionSettings.HasTelehub = false;
+                m_Scene.RegionInfo.RegionSettings.Save();
+                result = true;
+            }
+            catch (Exception ex)
+            {
+                result = false;
+            }
+            finally
+            {
+
+            }
+
+            return result;
         }
 
         // Add a SpawnPoint to the Telehub
-        public Telehub AddSpawnPoint(Vector3 point)
+        public bool AddSpawnPoint(Vector3 point)
         {
-            float dist = (float) Util.GetDistanceTo(ObjectPosition, point);
-
-            Vector3 nvec = Util.GetNormalizedVector(point - ObjectPosition);
 
+            float dist = (float) Util.GetDistanceTo(m_Scene.RegionInfo.RegionSettings.TelehubPos, point);
+            Vector3 nvec = Util.GetNormalizedVector(point - m_Scene.RegionInfo.RegionSettings.TelehubPos);
             Vector3 spoint = nvec * dist;
 
-            SpawnPoint.Add(spoint);
-            return TelehubVals();
+            m_Scene.RegionInfo.RegionSettings.AddSpawnPoint(spoint);
+            m_Scene.RegionInfo.RegionSettings.Save();
+            return true;
         }
 
         // Remove a SpawnPoint from the Telehub
-        public Telehub RemoveSpawnPoint(int spawnpoint)
+        public bool RemoveSpawnPoint(int spawnpoint)
         {
-            SpawnPoint.RemoveAt(spawnpoint);
+            m_Scene.RegionInfo.RegionSettings.RemoveSpawnPoint(spawnpoint);
+            m_Scene.RegionInfo.RegionSettings.Save();
 
-            return TelehubVals();
+            return true;
         }
     }
-}
\ No newline at end of file
+}