Add friendly error messages to both engines.

3 files changed, 74 insertions, 30 deletions

diff --git a/OpenSim/Region/ScriptEngine/DotNetEngine/EventQueueManager.cs b/OpenSim/Region/ScriptEngine/DotNetEngine/EventQueueManager.cs
index 634a12b..4a094e2 100644
--- a/OpenSim/Region/ScriptEngine/DotNetEngine/EventQueueManager.cs
+++ b/OpenSim/Region/ScriptEngine/DotNetEngine/EventQueueManager.cs
@@ -139,6 +139,8 @@ namespace OpenSim.Region.ScriptEngine.DotNetEngine
             public string functionName;
             public DetectParams[] llDetectParams;
             public object[] param;
+            public Dictionary<KeyValuePair<int,int>,KeyValuePair<int,int>>
+                    LineMap;
         }
 
         #endregion
@@ -349,6 +351,9 @@ namespace OpenSim.Region.ScriptEngine.DotNetEngine
                     return false;
                 }
 
+                InstanceData id = m_ScriptEngine.m_ScriptManager.GetScript(
+                        localID, itemID);
+
                 // Create a structure and add data
                 QueueItemStruct QIS = new QueueItemStruct();
                 QIS.localID = localID;
@@ -356,6 +361,8 @@ namespace OpenSim.Region.ScriptEngine.DotNetEngine
                 QIS.functionName = FunctionName;
                 QIS.llDetectParams = qParams;
                 QIS.param = param;
+                if (id != null)
+                    QIS.LineMap = id.LineMap;
 
                 // Add it to queue
                 eventQueue.Enqueue(QIS);
diff --git a/OpenSim/Region/ScriptEngine/DotNetEngine/EventQueueThreadClass.cs b/OpenSim/Region/ScriptEngine/DotNetEngine/EventQueueThreadClass.cs
index 2d60ed5..16dafdc 100644
--- a/OpenSim/Region/ScriptEngine/DotNetEngine/EventQueueThreadClass.cs
+++ b/OpenSim/Region/ScriptEngine/DotNetEngine/EventQueueThreadClass.cs
@@ -27,6 +27,7 @@
 
 using System;
 using System.Collections;
+using System.Collections.Generic;
 using System.Reflection;
 using System.Text.RegularExpressions;
 using System.Threading;
@@ -37,6 +38,7 @@ using OpenSim.Framework;
 using OpenSim.Region.Environment.Scenes;
 using OpenSim.Region.Environment.Scenes.Scripting;
 using OpenSim.Region.ScriptEngine.Shared;
+using OpenSim.Region.ScriptEngine.Shared.CodeTools;
 
 namespace OpenSim.Region.ScriptEngine.DotNetEngine
 {
@@ -198,10 +200,6 @@ namespace OpenSim.Region.ScriptEngine.DotNetEngine
                     }
                     catch (Exception e)
                     {
-                        if (lastScriptEngine != null)
-                            lastScriptEngine.Log.Error("[" + ScriptEngineName +
-                                    "]: Exception in EventQueueThreadLoop: " +
-                                    e.ToString());
                     }
                 }
             }
@@ -290,32 +288,32 @@ namespace OpenSim.Region.ScriptEngine.DotNetEngine
                         catch (Exception e)
                         {
                             InExecution = false;
+                            string text = FormatException(e, QIS.LineMap);
+
                             // DISPLAY ERROR INWORLD
-                            string text = "Error executing script function \"" +
-                                    QIS.functionName + "\":\r\n";
 
-                            if (e.InnerException != null)
-                            {
-                                // Send inner exception
-                                string line = " (unknown line)";
-                                Regex rx = new Regex(@"SecondLife\.Script\..+[\s:](?<line>\d+)\.?\r?$", RegexOptions.Compiled);
-                                if (rx.Match(e.InnerException.ToString()).Success)
-                                    line = " (line " + rx.Match(e.InnerException.ToString()).Result("${line}") + ")";
-                                text += e.InnerException.Message.ToString() + line;
-                            }
-                            else
-                            {
-                                text += "\r\n";
-                                // Send normal
-                                text += e.Message.ToString();
-                            }
-                            if (KillCurrentScript)
-                                text += "\r\nScript will be deactivated!";
+//                            if (e.InnerException != null)
+//                            {
+//                                // Send inner exception
+//                                string line = " (unknown line)";
+//                                Regex rx = new Regex(@"SecondLife\.Script\..+[\s:](?<line>\d+)\.?\r?$", RegexOptions.Compiled);
+//                                if (rx.Match(e.InnerException.ToString()).Success)
+//                                    line = " (line " + rx.Match(e.InnerException.ToString()).Result("${line}") + ")";
+//                                text += e.InnerException.Message.ToString() + line;
+//                            }
+//                            else
+//                            {
+//                                text += "\r\n";
+//                                // Send normal
+//                                text += e.Message.ToString();
+//                            }
+//                            if (KillCurrentScript)
+//                                text += "\r\nScript will be deactivated!";
 
                             try
                             {
-                                if (text.Length > 1500)
-                                    text = text.Substring(0, 1500);
+                                if (text.Length >= 1100)
+                                    text = text.Substring(0, 1099);
                                 IScriptHost m_host =
                                     m_ScriptEngine.World.GetSceneObjectPart(QIS.localID);
                                 m_ScriptEngine.World.SimChat(
@@ -343,10 +341,6 @@ namespace OpenSim.Region.ScriptEngine.DotNetEngine
                                         QIS.localID, QIS.itemID);
                                 }
                             }
-
-                            // Pass it on so it's displayed on the console
-                            // and in the logs (mikem 2008.06.02).
-                            throw e.InnerException;
                         }
                         finally
                         {
@@ -358,5 +352,45 @@ namespace OpenSim.Region.ScriptEngine.DotNetEngine
                 }
             }
         }
+
+        string FormatException(Exception e, Dictionary<KeyValuePair<int,int>,
+                KeyValuePair<int,int>> LineMap)
+        {
+            string message = "Runtime error:\n" + e.InnerException.StackTrace;
+            string[] lines = message.Split(new char[] {'\n'});
+
+            foreach (string line in lines)
+            {
+                if (line.Contains("SecondLife.Script"))
+                {
+                    int idx = line.IndexOf(':');
+                    if (idx != -1)
+                    {
+                        string val = line.Substring(idx+1);
+                        int lineNum = 0;
+                        if (int.TryParse(val, out lineNum))
+                        {
+                            KeyValuePair<int, int> pos =
+                                    Compiler.FindErrorPosition(
+                                    lineNum, 0, LineMap);
+
+                            int scriptLine = pos.Key;
+                            int col = pos.Value;
+                            if (scriptLine == 0)
+                                scriptLine++;
+                            if (col == 0)
+                                col++;
+                            message = string.Format("Runtime error:\n" +
+                                    "Line ({0}): {1}", scriptLine - 1,
+                                    e.InnerException.Message);
+
+                            return message;
+                        }
+                    }
+                }
+            }
+
+            return message;
+        }
     }
 }
diff --git a/OpenSim/Region/ScriptEngine/DotNetEngine/ScriptManager.cs b/OpenSim/Region/ScriptEngine/DotNetEngine/ScriptManager.cs
index 8329805..1c1dcf3 100644
--- a/OpenSim/Region/ScriptEngine/DotNetEngine/ScriptManager.cs
+++ b/OpenSim/Region/ScriptEngine/DotNetEngine/ScriptManager.cs
@@ -53,6 +53,8 @@ namespace OpenSim.Region.ScriptEngine.DotNetEngine
         public int StartParam;
         public AppDomain AppDomain;
         public Dictionary<string, IScriptApi> Apis;
+        public Dictionary<KeyValuePair<int,int>, KeyValuePair<int,int>>
+                LineMap;
     }
 
     public class ScriptManager
@@ -159,6 +161,7 @@ namespace OpenSim.Region.ScriptEngine.DotNetEngine
                         m_scriptEngine.m_AppDomainManager.LoadScript(
                         CompiledScriptFile, out id.AppDomain);
 
+                id.LineMap = LSLCompiler.LineMap();
                 id.Script = CompiledScript;
                 id.Source = Script;
                 id.StartParam = startParam;
@@ -212,7 +215,7 @@ namespace OpenSim.Region.ScriptEngine.DotNetEngine
                 try
                 {
                     // DISPLAY ERROR INWORLD
-                    string text = "Error compiling script:\r\n" +
+                    string text = "Error compiling script:\n" +
                             e.Message.ToString();
                     if (text.Length > 1100)
                         text = text.Substring(0, 1099);