diff options
author | Justin Clark-Casey (justincc) | 2012-06-28 00:58:36 +0100 |
---|---|---|
committer | Justin Clark-Casey (justincc) | 2012-06-28 01:01:18 +0100 |
commit | 25baa2d894e9bbbb173eb4e6ebe1478d2e3c1265 (patch) | |
tree | d06e688c8dd97f3d3a81e1868b609e132c96a215 /OpenSim/Region/Framework/ModuleLoader.cs | |
parent | minor: reuse colon index calculation in XEngine.OnRezScript. The index if a ... (diff) | |
download | opensim-SC-25baa2d894e9bbbb173eb4e6ebe1478d2e3c1265.zip opensim-SC-25baa2d894e9bbbb173eb4e6ebe1478d2e3c1265.tar.gz opensim-SC-25baa2d894e9bbbb173eb4e6ebe1478d2e3c1265.tar.bz2 opensim-SC-25baa2d894e9bbbb173eb4e6ebe1478d2e3c1265.tar.xz |
Avoid reporting false positives when a colon is in a comment in the first line of a script where the user was not trying to select a different script engine.
This works by only posting the "Selected engine unavailable" message if we're falling back on XEngine and the language is one handled by XEngine.
In cases where the language is not handled or not allowed, the user will still be notified by the later compiler error.
This avoids the overwhelming majority of false positives where the first line contains a : for other reasons (e.g. source control systems, vim settings, etc.)
Ultimately, I think it would be better to detect script language/engine with a mechanism that didn't just rely on : detection (e.g like #! in unix scripts).
Diffstat (limited to 'OpenSim/Region/Framework/ModuleLoader.cs')
0 files changed, 0 insertions, 0 deletions