Remove the cruft of accessing a private member of another module's class

from DataSnapshot and replace it with a best practices approach, making
it much less dependent on the land module's internal structure and types.

3 files changed, 16 insertions, 0 deletions

diff --git a/OpenSim/Region/Environment/Interfaces/ILandChannel.cs b/OpenSim/Region/Environment/Interfaces/ILandChannel.cs
index 4a74949..98998f7 100644
--- a/OpenSim/Region/Environment/Interfaces/ILandChannel.cs
+++ b/OpenSim/Region/Environment/Interfaces/ILandChannel.cs
@@ -36,6 +36,7 @@ namespace OpenSim.Region.Environment.Interfaces
     {
 
         List<ILandObject> ParcelsNearPoint(Vector3 position);
+        List<ILandObject> AllParcels();
         ILandObject GetLandObject(int x, int y);
         ILandObject GetLandObject(float x, float y);
         bool IsLandPrimCountTainted();
diff --git a/OpenSim/Region/Environment/Modules/World/Land/LandChannel.cs b/OpenSim/Region/Environment/Modules/World/Land/LandChannel.cs
index 1e1291a..8747bd4 100644
--- a/OpenSim/Region/Environment/Modules/World/Land/LandChannel.cs
+++ b/OpenSim/Region/Environment/Modules/World/Land/LandChannel.cs
@@ -105,6 +105,16 @@ namespace OpenSim.Region.Environment.Modules.World.Land
             return obj;
         }
 
+        public List<ILandObject> AllParcels()
+        {
+            if (m_landManagementModule != null)
+            {
+                return m_landManagementModule.AllParcels();
+            }
+
+            return new List<ILandObject>();
+        }
+
         public List<ILandObject> ParcelsNearPoint(Vector3 position)
         {
             if (m_landManagementModule != null)
diff --git a/OpenSim/Region/Environment/Modules/World/Land/LandManagementModule.cs b/OpenSim/Region/Environment/Modules/World/Land/LandManagementModule.cs
index f4ba9a3..bf51edb 100644
--- a/OpenSim/Region/Environment/Modules/World/Land/LandManagementModule.cs
+++ b/OpenSim/Region/Environment/Modules/World/Land/LandManagementModule.cs
@@ -175,6 +175,11 @@ namespace OpenSim.Region.Environment.Modules.World.Land
             AddLandObject(fullSimParcel);
         }
 
+        public List<ILandObject> AllParcels()
+        {
+            return new List<ILandObject>(landList.Values);
+        }
+
         public List<ILandObject> ParcelsNearPoint(Vector3 position)
         {
             List<ILandObject> parcelsNear = new List<ILandObject>();