Merge branch 'master' into careminster-presence-refactor

Integrate the next large patch.
Don't use this version, it has a ghost avatar issue. Next push
will fix it.

5 files changed, 10 insertions, 30 deletions

diff --git a/OpenSim/Region/CoreModules/Avatar/Attachments/AttachmentsModule.cs b/OpenSim/Region/CoreModules/Avatar/Attachments/AttachmentsModule.cs
index 7c95658..6f7256e 100644
--- a/OpenSim/Region/CoreModules/Avatar/Attachments/AttachmentsModule.cs
+++ b/OpenSim/Region/CoreModules/Avatar/Attachments/AttachmentsModule.cs
@@ -586,13 +586,9 @@ namespace OpenSim.Region.CoreModules.Avatar.Attachments
             so.RootPart.AttachedAvatar = avatar.UUID;
 
             //Anakin Lohner bug #3839 
-            lock (so.Children)
-            {
-                foreach (SceneObjectPart p in so.Children.Values)
-                {
-                    p.AttachedAvatar = avatar.UUID;
-                }
-            }
+            SceneObjectPart[] parts = so.Parts;
+            for (int i = 0; i < parts.Length; i++)
+                parts[i].AttachedAvatar = avatar.UUID;
 
             if (so.RootPart.PhysActor != null)
             {
diff --git a/OpenSim/Region/CoreModules/Framework/InventoryAccess/InventoryAccessModule.cs b/OpenSim/Region/CoreModules/Framework/InventoryAccess/InventoryAccessModule.cs
index a2ba498..42e3359 100644
--- a/OpenSim/Region/CoreModules/Framework/InventoryAccess/InventoryAccessModule.cs
+++ b/OpenSim/Region/CoreModules/Framework/InventoryAccess/InventoryAccessModule.cs
@@ -544,7 +544,7 @@ namespace OpenSim.Region.CoreModules.Framework.InventoryAccess
                     if (!attachment)
                     {
                         group.RootPart.CreateSelected = true;
-                        foreach (SceneObjectPart child in group.Children.Values)
+                        foreach (SceneObjectPart child in group.Parts)
                             child.CreateSelected = true;
                     }
 
@@ -629,10 +629,6 @@ namespace OpenSim.Region.CoreModules.Framework.InventoryAccess
                     rootPart.Name = item.Name;
                     rootPart.Description = item.Description;
 
-                    List<SceneObjectPart> partList = null;
-                    lock (group.Children)
-                        partList = new List<SceneObjectPart>(group.Children.Values);
-
                     group.SetGroup(remoteClient.ActiveGroupId, remoteClient);
                     if ((rootPart.OwnerID != item.Owner) || (item.CurrentPermissions & 16) != 0)
                     {
@@ -642,7 +638,7 @@ namespace OpenSim.Region.CoreModules.Framework.InventoryAccess
 
                         if (m_Scene.Permissions.PropagatePermissions())
                         {
-                            foreach (SceneObjectPart part in partList)
+                            foreach (SceneObjectPart part in group.Parts)
                             {
                                 part.EveryoneMask = item.EveryOnePermissions;
                                 part.NextOwnerMask = item.NextPermissions;
@@ -656,7 +652,8 @@ namespace OpenSim.Region.CoreModules.Framework.InventoryAccess
                     {
                         m_log.Debug("[InventoryAccessModule]: Inventory object has UUID.Zero! Position 8");
                     }
-                    foreach (SceneObjectPart part in partList)
+
+                    foreach (SceneObjectPart part in group.Parts)
                     {
                         if ((part.OwnerID != item.Owner) || (item.CurrentPermissions & 16) != 0)
                         {
diff --git a/OpenSim/Region/CoreModules/World/Archiver/ArchiveReadRequest.cs b/OpenSim/Region/CoreModules/World/Archiver/ArchiveReadRequest.cs
index e51f118..4af7a1b 100644
--- a/OpenSim/Region/CoreModules/World/Archiver/ArchiveReadRequest.cs
+++ b/OpenSim/Region/CoreModules/World/Archiver/ArchiveReadRequest.cs
@@ -243,11 +243,7 @@ namespace OpenSim.Region.CoreModules.World.Archiver
                 // to the same scene (when this is possible).
                 sceneObject.ResetIDs();
 
-                List<SceneObjectPart> partList = null;
-                lock (sceneObject.Children)
-                    partList = new List<SceneObjectPart>(sceneObject.Children.Values);
-                
-                foreach (SceneObjectPart part in partList)
+                foreach (SceneObjectPart part in sceneObject.Parts)
                 {
                     if (!ResolveUserUuid(part.CreatorID))
                         part.CreatorID = m_scene.RegionInfo.EstateSettings.EstateOwner;
diff --git a/OpenSim/Region/CoreModules/World/Objects/BuySell/BuySellModule.cs b/OpenSim/Region/CoreModules/World/Objects/BuySell/BuySellModule.cs
index db50339..d91c36c 100644
--- a/OpenSim/Region/CoreModules/World/Objects/BuySell/BuySellModule.cs
+++ b/OpenSim/Region/CoreModules/World/Objects/BuySell/BuySellModule.cs
@@ -128,14 +128,9 @@ namespace OpenSim.Region.CoreModules.World.Objects.BuySell
                 group.SetOwnerId(remoteClient.AgentId);
                 group.SetRootPartOwner(part, remoteClient.AgentId, remoteClient.ActiveGroupId);
 
-                List<SceneObjectPart> partList = null;
-                
-                lock (group.Children)
-                    partList = new List<SceneObjectPart>(group.Children.Values);
-
                 if (m_scene.Permissions.PropagatePermissions())
                 {
-                    foreach (SceneObjectPart child in partList)
+                    foreach (SceneObjectPart child in group.Parts)
                     {
                         child.Inventory.ChangeInventoryOwner(remoteClient.AgentId);
                         child.TriggerScriptChangedEvent(Changed.OWNER);
diff --git a/OpenSim/Region/CoreModules/World/WorldMap/MapImageModule.cs b/OpenSim/Region/CoreModules/World/WorldMap/MapImageModule.cs
index 1bd1371..c83ac85 100644
--- a/OpenSim/Region/CoreModules/World/WorldMap/MapImageModule.cs
+++ b/OpenSim/Region/CoreModules/World/WorldMap/MapImageModule.cs
@@ -229,11 +229,7 @@ namespace OpenSim.Region.CoreModules.World.WorldMap
                         Color mapdotspot = Color.Gray; // Default color when prim color is white
                         
                         // Loop over prim in group
-                        List<SceneObjectPart> partList = null;
-                        lock (mapdot.Children)
-                            partList = new List<SceneObjectPart>(mapdot.Children.Values);
-                            
-                        foreach (SceneObjectPart part in partList)
+                        foreach (SceneObjectPart part in mapdot.Parts)
                         {
                             if (part == null)
                                 continue;