Fixed SimpleApp - aka thankgoditssundaycommit

* Updated SimpleApp with various introduced dependencies
* Extracted ScenePrescence creation in Scene
* removed try-catchall from UserManagerBase (that actually hid a bug)
* Refactored RegionInfo
  * handle is calculated
  * it will explode upon accessing x,y,ip,port,externalip if not explicitly initialized
* Removed superfluous 'ref' keywords
* Removed a shitload of 'catch Exception e' that causes build warnings
* Lots of small refactorings, renames et c
* Ignored some bins

2 files changed, 5 insertions, 5 deletions

diff --git a/OpenSim/Grid/GridServer/GridManager.cs b/OpenSim/Grid/GridServer/GridManager.cs
index c78d14a..47f7d00 100644
--- a/OpenSim/Grid/GridServer/GridManager.cs
+++ b/OpenSim/Grid/GridServer/GridManager.cs
@@ -108,7 +108,7 @@ namespace OpenSim.Grid.GridServer
                 {

                     kvp.Value.saveLog("Gridserver", target, method, args, priority, message);

                 }

-                catch (Exception e)

+                catch (Exception)

                 {

                     OpenSim.Framework.Console.MainLog.Instance.Warn("Storage: unable to write log via " + kvp.Key);

                 }

@@ -127,7 +127,7 @@ namespace OpenSim.Grid.GridServer
                 {

                     return kvp.Value.GetProfileByLLUUID(uuid);

                 }

-                catch (Exception e)

+                catch (Exception)

                 {

                     OpenSim.Framework.Console.MainLog.Instance.Warn("Storage: Unable to find region " + uuid.ToStringHyphenated() + " via " + kvp.Key);

                 }

@@ -148,7 +148,7 @@ namespace OpenSim.Grid.GridServer
                 {

                     return kvp.Value.GetProfileByHandle(handle);

                 }

-                catch (Exception e)

+                catch

                 {

                     OpenSim.Framework.Console.MainLog.Instance.Warn("Storage: Unable to find region " + handle.ToString() + " via " + kvp.Key);

                 }

@@ -172,7 +172,7 @@ namespace OpenSim.Grid.GridServer
                         regions[neighbour.regionHandle] = neighbour;

                     }

                 }

-                catch (Exception e)

+                catch

                 {

                     OpenSim.Framework.Console.MainLog.Instance.Warn("Storage: Unable to query regionblock via " + kvp.Key);

                 }

diff --git a/OpenSim/Grid/GridServer/Main.cs b/OpenSim/Grid/GridServer/Main.cs
index b225214..5ac64b2 100644
--- a/OpenSim/Grid/GridServer/Main.cs
+++ b/OpenSim/Grid/GridServer/Main.cs
@@ -262,7 +262,7 @@ namespace OpenSim.Grid.GridServer
                 }

                 configData.Commit();

             }

-            catch (Exception e)

+            catch

             {

 

             }