* Catch the occasional resolution exception that comes out of SceneCommunicationService.EnableChildAgents so we can see what hostname is failing

2 files changed, 17 insertions, 2 deletions

diff --git a/OpenSim/Framework/Communications/IGridServices.cs b/OpenSim/Framework/Communications/IGridServices.cs
index daa43ac..9e34672 100644
--- a/OpenSim/Framework/Communications/IGridServices.cs
+++ b/OpenSim/Framework/Communications/IGridServices.cs
@@ -41,7 +41,15 @@ namespace OpenSim.Framework.Communications
         RegionCommsListener RegisterRegion(RegionInfo regionInfos);
         
         bool DeregisterRegion(RegionInfo regionInfo);
+
+        /// <summary>
+        /// Get information about the regions neighbouring the given co-ordinates.
+        /// </summary>
+        /// <param name="x"></param>
+        /// <param name="y"></param>
+        /// <returns></returns>
         List<SimpleRegionInfo> RequestNeighbours(uint x, uint y);
+        
         RegionInfo RequestNeighbourInfo(ulong regionHandle);
         RegionInfo RequestClosestRegion(string regionName);
         Dictionary<string, string> GetGridSettings();
diff --git a/OpenSim/Framework/RegionInfo.cs b/OpenSim/Framework/RegionInfo.cs
index 76ae1ba..b5d6869 100644
--- a/OpenSim/Framework/RegionInfo.cs
+++ b/OpenSim/Framework/RegionInfo.cs
@@ -38,6 +38,9 @@ namespace OpenSim.Framework
     [Serializable]
     public class SimpleRegionInfo
     {
+//        private static readonly log4net.ILog m_log 
+//            = log4net.LogManager.GetLogger(System.Reflection.MethodBase.GetCurrentMethod().DeclaringType);
+        
         public SimpleRegionInfo()
         {
         }
@@ -100,6 +103,11 @@ namespace OpenSim.Framework
 
         public string RemotingAddress;
 
+        /// <value>
+        /// This accessor can throw all the exceptions that Dns.GetHostAddresses can throw.
+        /// 
+        /// XXX Isn't this really doing too much to be a simple getter, rather than an explict method?
+        /// </value>
         public IPEndPoint ExternalEndPoint
         {
             get
@@ -114,8 +122,7 @@ namespace OpenSim.Framework
 
                 // Reset for next check
                 ia = null;
-
-                // New method favors IPv4
+                                                         
                 foreach (IPAddress Adr in Dns.GetHostAddresses(m_externalHostName))
                 {
                     if (ia == null)