* Mother of all commits:

* Cleaned up copyright notices in AssemblyInfo.cs's
* Added Copyright headers to a bunch of files missing them
* Replaced several common string instances with a static constant to prevent reallocation of the same strings thousands of times. "" -> String.Empty is the first such candidate.

5 files changed, 32 insertions, 29 deletions

diff --git a/OpenSim/Framework/Communications/Capabilities/Caps.cs b/OpenSim/Framework/Communications/Capabilities/Caps.cs
index 74d8125..f85b4ab 100644
--- a/OpenSim/Framework/Communications/Capabilities/Caps.cs
+++ b/OpenSim/Framework/Communications/Capabilities/Caps.cs
@@ -197,7 +197,7 @@ namespace OpenSim.Region.Capabilities
         {
             Console.WriteLine("texture request " + request);
             // Needs implementing (added to remove compiler warning)
-            return "";
+            return String.Empty;
         }
 
         #region EventQueue (Currently not enabled)
@@ -211,7 +211,7 @@ namespace OpenSim.Region.Capabilities
         /// <returns></returns>
         public string ProcessEventQueue(string request, string path, string param)
         {
-            string res = "";
+            string res = String.Empty;
 
             if (m_capsEventQueue.Count > 0)
             {
@@ -476,17 +476,17 @@ namespace OpenSim.Region.Capabilities
         {
             public event UpLoadedAsset OnUpLoad;
 
-            private string uploaderPath = "";
+            private string uploaderPath = String.Empty;
             private LLUUID newAssetID;
             private LLUUID inventoryItemID;
             private LLUUID parentFolder;
             private BaseHttpServer httpListener;
             private bool m_dumpAssetsToFile;
-            private string m_assetName = "";
-            private string m_assetDes = "";
+            private string m_assetName = String.Empty;
+            private string m_assetDes = String.Empty;
 
-            private string m_invType = "";
-            private string m_assetType = "";
+            private string m_invType = String.Empty;
+            private string m_assetType = String.Empty;
 
             public AssetUploader(string assetName, string description, LLUUID assetID, LLUUID inventoryItem,
                                  LLUUID parentFolderID, string invType, string assetType, string path,
@@ -514,7 +514,7 @@ namespace OpenSim.Region.Capabilities
             public string uploaderCaps(byte[] data, string path, string param)
             {
                 LLUUID inv = inventoryItemID;
-                string res = "";
+                string res = String.Empty;
                 LLSDAssetUploadComplete uploadComplete = new LLSDAssetUploadComplete();
                 uploadComplete.new_asset = newAssetID.ToString();
                 uploadComplete.new_inventory_item = inv;
@@ -568,7 +568,7 @@ namespace OpenSim.Region.Capabilities
         {
             public event UpdateItem OnUpLoad;
 
-            private string uploaderPath = "";
+            private string uploaderPath = String.Empty;
             private LLUUID inventoryItemID;
             private BaseHttpServer httpListener;
             private bool m_dumpAssetToFile;
@@ -592,7 +592,7 @@ namespace OpenSim.Region.Capabilities
             public string uploaderCaps(byte[] data, string path, string param)
             {
                 LLUUID inv = inventoryItemID;
-                string res = "";
+                string res = String.Empty;
                 LLSDAssetUploadComplete uploadComplete = new LLSDAssetUploadComplete();
                 LLUUID assetID = LLUUID.Zero;
 
@@ -648,7 +648,7 @@ namespace OpenSim.Region.Capabilities
         {
             public event UpdateTaskScript OnUpLoad;
 
-            private string uploaderPath = "";
+            private string uploaderPath = String.Empty;
             private LLUUID inventoryItemID;
             private LLUUID primID;
             private bool isScriptRunning;
@@ -686,7 +686,7 @@ namespace OpenSim.Region.Capabilities
 //                        "TaskInventoryScriptUpdater received data: {0}, path: {1}, param: {2}", 
 //                        data, path, param);
 
-                    string res = "";
+                    string res = String.Empty;
                     LLSDTaskInventoryUploadComplete uploadComplete = new LLSDTaskInventoryUploadComplete();
 
                     if (OnUpLoad != null)
diff --git a/OpenSim/Framework/Communications/Capabilities/LLSDAssetUploadComplete.cs b/OpenSim/Framework/Communications/Capabilities/LLSDAssetUploadComplete.cs
index f838c85..e0afa5c 100644
--- a/OpenSim/Framework/Communications/Capabilities/LLSDAssetUploadComplete.cs
+++ b/OpenSim/Framework/Communications/Capabilities/LLSDAssetUploadComplete.cs
@@ -26,15 +26,16 @@
 * 
 */
 using libsecondlife;
+using System;
 
 namespace OpenSim.Region.Capabilities
 {
     [LLSDType("MAP")]
     public class LLSDAssetUploadComplete
     {
-        public string new_asset = "";
+        public string new_asset = String.Empty;
         public LLUUID new_inventory_item = LLUUID.Zero;
-        public string state = "";
+        public string state = String.Empty;
         //public bool success = false;
 
         public LLSDAssetUploadComplete()
diff --git a/OpenSim/Framework/Communications/Capabilities/LLSDAssetUploadRequest.cs b/OpenSim/Framework/Communications/Capabilities/LLSDAssetUploadRequest.cs
index 7fed27a..e611eea 100644
--- a/OpenSim/Framework/Communications/Capabilities/LLSDAssetUploadRequest.cs
+++ b/OpenSim/Framework/Communications/Capabilities/LLSDAssetUploadRequest.cs
@@ -33,11 +33,11 @@ namespace OpenSim.Region.Capabilities
     [LLSDMap]
     public class LLSDAssetUploadRequest
     {
-        public string asset_type = "";
-        public string description = "";
+        public string asset_type = System.String.Empty;
+        public string description = System.String.Empty;
         public LLUUID folder_id = LLUUID.Zero;
-        public string inventory_type = "";
-        public string name = "";
+        public string inventory_type = System.String.Empty;
+        public string name = System.String.Empty;
 
         public LLSDAssetUploadRequest()
         {
diff --git a/OpenSim/Framework/Communications/Capabilities/LLSDAssetUploadResponse.cs b/OpenSim/Framework/Communications/Capabilities/LLSDAssetUploadResponse.cs
index 3ad618d..7744ffb 100644
--- a/OpenSim/Framework/Communications/Capabilities/LLSDAssetUploadResponse.cs
+++ b/OpenSim/Framework/Communications/Capabilities/LLSDAssetUploadResponse.cs
@@ -31,8 +31,8 @@ namespace OpenSim.Region.Capabilities
     [LLSDMap]
     public class LLSDAssetUploadResponse
     {
-        public string uploader = "";
-        public string state = "";
+        public string uploader = System.String.Empty;
+        public string state = System.String.Empty;
 
         public LLSDAssetUploadResponse()
         {
diff --git a/OpenSim/Framework/Communications/Capabilities/LLSDCapsDetails.cs b/OpenSim/Framework/Communications/Capabilities/LLSDCapsDetails.cs
index 7b09cb3..7006b44 100644
--- a/OpenSim/Framework/Communications/Capabilities/LLSDCapsDetails.cs
+++ b/OpenSim/Framework/Communications/Capabilities/LLSDCapsDetails.cs
@@ -26,20 +26,22 @@
 * 
 */
 
+using System;
+
 namespace OpenSim.Region.Capabilities
 {
     [LLSDType("MAP")]
     public class LLSDCapsDetails
     {
-        public string MapLayer = "";
-        public string NewFileAgentInventory = "";
-        //public string EventQueueGet = "";
-        // public string RequestTextureDownload = "";
-        // public string ChatSessionRequest = "";
-        public string UpdateNotecardAgentInventory = "";
-        public string UpdateScriptAgentInventory = "";
-        public string UpdateScriptTaskInventory = "";
-        // public string ParcelVoiceInfoRequest = "";
+        public string MapLayer = String.Empty;
+        public string NewFileAgentInventory = String.Empty;
+        //public string EventQueueGet = String.Empty;
+        // public string RequestTextureDownload = String.Empty;
+        // public string ChatSessionRequest = String.Empty;
+        public string UpdateNotecardAgentInventory = String.Empty;
+        public string UpdateScriptAgentInventory = String.Empty;
+        public string UpdateScriptTaskInventory = String.Empty;
+        // public string ParcelVoiceInfoRequest = String.Empty;
 
         public LLSDCapsDetails()
         {