5 files changed, 40 insertions, 6 deletions

diff --git a/linden/indra/llvfs/CMakeLists.txt b/linden/indra/llvfs/CMakeLists.txt
index 9f136f7..c3c12ef 100644
--- a/linden/indra/llvfs/CMakeLists.txt
+++ b/linden/indra/llvfs/CMakeLists.txt
@@ -56,3 +56,9 @@ set_source_files_properties(${llvfs_HEADER_FILES}
 list(APPEND llvfs_SOURCE_FILES ${llvfs_HEADER_FILES})
 
 add_library (llvfs ${llvfs_SOURCE_FILES})
+
+if (DARWIN)
+  include(CMakeFindFrameworks)
+  find_library(CARBON_LIBRARY Carbon)
+  target_link_libraries(llvfs ${CARBON_LIBRARY})
+endif (DARWIN)
diff --git a/linden/indra/llvfs/lldir.cpp b/linden/indra/llvfs/lldir.cpp
index 0e014d9..5bfe11f 100644
--- a/linden/indra/llvfs/lldir.cpp
+++ b/linden/indra/llvfs/lldir.cpp
@@ -497,6 +497,29 @@ std::string LLDir::getTempFilename() const
         return temp_filename;
 }
 
+// static
+std::string LLDir::getScrubbedFileName(const std::string uncleanFileName)
+{
+        std::string name(uncleanFileName);
+        const std::string illegalChars(getForbiddenFileChars());
+        // replace any illegal file chars with and underscore '_'
+        for( unsigned int i = 0; i < illegalChars.length(); i++ )
+        {
+                int j = -1;
+                while((j = name.find(illegalChars[i])) > -1)
+                {
+                        name[j] = '_';
+                }
+        }
+        return name;
+}
+
+// static
+std::string LLDir::getForbiddenFileChars()
+{
+        return "\\/:*?\"<>|";
+}
+
 void LLDir::setLindenUserDir(const std::string &first, const std::string &last)
 {
         // if both first and last aren't set, assume we're grabbing the cached dir
diff --git a/linden/indra/llvfs/lldir.h b/linden/indra/llvfs/lldir.h
index dbddf7d..2626d19 100644
--- a/linden/indra/llvfs/lldir.h
+++ b/linden/indra/llvfs/lldir.h
@@ -64,12 +64,12 @@ class LLDir
 
         virtual void initAppDirs(const std::string &app_name) = 0;
  public:        
-         virtual S32 deleteFilesInDir(const std::string &dirname, const std::string &mask);
+        virtual S32 deleteFilesInDir(const std::string &dirname, const std::string &mask);
 
 // pure virtual functions
-         virtual U32 countFilesInDir(const std::string &dirname, const std::string &mask) = 0;
-         virtual BOOL getNextFileInDir(const std::string &dirname, const std::string &mask, std::string &fname, BOOL wrap) = 0;
-         virtual void getRandomFileInDir(const std::string &dirname, const std::string &mask, std::string &fname) = 0;
+        virtual U32 countFilesInDir(const std::string &dirname, const std::string &mask) = 0;
+        virtual BOOL getNextFileInDir(const std::string &dirname, const std::string &mask, std::string &fname, BOOL wrap) = 0;
+        virtual void getRandomFileInDir(const std::string &dirname, const std::string &mask, std::string &fname) = 0;
         virtual std::string getCurPath() = 0;
         virtual BOOL fileExists(const std::string &filename) const = 0;
 
@@ -104,7 +104,7 @@ class LLDir
         std::string getBaseFileName(const std::string& filepath, bool strip_exten = false) const;
         std::string getDirName(const std::string& filepath) const;
         std::string getExtension(const std::string& filepath) const; // Excludes '.', e.g getExtension("foo.wav") == "wav"
-        
+
         // these methods search the various skin paths for the specified file in the following order:
         // getUserSkinDir(), getSkinDir(), getDefaultSkinDir()
         std::string findSkinnedFilename(const std::string &filename) const;
@@ -114,6 +114,10 @@ class LLDir
         // random filename in common temporary directory
         std::string getTempFilename() const;
 
+        // For producing safe download file names from potentially unsafe ones
+        static std::string getScrubbedFileName(const std::string uncleanFileName);
+        static std::string getForbiddenFileChars();
+
         virtual void setChatLogsDir(const std::string &path);           // Set the chat logs dir to this user's dir
         virtual void setPerAccountChatLogsDir(const std::string &first, const std::string &last);               // Set the per user chat log directory.
         virtual void setLindenUserDir(const std::string &first, const std::string &last);               // Set the linden user dir to this user's dir
diff --git a/linden/indra/llvfs/llvfile.cpp b/linden/indra/llvfs/llvfile.cpp
index 61de885..fbdd738 100644
--- a/linden/indra/llvfs/llvfile.cpp
+++ b/linden/indra/llvfs/llvfile.cpp
@@ -35,6 +35,7 @@
 
 #include "llerror.h"
 #include "llthread.h"
+#include "llstat.h"
 #include "llvfs.h"
 
 const S32 LLVFile::READ                 = 0x00000001;
diff --git a/linden/indra/llvfs/llvfs.cpp b/linden/indra/llvfs/llvfs.cpp
index b3d02a5..82d2723 100644
--- a/linden/indra/llvfs/llvfs.cpp
+++ b/linden/indra/llvfs/llvfs.cpp
@@ -1266,7 +1266,7 @@ void LLVFS::eraseBlockLength(LLVFSBlock *block)
         }
         if(!found_block)
         {
-                llwarns << "eraseBlock could not find block" << llendl;
+                llerrs << "eraseBlock could not find block" << llendl;
         }
 }