1 files changed, 244 insertions, 91 deletions

diff --git a/linden/indra/llmedia/llmediaimplgstreamer.cpp b/linden/indra/llmedia/llmediaimplgstreamer.cpp
index 30706f1..7ae6b02 100644
--- a/linden/indra/llmedia/llmediaimplgstreamer.cpp
+++ b/linden/indra/llmedia/llmediaimplgstreamer.cpp
@@ -30,23 +30,35 @@
  * $/LicenseInfo$
  */
 
-#include "llmediaimplgstreamer.h"
-
 ///#if LL_GSTREAMER_ENABLED
 
+#if LL_WINDOWS
+        // GStreamer 0.10.22 - gstutils.h - conversion from 'guint64' to 'guint8'. 
+        // This was an intentional change to make GStreamer more threadsafe, and
+        // is okay. Delete this bit if GStreamer ever gets more VS-friendly -- McCabe
+        #pragma warning(disable : 4244)
+#endif
+
+#include "linden_common.h"
+#include "llmediaimplgstreamer.h"
+
 extern "C" {
 #include <gst/gst.h>
 #include <gst/gstelement.h>
 }
 
+#if LL_WINDOWS
+        #pragma warning(default : 4244)
+#include <direct.h>
+#include <stdlib.h>
+#endif
+
 #include "llmediamanager.h"
 #include "llmediaimplregister.h"
 
 #include "llmediaimplgstreamervidplug.h"
+#include "llgstplaythread.h"
 
-#include "llmediaimplgstreamer_syms.h"
-
-#include "llerror.h"
 
 // register this impl with media manager factory
 static LLMediaImplRegister sLLMediaImplGStreamerReg( "LLMediaImplGStreamer", new LLMediaImplGStreamerMaker() );
@@ -73,7 +85,8 @@ LLMediaImplGStreamer () :
         mPump ( NULL ),
         mPlaybin ( NULL ),
         mVideoSink ( NULL ),
-    mState( GST_STATE_NULL )
+        mState( GST_STATE_NULL ),
+        mPlayThread ( NULL )
 {
         startup( NULL );  // Startup gstreamer if it hasn't been already.
 
@@ -90,7 +103,7 @@ LLMediaImplGStreamer () :
         }
 
         // instantiate a playbin element to do the hard work
-        mPlaybin = llgst_element_factory_make ("playbin", "play");
+        mPlaybin = gst_element_factory_make ("playbin", "play");
         if (!mPlaybin)
         {
                 // todo: cleanup pump
@@ -104,7 +117,7 @@ LLMediaImplGStreamer () :
 
                 // Plays inworld instead of in external player
                 mVideoSink =
-                GST_SLVIDEO(llgst_element_factory_make ("private-slvideo", "slvideo"));
+                GST_SLVIDEO(gst_element_factory_make ("private-slvideo", "slvideo"));
                 if (!mVideoSink)
                 {
                         LL_WARNS("MediaImpl") << "Could not instantiate private-slvideo element." << LL_ENDL;
@@ -148,7 +161,7 @@ LLMediaImplGStreamer::
 std::string LLMediaImplGStreamer::getVersion()
 {
         guint major, minor, micro, nano;
-        llgst_version(&major, &minor, &micro, &nano);
+        gst_version(&major, &minor, &micro, &nano);
         std::string version = llformat("%d.%d.%d.%d",major,minor,micro,nano);
         return version;
 }
@@ -165,50 +178,163 @@ bool LLMediaImplGStreamer::startup (LLMediaManagerData* init_data)
                 // Init the glib type system - we need it.
                 g_type_init();
 
-                // Get symbols!
-#if LL_WINDOWS
-                if (! grab_gst_syms("libgstreamer-0.10.dll", "libgstvideo-0.10.dll", "libgstaudio-0.10.dll") )
-                {
-                    LL_WARNS("MediaImpl") << "Couldn't find suitable GStreamer 0.10 support on this system - video playback disabled." << LL_ENDL;
-                        return false;
-                }
-#else
-                if (! grab_gst_syms("libgstreamer-0.10.so.0", "libgstvideo-0.10.so.0", "libgstaudio-0.10.so.0") )
-                {
-                        LL_WARNS("MediaImpl") << "Couldn't find suitable GStreamer 0.10 support on this system - video playback disabled." << LL_ENDL;
-                        return false;
-                }
-#endif
-                if (llgst_segtrap_set_enabled)
-                        llgst_segtrap_set_enabled(FALSE);
-                else
-                {
-                    LL_WARNS("MediaImpl") << "gst_segtrap_set_enabled() is not available; Automated crash-reporter may cease to function until next restart." << LL_ENDL;
-                }
+                set_gst_plugin_path();
 
                 // Protect against GStreamer resetting the locale, yuck.
                 static std::string saved_locale;
                 saved_locale = setlocale(LC_ALL, NULL);
-                if (0 == llgst_init_check(NULL, NULL, NULL))
+                if (0 == gst_init_check(NULL, NULL, NULL))
                 {
                     LL_WARNS("MediaImpl") << "GStreamer library failed to initialize and load standard plugins." << LL_ENDL;
                         setlocale(LC_ALL, saved_locale.c_str() );
                         return false;
                 }
                 setlocale(LC_ALL, saved_locale.c_str() );
-                
+
+                // Set up logging facilities
+                gst_debug_remove_log_function( gst_debug_log_default );
+                gst_debug_add_log_function( gstreamer_log, NULL );
+
                 // Init our custom plugins - only really need do this once.
                 gst_slvideo_init_class();
 
+
+                // List the plugins GStreamer can find
+                LL_DEBUGS("MediaImpl") << "Found GStreamer plugins:" << LL_ENDL;
+                GList *list;
+                GstRegistry *registry = gst_registry_get_default();
+                std::string loaded = "";
+                for (list = gst_registry_get_plugin_list(registry);
+                     list != NULL;
+                     list = g_list_next(list))
+                {        
+                        GstPlugin *list_plugin = (GstPlugin *)list->data;
+                        (bool)gst_plugin_is_loaded(list_plugin) ? loaded = "Yes" : loaded = "No";
+                        LL_DEBUGS("MediaImpl") << gst_plugin_get_name(list_plugin) << ", loaded? " << loaded << LL_ENDL;
+                }
+                gst_plugin_list_free(list);
+
+
                 done_init = true;
         }
         return true;
 }
 
 
+void LLMediaImplGStreamer::set_gst_plugin_path()
+{
+        // Only needed for Windows.
+        // Linux sets in wrapper.sh, Mac sets in Info-Imprudence.plist
+#ifdef LL_WINDOWS
+
+        char* imp_cwd;
+
+        // Get the current working directory: 
+        imp_cwd = _getcwd(NULL,0);
+
+        if(imp_cwd == NULL)
+        {
+                LL_DEBUGS("MediaImpl") << "_getcwd failed, not setting GST_PLUGIN_PATH."
+                                         << LL_ENDL;
+        }
+        else
+        {
+                LL_DEBUGS("MediaImpl") << "Imprudence is installed at "
+                                         << imp_cwd << LL_ENDL;
+
+                // Grab the current path, if it's set.
+                std::string old_plugin_path = "";
+                char *old_path = getenv("GST_PLUGIN_PATH");
+                if(old_path == NULL)
+                {
+                        LL_DEBUGS("MediaImpl") << "Did not find user-set GST_PLUGIN_PATH."
+                                                 << LL_ENDL;
+                }
+                else
+                {
+                        old_plugin_path = ";" + std::string( old_path );
+                }
+
+
+                // Search both Imprudence and Imprudence\lib\gstreamer-plugins.
+                // If those fail, search the path the user has set, if any.
+                std::string plugin_path =
+                  "GST_PLUGIN_PATH=" +
+                  std::string(imp_cwd) + "\\lib\\gstreamer-plugins;" +
+                  std::string(imp_cwd) +
+                  old_plugin_path;
+
+                // Place GST_PLUGIN_PATH in the environment settings for imprudence.exe
+                // Returns 0 on success
+                if(_putenv( (char*)plugin_path.c_str() ))
+                {       
+                        LL_WARNS("MediaImpl") << "Setting environment variable failed!" << LL_ENDL;
+                }
+                else
+                {
+                        LL_DEBUGS("MediaImpl") << "GST_PLUGIN_PATH set to "
+                                                                         << getenv("GST_PLUGIN_PATH") << LL_ENDL;
+                }
+        }
+
+#endif //LL_WINDOWS
+}
+
+
+void LLMediaImplGStreamer::gstreamer_log(GstDebugCategory *category,
+                                         GstDebugLevel level,
+                                         const gchar *file,
+                                         const gchar *function,
+                                         gint line,
+                                         GObject *object,
+                                         GstDebugMessage *message,
+                                         gpointer data)
+{
+        std::stringstream log(std::stringstream::out);
+
+        // Log format example:
+        // 
+        // GST_ELEMENT_PADS: removing pad 'sink' (in gstelement.c:757:gst_element_remove_pad)
+        // 
+        log << gst_debug_category_get_name( category ) << ": "
+            << gst_debug_message_get(message) << " "
+            << "(in " << file << ":" << line << ":" << function << ")";
+
+        switch( level )
+        {
+                case GST_LEVEL_ERROR:
+                        LL_ERRS("MediaImpl") << log.str() << LL_ENDL;
+                        break;
+                case GST_LEVEL_WARNING:
+                        LL_WARNS("MediaImpl") << log.str() << LL_ENDL;
+                        break;
+                case GST_LEVEL_DEBUG:
+                        LL_DEBUGS("MediaImpl") << log.str() << LL_ENDL;
+                        break;
+                case GST_LEVEL_INFO:
+                        LL_INFOS("MediaImpl") << log.str() << LL_ENDL;
+                        break;
+                default:
+                        // Do nothing.
+                        break;
+        }
+}
+
+
 bool LLMediaImplGStreamer::closedown()
 {
-        ungrab_gst_syms();
+        return true;
+}
+
+
+bool LLMediaImplGStreamer::setDebugLevel( LLMediaBase::EDebugLevel level )
+{
+        // Do parent class stuff.
+        LLMediaImplCommon::setDebugLevel(level);
+
+        // Set GStreamer verbosity.
+        gst_debug_set_default_threshold( (GstDebugLevel)level );
+
         return true;
 }
 
@@ -236,7 +362,7 @@ static const char* get_gst_state_name(GstState state)
 gboolean LLMediaImplGStreamer::bus_callback(GstBus *bus, GstMessage *message, gpointer data)
 {
 #ifdef LL_GST_REPORT_STATE_CHANGES
-        LL_DEBUGS("MediaCallback") << "Got GST message type: " << LLGST_MESSAGE_TYPE_NAME (message) << LL_ENDL;
+        LL_DEBUGS("MediaCallback") << "Got GST message type: " << GST_MESSAGE_TYPE_NAME (message) << LL_ENDL;
 #endif
 
         LLMediaImplGStreamer *impl = (LLMediaImplGStreamer*)data;
@@ -245,17 +371,13 @@ gboolean LLMediaImplGStreamer::bus_callback(GstBus *bus, GstMessage *message, gp
         {
                 case GST_MESSAGE_BUFFERING: 
                 {
-                        // NEEDS GST 0.10.11+
-                        if (llgst_message_parse_buffering)
-                        {
-                                gint percent = 0;
-                                llgst_message_parse_buffering(message, &percent);
+                        gint percent = 0;
+                        gst_message_parse_buffering(message, &percent);
 #ifdef LL_GST_REPORT_STATE_CHANGES
-                                LL_DEBUGS("MediaBuffering") << "GST buffering: " << percent << "%%" << LL_ENDL;
+                        LL_DEBUGS("MediaBuffering") << "GST buffering: " << percent << "%%" << LL_ENDL;
 #endif
-                                LLMediaEvent event( impl, percent );
-                                impl->getEventEmitter().update( &LLMediaObserver::onUpdateProgress, event );
-                        }
+                        LLMediaEvent event( impl, percent );
+                        impl->getEventEmitter().update( &LLMediaObserver::onUpdateProgress, event );
                 }
                         break;
                 case GST_MESSAGE_STATE_CHANGED: 
@@ -263,7 +385,7 @@ gboolean LLMediaImplGStreamer::bus_callback(GstBus *bus, GstMessage *message, gp
                         GstState old_state;
                         GstState new_state;
                         GstState pending_state;
-                        llgst_message_parse_state_changed(message,
+                        gst_message_parse_state_changed(message,
                                                 &old_state,
                                                 &new_state,
                                                 &pending_state);
@@ -308,7 +430,7 @@ gboolean LLMediaImplGStreamer::bus_callback(GstBus *bus, GstMessage *message, gp
                         GError *err = NULL;
                         gchar *debug = NULL;
 
-                        llgst_message_parse_error (message, &err, &debug);
+                        gst_message_parse_error (message, &err, &debug);
                         LL_WARNS("MediaImpl") << "GST Error: " << err->message << LL_ENDL;
                         g_error_free (err);
                         g_free (debug);
@@ -320,17 +442,14 @@ gboolean LLMediaImplGStreamer::bus_callback(GstBus *bus, GstMessage *message, gp
                 }
                 case GST_MESSAGE_INFO: 
                 {
-                        if (llgst_message_parse_info)
-                        {
-                                GError *err = NULL;
-                                gchar *debug = NULL;
+                        GError *err = NULL;
+                        gchar *debug = NULL;
                         
-                                llgst_message_parse_info (message, &err, &debug);
-                                LL_INFOS("MediaImpl") << "GST info: " << err->message
-                            << LL_ENDL;
-                                g_error_free (err);
-                                g_free (debug);
-                        }
+                        gst_message_parse_info (message, &err, &debug);
+                        LL_INFOS("MediaImpl") << "GST info: " << err->message
+                                                                                                                << LL_ENDL;
+                        g_error_free (err);
+                        g_free (debug);
                         break;
                 }
                 case GST_MESSAGE_WARNING: 
@@ -338,7 +457,7 @@ gboolean LLMediaImplGStreamer::bus_callback(GstBus *bus, GstMessage *message, gp
                         GError *err = NULL;
                         gchar *debug = NULL;
 
-                        llgst_message_parse_warning (message, &err, &debug);
+                        gst_message_parse_warning (message, &err, &debug);
                         LL_WARNS("MediaImpl") << "GST warning: " <<  err->message
                     << LL_ENDL;
                         g_error_free (err);
@@ -351,10 +470,10 @@ gboolean LLMediaImplGStreamer::bus_callback(GstBus *bus, GstMessage *message, gp
                 GstTagList *tag_list;
                 gchar *title;
                 gchar *artist;
-                llgst_message_parse_tag(message, &tag_list);
-                gboolean hazTitle = llgst_tag_list_get_string(tag_list,
+                gst_message_parse_tag(message, &tag_list);
+                gboolean hazTitle = gst_tag_list_get_string(tag_list,
                         GST_TAG_TITLE, &title);
-                gboolean hazArtist = llgst_tag_list_get_string(tag_list,
+                gboolean hazArtist = gst_tag_list_get_string(tag_list,
                         GST_TAG_ARTIST, &artist);
                 if(hazTitle) 
                         LL_INFOS("MediaInfo") << "Title: " << title << LL_ENDL;
@@ -408,13 +527,13 @@ bool LLMediaImplGStreamer::navigateTo (const std::string urlIn)
         g_object_set (G_OBJECT (mPlaybin), "uri", urlIn.c_str(), NULL);
 
         // get playbin's bus - perhaps this can/should be done in ctor
-        GstBus *bus = llgst_pipeline_get_bus (GST_PIPELINE (mPlaybin));
+        GstBus *bus = gst_pipeline_get_bus (GST_PIPELINE (mPlaybin));
         if (!bus)
         {
                 return false;
         }
-        llgst_bus_add_watch (bus, bus_callback, this);
-        llgst_object_unref (bus);
+        gst_bus_add_watch (bus, bus_callback, this);
+        gst_object_unref (bus);
 
         mState = GST_STATE_READY;
 
@@ -431,9 +550,9 @@ bool LLMediaImplGStreamer::unload()
         LL_DEBUGS("MediaImpl") << "unloading media..." << LL_ENDL;
         if (mPlaybin)
         {
-                llgst_element_set_state (mPlaybin, GST_STATE_NULL);
+                gst_element_set_state (mPlaybin, GST_STATE_NULL);
                 mState = GST_STATE_NULL;
-                llgst_object_unref (GST_OBJECT (mPlaybin));
+                gst_object_unref (GST_OBJECT (mPlaybin));
                 mPlaybin = NULL;
         }
 
@@ -591,20 +710,23 @@ bool LLMediaImplGStreamer::stop()
         if (!mPlaybin || mState == GST_STATE_NULL)
                 return true;
 
-        GstElement *pipeline = (GstElement *)llgst_object_ref(GST_OBJECT(mPlaybin));
-        llgst_object_unref(pipeline);
-        
-        llgst_element_set_state(pipeline, GST_STATE_READY);
+        GstStateChangeReturn state_change;
 
-        if (mState == GST_STATE_PLAYING)
-                mState = GST_STATE_VOID_PENDING;
-        else
-                mState = GST_STATE_READY; 
+        state_change = gst_element_set_state(mPlaybin, GST_STATE_READY);
 
-        GstStateChangeReturn state_change = llgst_element_get_state(mPlaybin, NULL, NULL, GST_CLOCK_TIME_NONE);
-        LL_DEBUGS("MediaImpl") << "get_state: " << llgst_element_state_change_return_get_name(state_change) << LL_ENDL;
+        LL_DEBUGS("MediaImpl") << gst_element_state_change_return_get_name(state_change) << LL_ENDL;
 
-        return true;
+        if (state_change == GST_STATE_CHANGE_FAILURE)
+        {
+                LL_WARNS("MediaImpl") << "could not stop stream!" << LL_ENDL;
+                return false;
+        }
+        else
+        {
+                // Going into pending after play keeps dead streams from looping
+                (mState == GST_STATE_PLAYING) ? (mState = GST_STATE_VOID_PENDING) : (mState = GST_STATE_READY);
+                return true;
+        }
 }
 
 ///////////////////////////////////////////////////////////////////////////////
@@ -616,25 +738,47 @@ bool LLMediaImplGStreamer::play()
         if (!mPlaybin || mState == GST_STATE_NULL)
                 return true;
 
-        GstElement *pipeline = (GstElement *)llgst_object_ref(GST_OBJECT(mPlaybin));
-        llgst_object_unref(pipeline);
+        // Clean up the existing thread, if any.
+        if( mPlayThread != NULL && mPlayThread->isStopped())
+        {
+                delete mPlayThread;
+                mPlayThread = NULL;
+        }
+
+        if( mPlayThread == NULL )
+        {
+                // Make a new thread to start playing. This keeps the viewer
+                // responsive while the stream is resolved and buffered.
+                mPlayThread = new LLGstPlayThread( (LLMediaImplCommon *)this, "GstPlayThread", NULL);
+                mPlayThread->start();
+        }
+
+        return true;
+}
+
+
+void LLMediaImplGStreamer::startPlay()
+{
+        GstElement *pipeline = (GstElement *)gst_object_ref(GST_OBJECT(mPlaybin));
+        gst_object_unref(pipeline);
         
-        llgst_element_set_state(pipeline, GST_STATE_PLAYING);
+        GstStateChangeReturn state_change;
+
+        state_change = gst_element_set_state(mPlaybin, GST_STATE_PLAYING);
         mState = GST_STATE_PLAYING;
-        /*llgst_element_set_state(mPlaybin, GST_STATE_PLAYING);
-        mState = GST_STATE_PLAYING;*/
 
-        GstStateChangeReturn state_change = llgst_element_get_state(mPlaybin, NULL, NULL, GST_CLOCK_TIME_NONE);
-        LL_DEBUGS("MediaImpl") << "get_state: " << llgst_element_state_change_return_get_name(state_change) << LL_ENDL;
+        LL_DEBUGS("MediaImpl") << gst_element_state_change_return_get_name(state_change) << LL_ENDL;
 
         // Check to make sure playing was successful. If not, stop.
+        // NOTE: state_change is almost always GST_STATE_CHANGE_ASYNC
         if (state_change == GST_STATE_CHANGE_FAILURE)
         {
-                setStatus(LLMediaBase::STATUS_STOPPED);
+                // If failing from a bad stream, go into an unknown
+                // state to stop bus_callback from looping back. 
+                // We also force a stop in case the operations don't sync
+                setStatus(LLMediaBase::STATUS_UNKNOWN);
                 stop();
         }
-
-        return true;
 }
 
 ///////////////////////////////////////////////////////////////////////////////
@@ -646,13 +790,22 @@ bool LLMediaImplGStreamer::pause()
         if (!mPlaybin || mState == GST_STATE_NULL)
                 return true;
 
-        llgst_element_set_state(mPlaybin, GST_STATE_PAUSED);
-        mState = GST_STATE_PAUSED;
-        
-        GstStateChangeReturn state_change = llgst_element_get_state(mPlaybin, NULL, NULL, GST_CLOCK_TIME_NONE);
-        LL_DEBUGS("MediaImpl") << "get_state: " << llgst_element_state_change_return_get_name(state_change) << LL_ENDL;
+        GstStateChangeReturn state_change;
 
-        return true;
+        state_change = gst_element_set_state(mPlaybin, GST_STATE_PAUSED);
+
+        LL_DEBUGS("MediaImpl") << gst_element_state_change_return_get_name(state_change) << LL_ENDL;
+
+        if (state_change == GST_STATE_CHANGE_FAILURE)
+        {
+                LL_WARNS("MediaImpl") << "could not pause stream!" << LL_ENDL;
+                return false;
+        }
+        else
+        {
+                mState = GST_STATE_PAUSED;
+                return true;
+        }
 };
 
 
@@ -671,7 +824,7 @@ bool LLMediaImplGStreamer::seek(double time)
         bool success = false;
         if (mPlaybin)
         {
-                success = llgst_element_seek(mPlaybin, 1.0F, GST_FORMAT_TIME,
+                success = gst_element_seek(mPlaybin, 1.0F, GST_FORMAT_TIME,
                                 GstSeekFlags(GST_SEEK_FLAG_FLUSH |
                                              GST_SEEK_FLAG_KEY_UNIT),
                                 GST_SEEK_TYPE_SET, gint64(time*1000000000.0F),