revamp the voice client.

* split the "voice" debug tag into several tags for usable filtering while debugging
* remove debug-spam from user view by:
  * remove capability request spam by:
    * llstartup the voice client state engine when actually a region is present, and not the initial fake region.
    * don't request a capability to determine if (the very same) capability can be requested.
    * don't do it over and over as if a capability rezzed in like an avatar. Its available - or not (see llstartup).
* unload the daemon if not used.
* load vivox daemon depending on specific criteria in the caps
* remove the partial implementation to load a specific daemon with via the openregion message or the login response.
* discard obsolete caps.

Tested and working on linux: Parcel changing, region changing, (SL) voice-disabled region private call, (SL) private call region changing,  (OS) no voice <-> voice region changing, (OS) mumble <-> freeswitch region changing.
To test: Mac, Win. Anything that needs to be tested and not mentioned above.

1 files changed, 7 insertions, 5 deletions

diff --git a/linden/indra/newview/llstartup.cpp b/linden/indra/newview/llstartup.cpp
index e29dc5a..b80a286 100644
--- a/linden/indra/newview/llstartup.cpp
+++ b/linden/indra/newview/llstartup.cpp
@@ -1884,8 +1884,7 @@ bool idle_startup()
                         tmp = LLUserAuth::getInstance()->getResponse("max-agent-groups");
                         if (!tmp.empty()) gHippoGridManager->getConnectedGrid()->setMaxAgentGroups(atoi(tmp.c_str()));
 
-                        tmp = LLUserAuth::getInstance()->getResponse("VoiceConnector");
-                        if (!tmp.empty()) gHippoGridManager->getConnectedGrid()->setVoiceConnector(tmp);
+
                         gHippoGridManager->saveFile();
                         gHippoLimits->setLimits();
 
@@ -1931,8 +1930,7 @@ bool idle_startup()
                         }
                         // else llwarns << "MapServerURL empty"<< llendl;
 
-                        // Pass the user information to the voice chat server interface.
-                        gVoiceClient->userAuthorized(firstname, lastname, gAgentID);
+
                 }
                 else // if(successful_login)
                 {
@@ -2065,6 +2063,7 @@ bool idle_startup()
                 LL_DEBUGS("AppInitStartupState") << "STATE_SEED_CAP_GRANTED" << LL_ENDL;
                 update_texture_fetch();
 
+
                 if ( gViewerWindow != NULL)
                 {       // This isn't the first logon attempt, so show the UI
                         gViewerWindow->setNormalControlsVisible( TRUE );
@@ -2123,6 +2122,9 @@ bool idle_startup()
                 //
                 LL_INFOS("AppInit") << "Initializing communications..." << LL_ENDL;
 
+                // Pass the user information to the voice chat server interface.
+                gVoiceClient->userAuthorized(firstname, lastname, gAgentID);
+
                 // register callbacks for messages. . . do this after initial handshake to make sure that we don't catch any unwanted
                 register_viewer_callbacks(gMessageSystem);
 
@@ -2142,7 +2144,7 @@ bool idle_startup()
                         gCacheName->addObserver(callback_cache_name);
         
                         // Load stored cache if possible
-            LLAppViewer::instance()->loadNameCache();
+                        LLAppViewer::instance()->loadNameCache();
 
                         // Start cache in not-running state until we figure out if we have
                         // capabilities for display name lookup