Merged working branch of 1.2 into LL 1.23 merge

1 files changed, 41 insertions, 9 deletions

diff --git a/linden/indra/newview/llfloatertools.cpp b/linden/indra/newview/llfloatertools.cpp
index 443f684..a37663e 100644
--- a/linden/indra/newview/llfloatertools.cpp
+++ b/linden/indra/newview/llfloatertools.cpp
@@ -663,6 +663,7 @@ void LLFloaterTools::updatePopup(LLCoordGL center, MASK mask)
         if (mBtnLink) mBtnLink->setVisible( edit_visible );
         if (mBtnUnlink) mBtnUnlink->setVisible( edit_visible );
 
+        //TODO: Move these into llselectmgr
         // Check to see if we can link things
         bool can_link = false;
         if (!gSavedSettings.getBOOL("EditLinkedParts"))
@@ -685,14 +686,44 @@ void LLFloaterTools::updatePopup(LLCoordGL center, MASK mask)
 
         // Check to see if we can unlink things
         bool can_unlink = false;
-        if (LLSelectMgr::getInstance()->selectGetAllRootsValid() &&
-                LLSelectMgr::getInstance()->getSelection()->getFirstEditableObject() &&
-                !LLSelectMgr::getInstance()->getSelection()->getFirstEditableObject()->isAttachment())
+        if (tool != LLToolFace::getInstance())
         {
-                if (LLSelectMgr::getInstance()->getSelection()->getRootObjectCount() != 
-                        LLSelectMgr::getInstance()->getSelection()->getObjectCount())
+                if (LLSelectMgr::getInstance()->selectGetAllRootsValid() &&
+                        LLSelectMgr::getInstance()->getSelection()->getFirstEditableObject() &&
+                        !LLSelectMgr::getInstance()->getSelection()->isAttachment())
                 {
-                        can_unlink = true;
+                        // LL's viewer unlinks the last linkset selected, 
+                        // regardless of how many linksets or prims are selected total. 
+                        // Preserve that behavior when enabling the unlink option.  
+                        if (gSavedSettings.getBOOL("EditLinkedParts"))
+                        {
+                                struct f : public LLSelectedNodeFunctor
+                                {
+                                        virtual bool apply(LLSelectNode* pNode)
+                                        {
+                                                // Return the first selection node that is
+                                                //    1) not a root prim
+                                                //    2) or a root prim that has child prims
+                                                // or in other words: any prim that is part of a linkset
+                                                return (pNode->getObject() != pNode->getObject()->getRootEdit()) || 
+                                                                (pNode->getObject()->numChildren() != 0);
+                                        }
+                                } func;
+
+                                if (LLSelectMgr::getInstance()->getSelection()->getFirstRootNode(&func, TRUE))
+                                {
+                                        // the selection contains at least one prim (child or root) that is part of a linkset
+                                        can_unlink = true;
+                                }
+                        }
+                        else
+                        {
+                                if (LLSelectMgr::getInstance()->getSelection()->getRootObjectCount() != 
+                                        LLSelectMgr::getInstance()->getSelection()->getObjectCount())
+                                {
+                                        can_unlink = true;
+                                }
+                        }
                 }
         }
         mBtnUnlink->setEnabled(can_unlink);
@@ -1035,15 +1066,15 @@ void LLFloaterTools::onFocusReceived()
 
 void LLFloaterTools::updateTreeGrassCombo(bool visible)
 {
+        LLTextBox* tree_grass_label = getChild<LLTextBox>("tree_grass_label");
         if (visible) 
         {
                 LLPCode pcode = LLToolPlacer::getObjectType();
                 std::map<std::string, S32>::iterator it, end;
                 std::string selected;
-                LLTextBox* tree_grass_label = getChild<LLTextBox>("tree_grass_label");
                 if (pcode == LLToolPlacerPanel::sTree) 
                 {
-                        tree_grass_label->setVisible(true);
+                        tree_grass_label->setVisible(visible);
                         LLButton* button = getChild<LLButton>("ToolTree");
                         tree_grass_label->setText(button->getToolTip());
 
@@ -1053,7 +1084,7 @@ void LLFloaterTools::updateTreeGrassCombo(bool visible)
                 } 
                 else if (pcode == LLToolPlacerPanel::sGrass) 
                 {
-                        tree_grass_label->setVisible(true);
+                        tree_grass_label->setVisible(visible);
                         LLButton* button = getChild<LLButton>("ToolGrass");
                         tree_grass_label->setText(button->getToolTip());
 
@@ -1089,6 +1120,7 @@ void LLFloaterTools::updateTreeGrassCombo(bool visible)
         }
         
         mComboTreesGrass->setVisible(visible);
+        tree_grass_label->setVisible(visible);
 }
 
 // static