From 53f855591c338bedfe619507c365b7ac4361d05d Mon Sep 17 00:00:00 2001 From: Pim van den Berg Date: Mon, 18 Apr 2011 20:06:58 +0200 Subject: plugin/zfs_arc: code cosmetics --- plugin/zfs_arc.php | 36 +++++++++++++++++------------------- 1 file changed, 17 insertions(+), 19 deletions(-) (limited to 'plugin') diff --git a/plugin/zfs_arc.php b/plugin/zfs_arc.php index 4a2592b..d40912d 100644 --- a/plugin/zfs_arc.php +++ b/plugin/zfs_arc.php @@ -14,16 +14,19 @@ require_once 'inc/collectd.inc.php'; # zfs_arc/arc_ratio-L1.rrd # zfs_arc/arc_ratio-L2.rrd # zfs_arc/arc_size.rrd + $obj = new Type_Default($CONFIG); $obj->width = $width; $obj->heigth = $heigth; +$obj->rrd_format = '%5.1lf%s'; + switch($obj->args['type']) { case 'arc_counts': $obj->data_sources = array( 'demand_data', 'demand_metadata', 'prefetch_data', - 'prefetch_metadata' + 'prefetch_metadata', ); $obj->colors = array( 'hits-demand_data' => 'ff0000', @@ -33,7 +36,7 @@ switch($obj->args['type']) { 'hits-prefetch_data' => '0000ff', 'misses-prefetch_data' => '00f0f0', 'hits-prefetch_metadata' => 'ff00ff', - 'misses-prefetch_metadata' => '888800' + 'misses-prefetch_metadata' => '888800', ); $obj->ds_names = array( 'hits-demand_data' => 'data hits', @@ -43,11 +46,10 @@ switch($obj->args['type']) { 'hits-prefetch_data' => 'prefetch data hits', 'misses-prefetch_data' => 'prefetch data misses', 'hits-prefetch_metadata' => 'prefetch metadata hits', - 'misses-prefetch_metadata' => 'prefetch metadata misses' + 'misses-prefetch_metadata' => 'prefetch metadata misses', ); $obj->rrd_title = 'arc counts'; $obj->rrd_vertical = 'count'; - $obj->rrd_format = '%5.1lf%s'; break; case 'arc_size': $obj->data_sources = array('current','target','minlimit','maxlimit'); @@ -55,48 +57,44 @@ switch($obj->args['type']) { 'current', 'target', 'minlimit', - 'maxlimit' + 'maxlimit', ); $obj->rrd_title = 'Arc size'; $obj->rrd_vertical = 'bytes'; - $obj->rrd_format = '%5.1lf%s'; break; case 'arc_l2_bytes': $obj->data_sources = array( 'write', - 'read' + 'read', ); $obj->ds_names = array( - 'write' => 'Write', - 'read' => 'Read', - ); + 'write' => 'Write', + 'read' => 'Read', + ); $obj->colors = array( - 'write' => 'ff0000', - 'read' => '0000ff', + 'write' => 'ff0000', + 'read' => '0000ff', ); $obj->rrd_title = 'Arc L2 bytes'; $obj->rrd_vertical = 'bytes'; - $obj->rrd_format = '%5.1lf%s'; break; case 'arc_l2_size': $obj->data_sources = array( - 'value' + 'value', ); $obj->ds_names = array( - 'value' => 'Bytes' - ); + 'value' => 'Bytes', + ); $obj->colors = array( - 'value' => '0000ff', + 'value' => '0000ff', ); $obj->rrd_title = 'Arc L2 size'; $obj->rrd_vertical = 'bytes'; - $obj->rrd_format = '%5.1lf%s'; break; case 'arc_ratio': $obj->data_sources = array('value'); $obj->rrd_title = 'Arc ratio'; $obj->rrd_vertical = 'ratio'; - $obj->rrd_format = '%5.1lf%s'; break; } collectd_flush($obj->identifiers); -- cgit v1.1