| Commit message (Collapse) | Author | Files | Lines |
|---|
|
Rename switch_endian to littleEndian to be more explicit (the meaning
is now inversed too). Make getEndianByteAt private since it is an
implementation detail.
Drop getStringAt as this is not used in this library. Move getCharAt
above getCStringAt since they are more related.
Move the methods definition for the current implementation to a new
function.
|
|
These parameters are not used in this library. Should it ever be
necessary to process a slice of data, then the caller should do so.
|
|
Use conditional compilation for the antique browsers that provide
VBScript support.
|
|
commit 2a74a333ff143499b465234f0395a4aad7bdaa78 ("Upgrade to
javascriptrrd ver 1.1.1") converted getByteAt calls to a getEndianByteAt
call, but this also introduced a branch operation. Since endianess is
dependent on the file, we can move the switch_endian check outside the
function.
Performance improved from 0.148ms (n=336k) to .039ms (n=384k) which
translates to about 30 seconds!
|
|
Added jshint comment on top, added "use strict". Added missing
semi-colons, converted to '===' (after validation).
Added comment for `typeof strData == "unknown"`. Break one long line
over two lines.
There are no other changes except for whitespace and line ending
changes. Check with `git diff -w`.
|
|
Many fall in the category missing semicolon, but there are legitimate
bugs (like throwing an error with an undefined variable, using
isInfinite instead of !isFinite or fabs instead of Math.abs).
At some places, I moved the variable declarations to avoid duplicate
definition warnings.
Redundant breaks have been removed (after return / throw).
Global variables were implicitly defined in RrdDataFile (which caught my
attention) and Base64, these have been made local.
Also fixed some whitespace errors. Yay, the consistency. Not all (style)
issues are fixed.
|
|
|
|
|
|
|
|
|
|
|
|
Also fix some typos and white-space issues. Reported at
https://github.com/pommi/CGP/issues/88
|
|
Make build_url return an URL, not HTML. This separates presentation
from data.
plugin_header's return value is unused, remove the unnecessary return.
At places where `printf("<tag att='%s'>", $x);` is used, it is now
converted to `printf("<tag att=\"%s\">", htmlentities($x));` since
the single quote is not escaped by default by htmlentities.
In case the canvas style is used, JS should use `textContent` instead
of `innerHTML` to avoid reading `"` instead of `"`. Nobody (should)
use(s) IE6 anymore, so it is a safe change.
While at it, use the standard charset attribute of meta to specify
the character set (UTF-8).
|
|
The value of HRULE could be a reference to for example a VDEF variable.
Closes #85
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
fetch and draw
|
|
|
|
|
|
|
|
The GPRINT of a VDEF doesn't have a CF. For example:
> "GPRINT:avg:LAST:%5.1lf%s Last"
> "GPRINT:tot:%5.1lf%s Total\l"
The format will be passed via the cf variable, so format is not defined. But it
didn't show up in the legend. Firebug showed variable format isn't undefined,
but an empty string in case of VDEF. So just check for falsy.
|
|
|
|
This fixes this error:
> TypeError: Cannot call method 'indexOf' of undefined at new RrdVdef
|
|
Source: https://github.com/manuelluis/jsrrdgraph@276b880
|
