| Commit message (Collapse) | Author | Files | Lines |
|
For example: "CPU Interface : 1" (snmp plugin + hp1810g switch)
|
|
Closes #123
|
|
|
|
|
|
For 4 types of devices:
a. desktop / tablet 10" landscape (default)
b. tablet 10" portrait / tablet 7" landscape
c. tablet 7" portrait / smartphone landscape
d. smartphone portrait
|
|
This works better in a responsive design.
|
|
|
|
And make sure all input from $_GET variables are parsed and validated.
|
|
as $_GET value
|
|
Closes #117
|
|
instance
Closes #113
|
|
This reverts commit 82d88098f4203cf7402d4faf5ad100cada70efaf.
Breaks async rendering, see
https://github.com/pommi/CGP/issues/106#issuecomment-66896905
|
|
So we don't depend on a remote source.
|
|
|
|
|
|
Closes #110
|
|
Closes #106
|
|
|
|
Best viewed with `git diff -w`.
Since CGP-sync.js and CGP-async.js are almost equal except for one
function call, merge them into a single function. While at it, reformat
CGP.js to expose a single namespace (`CGP`) which exports the symbol
`drawAll`.
Remove `alert()` and add a `console.error()` call instead. This is less
intrustive to users (who will notice a broken graph anyway) and be more
helpful for developers (who can examine the call trace in the Developer
Console.
Add `"use strict"` and use the standard four spaces as indent. Process
the script through `js-beautify` which re-indented the code and added
some spaces between operators. Replace double by single quotes for
consistency. Rename `catch(e)` to `catch(ex)` to supress a jshint
warning about IE8.
|
|
|
|
Closes #92
|
|
|
|
Fix a link when no class selected.
|
|
Report 400 Bad Request on query errors instead of reporting 200 OK
(which can be cached).
Add some additional validation for the 'x' and 'y' parameters, to catch
underflow (test with `x=-10` for example). Also fix a typo in the error
message and include more details (the actual error).
|
|
`[\w\W]` matches EVERYTHING. Validation failed. Also remove `\d` as that
`\w` is a superset of it.
Also check that the host parameter is actually non-empty, otherwise
`collectd_plugins` will happily return results as the directory
`$CONFIG['datadir'] . '/' . ''` trivially exists...
|
|
Also init info_array in case the output is empty.
|
|
index.php expects that collectd_hosts() always return an array for
array_diff. Since an empty array evaluates to FALSE anyway, do not
change the type and just return the empty array.
In base.php, if no files are returned, the loop is never called and
three variables are not initialized. Do it now.
|
|
Make build_url return an URL, not HTML. This separates presentation
from data.
plugin_header's return value is unused, remove the unnecessary return.
At places where `printf("<tag att='%s'>", $x);` is used, it is now
converted to `printf("<tag att=\"%s\">", htmlentities($x));` since
the single quote is not escaped by default by htmlentities.
In case the canvas style is used, JS should use `textContent` instead
of `innerHTML` to avoid reading `"` instead of `"`. Nobody (should)
use(s) IE6 anymore, so it is a safe change.
While at it, use the standard charset attribute of meta to specify
the character set (UTF-8).
|
|
|
|
|
|
|
|
Include graph.php instead of non-existing plugin/$plugin.php.
|
|
A couple of big changes here. A lot of logic moved to graph.php.
The PHP plugin files have been rewritten to JSON. In these JSON files
*everything* is optional. Also *NOT* having a JSON plugin file won't
block you from having a graph. The JSON will just make the graphs
prettier (by having a title, y-axis title, legend, colors, etc..).
The Collectd types.db file is parsed and used to determine RRD content.
When things are not defined in the JSON it will fallback to a default.
|
|
|
|
They generate html.
|
|
This means we have to check the return value of these functions for
example before doing a foreach. We can't just do a foreach and assume the
return value of a function is an array, while it can be false and results
in a PHP warning.
Closes: https://github.com/pommi/CGP/pull/68
|
|
And change all spaces to tabs.
|
|
|
|
Closes: https://github.com/pommi/CGP/issues/60
|
|
When there was a symlink in the path of $base, strpos($realpath, $base)
would have always return false.
Closes: https://github.com/pommi/CGP/pull/49
|
|
|
|
|
|
|
|
|
|
|
|
Closes: https://github.com/pommi/CGP/pull/35
|
|
|
|
The snmp plugin is saving if_octets this way:
<host>/snmp/if_octets-<port>.rrd
Where the interfaces plugin is saving if_octets with this structure:
<host>/interface-<port>/if_octets.rrd
|
|
|
|
The load average number turns:
* orange
When the load is higher than the number of cpu cores.
* red
When the load is more than twice as high as the number of cpu cores.
|