| Commit message (Collapse) | Author | Files | Lines |
|
Closes #106
|
|
|
|
Best viewed with `git diff -w`.
Since CGP-sync.js and CGP-async.js are almost equal except for one
function call, merge them into a single function. While at it, reformat
CGP.js to expose a single namespace (`CGP`) which exports the symbol
`drawAll`.
Remove `alert()` and add a `console.error()` call instead. This is less
intrustive to users (who will notice a broken graph anyway) and be more
helpful for developers (who can examine the call trace in the Developer
Console.
Add `"use strict"` and use the standard four spaces as indent. Process
the script through `js-beautify` which re-indented the code and added
some spaces between operators. Replace double by single quotes for
consistency. Rename `catch(e)` to `catch(ex)` to supress a jshint
warning about IE8.
|
|
|
|
Fix a link when no class selected.
|
|
Make build_url return an URL, not HTML. This separates presentation
from data.
plugin_header's return value is unused, remove the unnecessary return.
At places where `printf("<tag att='%s'>", $x);` is used, it is now
converted to `printf("<tag att=\"%s\">", htmlentities($x));` since
the single quote is not escaped by default by htmlentities.
In case the canvas style is used, JS should use `textContent` instead
of `innerHTML` to avoid reading `"` instead of `"`. Nobody (should)
use(s) IE6 anymore, so it is a safe change.
While at it, use the standard charset attribute of meta to specify
the character set (UTF-8).
|
|
|
|
Include graph.php instead of non-existing plugin/$plugin.php.
|
|
|
|
They generate html.
|
|
And change all spaces to tabs.
|
|
|
|
Closes: https://github.com/pommi/CGP/issues/60
|
|
|
|
|
|
Closes: https://github.com/pommi/CGP/pull/35
|
|
|
|
The load average number turns:
* orange
When the load is higher than the number of cpu cores.
* red
When the load is more than twice as high as the number of cpu cores.
|
|
|
|
|
|
Those can be gathered within the function.
|
|
|
|
For example when a non existing plugin is defined in $CONFIG['overview'] it
causes a lot of php warnings/notices.
|
|
This isn't needed with the new navigation menu anymore.
|
|
|
|
Signed-off-by: Pim van den Berg <pim@nethuis.nl>
|
|
When running CGP in the root, the header didn't link to the overview page
because the href was empty.
Reported-by: Nikoli <Nikoli@lavabit.com>
|
|
Including a lot of undefined $_GET values.
|
|
|
|
|
|
|
|
To select different background colors for the rows in the main
summary page, just uncomment the tr.odd/tr.even background
definition in layout/style.css and set the color.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Via the UnixSock plugin of Collectd it is possible to send commands to the
Collectd daemon. One of the commands is the FLUSH command, which you can
use to let the daemon write cached data to the rrd files.
CGP uses the FLUSH command before generating a graph and before showing
the load information on the main page. In this case the information shown
via CGP is always up-to-date. Also when you have configured the RRDTool
plugin of Collectd with a CacheTimeout setting.
This commit includes code based on functions collectd_identifier and
collectd_flush from php-collection by Bruno Prémont.
|
|
Include information in the title about the host, plugin,
plugin instance, type and type instance.
|
|
Show the host and plugin in the title to have a better browsing history.
|
|
The page is divided into a header, content and footer.
It is styled better and the header links to the main page.
Patch from Daniel von Fange (Leancoder):
http://pommi.nethuis.nl/storage/software/cgp/leancoder-css.cgp-v-0-1.patch
|
|
- Don't depend on includes from files that are included.
- Don't use webdir with includes/requires (also because webdir couldn't
be available in some cases).
- Use common.inc.php instead of config.php in all plugins to have all
configuration settings available.
|
|
|