| Commit message (Collapse) | Author | Files | Lines |
|
|
|
And make sure all input from $_GET variables are parsed and validated.
|
|
as $_GET value
|
|
This reverts commit 82d88098f4203cf7402d4faf5ad100cada70efaf.
Breaks async rendering, see
https://github.com/pommi/CGP/issues/106#issuecomment-66896905
|
|
Closes #106
|
|
|
|
Make build_url return an URL, not HTML. This separates presentation
from data.
plugin_header's return value is unused, remove the unnecessary return.
At places where `printf("<tag att='%s'>", $x);` is used, it is now
converted to `printf("<tag att=\"%s\">", htmlentities($x));` since
the single quote is not escaped by default by htmlentities.
In case the canvas style is used, JS should use `textContent` instead
of `innerHTML` to avoid reading `"` instead of `"`. Nobody (should)
use(s) IE6 anymore, so it is a safe change.
While at it, use the standard charset attribute of meta to specify
the character set (UTF-8).
|
|
A malicious user can enter javascript code in "h" GET parameter and this
code gets executed because this parameter is copied in the HTML output
without any escaping. This patch escape the output before it is checked
it is valid.
|
|
Include graph.php instead of non-existing plugin/$plugin.php.
Closes #75
|
|
This means we have to check the return value of these functions for
example before doing a foreach. We can't just do a foreach and assume the
return value of a function is an array, while it can be false and results
in a PHP warning.
Closes: https://github.com/pommi/CGP/pull/68
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Those can be gathered within the function.
|
|
|
|
Signed-off-by: Pim van den Berg <pim@nethuis.nl>
|
|
Since commit collectd-4.10.0-88-g02e12db the varnish plugin groups collected
values in categories. The collectd filestructure used for varnish is now:
<plugin>-<category>-<plugin_instance>/<type>-<type_instance>
Because this isn't distinguishable from a regular plugin like df, ...
df-var-tmp/df_complex-free.rrd ("var" isn't the category here)
... the category is only set with the varnish plugin.
Reported-by: Jonathan Huot <jonathan.huot@gmail.com>
|
|
When running CGP in the root, the header didn't link to the overview page
because the href was empty.
Reported-by: Nikoli <Nikoli@lavabit.com>
|
|
Including a lot of undefined $_GET values.
|
|
|
|
|
|
You can always return to the main page via the header. From the detail
page you can return to the host page by clicking the hostname.
|
|
These configuration options have been added:
- width
- heigth
- detail-width
- detail-heigth
|
|
The page is divided into a header, content and footer.
It is styled better and the header links to the main page.
Patch from Daniel von Fange (Leancoder):
http://pommi.nethuis.nl/storage/software/cgp/leancoder-css.cgp-v-0-1.patch
|
|
- Don't depend on includes from files that are included.
- Don't use webdir with includes/requires (also because webdir couldn't
be available in some cases).
- Use common.inc.php instead of config.php in all plugins to have all
configuration settings available.
|
|
|