diff options
author | Pim van den Berg | 2012-12-16 13:35:43 +0100 |
---|---|---|
committer | Pim van den Berg | 2012-12-16 13:35:43 +0100 |
commit | d8dd1c7c0b84eb30a02fc07f1df5f5f2ab6fb8a3 (patch) | |
tree | 46568f3bc6e65b09b3b299f38f5331ce1f82cefe | |
parent | type: add debug option "cmd" create a commandline rrdtool command (diff) | |
download | apt-panopticon_cgp-d8dd1c7c0b84eb30a02fc07f1df5f5f2ab6fb8a3.zip apt-panopticon_cgp-d8dd1c7c0b84eb30a02fc07f1df5f5f2ab6fb8a3.tar.gz apt-panopticon_cgp-d8dd1c7c0b84eb30a02fc07f1df5f5f2ab6fb8a3.tar.bz2 apt-panopticon_cgp-d8dd1c7c0b84eb30a02fc07f1df5f5f2ab6fb8a3.tar.xz |
type: escape colons in legend names
This problem showed up with IPv6 addresses in the NTP plugin.
Forgotten in commit:
v0.3-51-g330c94f [type: escape colons in filenames used in rrd commandline]
Diffstat (limited to '')
-rw-r--r-- | type/Default.class.php | 2 | ||||
-rw-r--r-- | type/GenericIO.class.php | 2 | ||||
-rw-r--r-- | type/GenericStacked.class.php | 2 | ||||
-rw-r--r-- | type/Uptime.class.php | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/type/Default.class.php b/type/Default.class.php index fd562b4..13e45c9 100644 --- a/type/Default.class.php +++ b/type/Default.class.php | |||
@@ -287,7 +287,7 @@ class Type_Default { | |||
287 | foreach ($sources as $source) { | 287 | foreach ($sources as $source) { |
288 | $dsname = $this->ds_names[$source] != '' ? $this->ds_names[$source] : $source; | 288 | $dsname = $this->ds_names[$source] != '' ? $this->ds_names[$source] : $source; |
289 | $color = is_array($this->colors) ? (isset($this->colors[$source])?$this->colors[$source]:$this->colors[$c++]): $this->colors; | 289 | $color = is_array($this->colors) ? (isset($this->colors[$source])?$this->colors[$source]:$this->colors[$c++]): $this->colors; |
290 | $rrdgraph[] = sprintf('LINE1:avg_%s#%s:\'%s\'', crc32hex($source), $this->validate_color($color), $dsname); | 290 | $rrdgraph[] = sprintf('LINE1:avg_%s#%s:\'%s\'', crc32hex($source), $this->validate_color($color), $this->rrd_escape($dsname)); |
291 | $rrdgraph[] = sprintf('GPRINT:min_%s:MIN:\'%s Min,\'', crc32hex($source), $this->rrd_format); | 291 | $rrdgraph[] = sprintf('GPRINT:min_%s:MIN:\'%s Min,\'', crc32hex($source), $this->rrd_format); |
292 | $rrdgraph[] = sprintf('GPRINT:avg_%s:AVERAGE:\'%s Avg,\'', crc32hex($source), $this->rrd_format); | 292 | $rrdgraph[] = sprintf('GPRINT:avg_%s:AVERAGE:\'%s Avg,\'', crc32hex($source), $this->rrd_format); |
293 | $rrdgraph[] = sprintf('GPRINT:max_%s:MAX:\'%s Max,\'', crc32hex($source), $this->rrd_format); | 293 | $rrdgraph[] = sprintf('GPRINT:max_%s:MAX:\'%s Max,\'', crc32hex($source), $this->rrd_format); |
diff --git a/type/GenericIO.class.php b/type/GenericIO.class.php index 3999ea6..bbbbea7 100644 --- a/type/GenericIO.class.php +++ b/type/GenericIO.class.php | |||
@@ -51,7 +51,7 @@ class Type_GenericIO extends Type_Default { | |||
51 | 51 | ||
52 | foreach($sources as $source) { | 52 | foreach($sources as $source) { |
53 | $dsname = $this->ds_names[$source] != '' ? $this->ds_names[$source] : $source; | 53 | $dsname = $this->ds_names[$source] != '' ? $this->ds_names[$source] : $source; |
54 | $rrdgraph[] = sprintf('LINE1:avg_%s#%s:\'%s\'', crc32hex($source), $this->colors[$source], $dsname); | 54 | $rrdgraph[] = sprintf('LINE1:avg_%s#%s:\'%s\'', crc32hex($source), $this->colors[$source], $this->rrd_escape($dsname)); |
55 | $rrdgraph[] = sprintf('GPRINT:min_%s:MIN:\'%s Min,\'', crc32hex($source), $this->rrd_format); | 55 | $rrdgraph[] = sprintf('GPRINT:min_%s:MIN:\'%s Min,\'', crc32hex($source), $this->rrd_format); |
56 | $rrdgraph[] = sprintf('GPRINT:avg_%s:AVERAGE:\'%s Avg,\'', crc32hex($source), $this->rrd_format); | 56 | $rrdgraph[] = sprintf('GPRINT:avg_%s:AVERAGE:\'%s Avg,\'', crc32hex($source), $this->rrd_format); |
57 | $rrdgraph[] = sprintf('GPRINT:max_%s:MAX:\'%s Max,\'', crc32hex($source), $this->rrd_format); | 57 | $rrdgraph[] = sprintf('GPRINT:max_%s:MAX:\'%s Max,\'', crc32hex($source), $this->rrd_format); |
diff --git a/type/GenericStacked.class.php b/type/GenericStacked.class.php index f306532..a0ae4c5 100644 --- a/type/GenericStacked.class.php +++ b/type/GenericStacked.class.php | |||
@@ -53,7 +53,7 @@ class Type_GenericStacked extends Type_Default { | |||
53 | foreach ($sources as $source) { | 53 | foreach ($sources as $source) { |
54 | $dsname = $this->ds_names[$source] != '' ? $this->ds_names[$source] : $source; | 54 | $dsname = $this->ds_names[$source] != '' ? $this->ds_names[$source] : $source; |
55 | $color = is_array($this->colors) ? (isset($this->colors[$source])?$this->colors[$source]:$this->colors[$c++]) : $this->colors; | 55 | $color = is_array($this->colors) ? (isset($this->colors[$source])?$this->colors[$source]:$this->colors[$c++]) : $this->colors; |
56 | $rrdgraph[] = sprintf('LINE1:area_%s#%s:\'%s\'', crc32hex($source), $this->validate_color($color), $dsname); | 56 | $rrdgraph[] = sprintf('LINE1:area_%s#%s:\'%s\'', crc32hex($source), $this->validate_color($color), $this->rrd_escape($dsname)); |
57 | $rrdgraph[] = sprintf('GPRINT:min_%s:MIN:\'%s Min,\'', crc32hex($source), $this->rrd_format); | 57 | $rrdgraph[] = sprintf('GPRINT:min_%s:MIN:\'%s Min,\'', crc32hex($source), $this->rrd_format); |
58 | $rrdgraph[] = sprintf('GPRINT:avg_%s:AVERAGE:\'%s Avg,\'', crc32hex($source), $this->rrd_format); | 58 | $rrdgraph[] = sprintf('GPRINT:avg_%s:AVERAGE:\'%s Avg,\'', crc32hex($source), $this->rrd_format); |
59 | $rrdgraph[] = sprintf('GPRINT:max_%s:MAX:\'%s Max,\'', crc32hex($source), $this->rrd_format); | 59 | $rrdgraph[] = sprintf('GPRINT:max_%s:MAX:\'%s Max,\'', crc32hex($source), $this->rrd_format); |
diff --git a/type/Uptime.class.php b/type/Uptime.class.php index cadb8dd..aa91a6e 100644 --- a/type/Uptime.class.php +++ b/type/Uptime.class.php | |||
@@ -45,7 +45,7 @@ class Type_Uptime extends Type_Default { | |||
45 | $color = is_array($this->colors) ? (isset($this->colors[$source])?$this->colors[$source]:$this->colors[$c++]) : $this->colors; | 45 | $color = is_array($this->colors) ? (isset($this->colors[$source])?$this->colors[$source]:$this->colors[$c++]) : $this->colors; |
46 | 46 | ||
47 | //current value | 47 | //current value |
48 | $rrdgraph[] = sprintf('LINE1:area_%s#%s:\'%s\'', crc32hex($source), $this->validate_color($color), $dsname); | 48 | $rrdgraph[] = sprintf('LINE1:area_%s#%s:\'%s\'', crc32hex($source), $this->validate_color($color), $this->rrd_escape($dsname)); |
49 | $rrdgraph[] = sprintf('GPRINT:c_avg_%s:LAST:\'%s days\\l\'', crc32hex($source), $this->rrd_format); | 49 | $rrdgraph[] = sprintf('GPRINT:c_avg_%s:LAST:\'%s days\\l\'', crc32hex($source), $this->rrd_format); |
50 | 50 | ||
51 | //max value | 51 | //max value |